Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-22 Thread Jason Merrill
On Thu, Oct 17, 2019 at 6:22 PM Jakub Jelinek wrote: > > On Wed, Oct 16, 2019 at 04:36:07PM -0400, Jason Merrill wrote: > > > As for CLEANUP_STMT, I've tried it (the second patch), but it didn't > > > change > > > anything, the diagnostics was still > > > constexpr-dtor3.C:16:23: in ‘constexpr’

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-17 Thread Jakub Jelinek
On Wed, Oct 16, 2019 at 04:36:07PM -0400, Jason Merrill wrote: > > As for CLEANUP_STMT, I've tried it (the second patch), but it didn't change > > anything, the diagnostics was still > > constexpr-dtor3.C:16:23: in ‘constexpr’ expansion of ‘f4()’ > > constexpr-dtor3.C:16:24: in ‘constexpr’ expa

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-16 Thread Jason Merrill
On 10/16/19 12:27 PM, Jakub Jelinek wrote: > On Fri, Oct 11, 2019 at 04:14:16PM -0400, Jason Merrill wrote: >>> On x86_64 and most other targets, cleanup here (if non-NULL) is the >>> CALL_EXPR, as destructor return type is void, but on arm, as the dtor return >>> type is some pointer, the CALL_EXP

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-16 Thread Jason Merrill
On 10/16/19 12:27 PM, Jakub Jelinek wrote: On Fri, Oct 11, 2019 at 04:14:16PM -0400, Jason Merrill wrote: On x86_64 and most other targets, cleanup here (if non-NULL) is the CALL_EXPR, as destructor return type is void, but on arm, as the dtor return type is some pointer, the CALL_EXPR is wrappe

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-16 Thread Jakub Jelinek
On Fri, Oct 11, 2019 at 04:14:16PM -0400, Jason Merrill wrote: > > On x86_64 and most other targets, cleanup here (if non-NULL) is the > > CALL_EXPR, as destructor return type is void, but on arm, as the dtor return > > type is some pointer, the CALL_EXPR is wrapped into a NOP_EXPR to void. > > pro

Re: [PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-11 Thread Jason Merrill
On 10/11/19 4:20 AM, Jakub Jelinek wrote: On Thu, Oct 10, 2019 at 05:38:21PM -0400, Jason Merrill wrote: FAIL: g++.dg/cpp2a/constexpr-dtor3.C -std=c++2a (test for excess errors) Excess errors: /gcc/testsuite/g++.dg/cpp2a/constexpr-dtor3.C:152:12: in 'constexpr' expansion of '(& w13)->W7::~W7(

[PATCH] Fix constexpr-dtor3.C FAIL on arm

2019-10-11 Thread Jakub Jelinek
On Thu, Oct 10, 2019 at 05:38:21PM -0400, Jason Merrill wrote: > > FAIL: g++.dg/cpp2a/constexpr-dtor3.C -std=c++2a (test for excess errors) > > Excess errors: > > /gcc/testsuite/g++.dg/cpp2a/constexpr-dtor3.C:152:12: in 'constexpr' > > expansion of '(& w13)->W7::~W7()' > > > > This also seems u