Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Magnus Fromreide
On Fri, 2012-04-13 at 16:50 +0200, Bernd Schmidt wrote: > On 04/13/2012 04:44 PM, Jakub Jelinek wrote: > > On Fri, Apr 13, 2012 at 04:33:17PM +0200, Bernd Schmidt wrote: > >> On 04/13/2012 04:20 PM, Mike Stump wrote: > >>> On Apr 13, 2012, at 5:30 AM, NightStrike wrote: > > no warning from trun

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Mike Stump
On Apr 13, 2012, at 7:50 AM, Bernd Schmidt wrote: > The problem is that a human might be > confused, for example due to bad indentation. Whether there's a for in > between doesn't matter for this purpose, the following is most likely a bug: > > if () > for (..) >if () > x > else > y I

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread NightStrike
On Fri, Apr 13, 2012 at 10:33 AM, Bernd Schmidt wrote: > On 04/13/2012 04:20 PM, Mike Stump wrote: >> On Apr 13, 2012, at 5:30 AM, NightStrike wrote: no warning from trunk.  Which GCC version emits this warning? >> >>> Looks like cygwin gcc 3.4.4 >> >> 3.4.4 is a little old now..  We'd encour

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread NightStrike
On Fri, Apr 13, 2012 at 10:20 AM, Mike Stump wrote: > On Apr 13, 2012, at 5:30 AM, NightStrike wrote: >>> no warning from trunk.  Which GCC version emits this warning? > >> Looks like cygwin gcc 3.4.4 > > 3.4.4 is a little old now..  We'd encourage an upgrade to a fine new > compiler...  :-) Yea

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Bernd Schmidt
On 04/13/2012 04:44 PM, Jakub Jelinek wrote: > On Fri, Apr 13, 2012 at 04:33:17PM +0200, Bernd Schmidt wrote: >> On 04/13/2012 04:20 PM, Mike Stump wrote: >>> On Apr 13, 2012, at 5:30 AM, NightStrike wrote: > no warning from trunk. Which GCC version emits this warning? >>> Looks like cygw

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Jakub Jelinek
On Fri, Apr 13, 2012 at 04:33:17PM +0200, Bernd Schmidt wrote: > On 04/13/2012 04:20 PM, Mike Stump wrote: > > On Apr 13, 2012, at 5:30 AM, NightStrike wrote: > >>> no warning from trunk. Which GCC version emits this warning? > > > >> Looks like cygwin gcc 3.4.4 > > > > 3.4.4 is a little old now

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Bernd Schmidt
On 04/13/2012 04:20 PM, Mike Stump wrote: > On Apr 13, 2012, at 5:30 AM, NightStrike wrote: >>> no warning from trunk. Which GCC version emits this warning? > >> Looks like cygwin gcc 3.4.4 > > 3.4.4 is a little old now.. We'd encourage an upgrade to a fine new > compiler... :-) The thing is

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread Mike Stump
On Apr 13, 2012, at 5:30 AM, NightStrike wrote: >> no warning from trunk. Which GCC version emits this warning? > Looks like cygwin gcc 3.4.4 3.4.4 is a little old now.. We'd encourage an upgrade to a fine new compiler... :-)

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-13 Thread NightStrike
On Wed, Apr 11, 2012 at 4:46 AM, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 9:08 PM, NightStrike wrote: >> On Tue, Apr 10, 2012 at 10:38 AM, Richard Guenther >> wrote: >>> On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: On 4/10/2012 20:37, Richard Guenther wrote: > On Tue, Apr 10,

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-11 Thread Richard Guenther
On Tue, Apr 10, 2012 at 9:08 PM, NightStrike wrote: > On Tue, Apr 10, 2012 at 10:38 AM, Richard Guenther > wrote: >> On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: >>> On 4/10/2012 20:37, Richard Guenther wrote: On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: > Hi, > > Patch OK?

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread NightStrike
On Tue, Apr 10, 2012 at 10:38 AM, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: >> On 4/10/2012 20:37, Richard Guenther wrote: >>> On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: Hi, Patch OK? >>> >>> What kind of warning? >>> >> >> Oops, I forgot to mention g

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 3:06 PM, JonY wrote: > On 4/10/2012 20:37, Richard Guenther wrote: >> On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: >>> Hi, >>> >>> Patch OK? >> >> What kind of warning? >> > > Oops, I forgot to mention gcc was complaining about missing braces. Not for me. And I fail to se

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread JonY
On 4/10/2012 20:37, Richard Guenther wrote: > On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: >> Hi, >> >> Patch OK? > > What kind of warning? > Oops, I forgot to mention gcc was complaining about missing braces. >> ChangeLog: >> tree-parloops.c (eliminate_local_variables): Add braces to suppress

Re: [Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread Richard Guenther
On Tue, Apr 10, 2012 at 2:15 PM, JonY wrote: > Hi, > > Patch OK? What kind of warning? > ChangeLog: > tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings. > > Index: tree-parloops.c > === > --- tree-parloops

[Patch] tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings

2012-04-10 Thread JonY
Hi, Patch OK? ChangeLog: tree-parloops.c (eliminate_local_variables): Add braces to suppress warnings. Index: tree-parloops.c === --- tree-parloops.c (revision 186243) +++ tree-parloops.c (working copy) @@ -723,13 +723,15 @@