Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Steven Bosscher
On Mon, Mar 26, 2012 at 10:51 PM, Eric Botcazou wrote: >> Index: varasm.c >> === >> --- varasm.c  (revision 185823) >> +++ varasm.c  (working copy) >> @@ -2170,6 +2170,10 @@ >>        If it's not, we should not be calling this functio

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Eric Botcazou
> Index: varasm.c > === > --- varasm.c (revision 185823) > +++ varasm.c (working copy) > @@ -2170,6 +2170,10 @@ >If it's not, we should not be calling this function. */ >gcc_assert (asm_out_file); > > + /* In a perfect

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Steven Bosscher
On Mon, Mar 26, 2012 at 8:51 PM, Steven Bosscher wrote: > On Mon, Mar 26, 2012 at 8:22 PM, H.J. Lu wrote: >> It may have caused: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730 > > It certainly seems so. Looking into it... Java is the culprit. I'm going to commit the following patch to p

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Steven Bosscher
On Mon, Mar 26, 2012 at 8:22 PM, H.J. Lu wrote: > It may have caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52730 It certainly seems so. Looking into it... Ciao! Steven

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread H.J. Lu
On Mon, Mar 26, 2012 at 9:26 AM, Steven Bosscher wrote: > On Mon, Mar 26, 2012 at 9:31 AM, Richard Guenther > wrote: >> On Mon, Mar 26, 2012 at 1:27 AM, Steven Bosscher >> wrote: >>> Hello, >>> >>> This patch removes all calls to assemble_external from places other >>> than final.c and MI-thunk

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Steven Bosscher
On Mon, Mar 26, 2012 at 9:31 AM, Richard Guenther wrote: > On Mon, Mar 26, 2012 at 1:27 AM, Steven Bosscher > wrote: >> Hello, >> >> This patch removes all calls to assemble_external from places other >> than final.c and MI-thunk generators. >> >> This is step 2 toward addressing PR17982 on the

Re: [patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-26 Thread Richard Guenther
On Mon, Mar 26, 2012 at 1:27 AM, Steven Bosscher wrote: > Hello, > > This patch removes all calls to assemble_external from places other > than final.c and MI-thunk generators. > > This is step 2 toward addressing PR17982 on the trunk for GCC 4.8. The > next, and final, step will be to change pend

[patch] Call assemble_external only from final.c and from MI-thunk hooks

2012-03-25 Thread Steven Bosscher
Hello, This patch removes all calls to assemble_external from places other than final.c and MI-thunk generators. This is step 2 toward addressing PR17982 on the trunk for GCC 4.8. The next, and final, step will be to change pending_assemble_externals to pending_assemble_visibility, and fold assem