Re: Patches to enable -ftrack-macro-expansion by default

2012-08-26 Thread Dodji Seketeli
Gabriel Dos Reis g...@integrable-solutions.net writes: I think we show the stack not just for errors, but for any diagnostics. I agree, FWIW. -- Dodji

Re: Patches to enable -ftrack-macro-expansion by default

2012-08-26 Thread Gerald Pfeifer
On Sun, 26 Aug 2012, Dodji Seketeli wrote: Gabriel Dos Reis g...@integrable-solutions.net writes: I think we show the stack not just for errors, but for any diagnostics. I agree, FWIW. Good point, thanks for the feedback! I have applied the following, updated patch. Gerald Index:

Re: Patches to enable -ftrack-macro-expansion by default

2012-08-26 Thread Gabriel Dos Reis
On Sun, Aug 26, 2012 at 3:00 PM, Gerald Pfeifer ger...@pfeifer.com wrote: I have applied the following, updated patch. Thank you! -- Gaby

Re: Patches to enable -ftrack-macro-expansion by default

2012-08-25 Thread Gerald Pfeifer
On Mon, 30 Apr 2012, Dodji Seketeli wrote: I have finally applied this series of 14 patches to the mainline today. The SVN revisions are from r186965 to r186978. Shouldn't we document this in the release notes? What do you guys think about the following? Suggestions welcome. Gerald Index:

Re: Patches to enable -ftrack-macro-expansion by default

2012-08-25 Thread Gabriel Dos Reis
On Sat, Aug 25, 2012 at 7:28 PM, Gerald Pfeifer ger...@pfeifer.com wrote: On Mon, 30 Apr 2012, Dodji Seketeli wrote: I have finally applied this series of 14 patches to the mainline today. The SVN revisions are from r186965 to r186978. Shouldn't we document this in the release notes? What

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-08 Thread Andreas Krebbel
On 04/30/2012 01:46 PM, Dodji Seketeli wrote: Dodji Seketeli do...@redhat.com writes: I am proposing a series of patches which is supposed to address the remaining issues (I am aware of) preventing us from enabling the -ftrack-macro-expansion by default. The idea is to address each issue I

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-02 Thread Uros Bizjak
On Tue, May 1, 2012 at 6:04 PM, Dodji Seketeli do...@redhat.com wrote:     pfile-context = XNEW (cpp_context); +  memset (pfile-context, 0, sizeof (cpp_context)); You can use XCNEW instead of XNEW + memset. OK with that change. Thank you. Here is the patch I will commit when Uros

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-02 Thread Dodji Seketeli
Uros Bizjak ubiz...@gmail.com writes: On Tue, May 1, 2012 at 6:04 PM, Dodji Seketeli do...@redhat.com wrote:     pfile-context = XNEW (cpp_context); +  memset (pfile-context, 0, sizeof (cpp_context)); You can use XCNEW instead of XNEW + memset. OK with that change. Thank you. Here is

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-01 Thread Uros Bizjak
Hello! I am proposing a series of patches which is supposed to address the remaining issues (I am aware of) preventing us from enabling the -ftrack-macro-expansion by default. The idea is to address each issue I notice in the course of trying to bootstrap the compiler and running the

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-01 Thread Dodji Seketeli
Uros Bizjak ubiz...@gmail.com writes: Your patch introduced: FAIL: gcc.dg/gomp/macro-4.c (internal compiler error) FAIL: gcc.dg/gomp/macro-4.c (test for excess errors) on alphaev68-pc-linux-gnu. The failure is silent on x86_64-pc-linux-gnu, but can be uncovered by valgrind: $ valgrind

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-01 Thread Dodji Seketeli
Dodji Seketeli do...@redhat.com writes: Tested on x86_64-unknown-linux-gnu against trunk by running the test gcc.dg/gomp/macro-4.c under Valgrind. Bootstrap is still underway. For what it's worth, the patch passes bootstrap on x86_64-unknown-linux-gnu. libcpp/ * directives.c

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-01 Thread Jason Merrill
On 05/01/2012 05:36 AM, Dodji Seketeli wrote: pfile-context = XNEW (cpp_context); + memset (pfile-context, 0, sizeof (cpp_context)); You can use XCNEW instead of XNEW + memset. OK with that change. Jason

Re: Patches to enable -ftrack-macro-expansion by default

2012-05-01 Thread Dodji Seketeli
Jason Merrill ja...@redhat.com writes: On 05/01/2012 05:36 AM, Dodji Seketeli wrote: pfile-context = XNEW (cpp_context); + memset (pfile-context, 0, sizeof (cpp_context)); You can use XCNEW instead of XNEW + memset. OK with that change. Thank you. Here is the patch I will commit

Re: Patches to enable -ftrack-macro-expansion by default

2012-04-30 Thread Dodji Seketeli
Dodji Seketeli do...@redhat.com writes: I am proposing a series of patches which is supposed to address the remaining issues (I am aware of) preventing us from enabling the -ftrack-macro-expansion by default. The idea is to address each issue I notice in the course of trying to bootstrap

Patches to enable -ftrack-macro-expansion by default

2012-04-10 Thread Dodji Seketeli
Hello, I am proposing a series of patches which is supposed to address the remaining issues (I am aware of) preventing us from enabling the -ftrack-macro-expansion by default. The idea is to address each issue I notice in the course of trying to bootstrap the compiler and running the tests with