Re: [Bug libstdc++/85845] [9 Regression] Many libstdc++ test failures

2018-05-22 Thread Paolo Carlini

Hi,

On 22/05/2018 11:24, Richard Biener wrote:

On Mon, May 21, 2018 at 7:01 PM François Dumont 
wrote:


I just committed this patch as trivial.
I must have run tests without rebuilding pre-compiled headers. I'll have
to find out how to build tests without pre-compiled headers to avoid it
in the future.

I configure with --disable-libstdcxx-pch which also reduces build-time.
If I understand correctly the issue, to test without PCHs I used to 
configure / test / etc normally and then by-hand remove the generated 
PCHs and run make check inside libstdc++-v3/testsuite (*not* inside 
libstdc++-v3) in case of need. It's an HACK, which exploits sort of a 
bug: in that case make check doesn't lead to the automatic regeneration 
of the PCHs.


Paolo.


Re: [Bug libstdc++/85845] [9 Regression] Many libstdc++ test failures

2018-05-22 Thread Richard Biener
On Mon, May 21, 2018 at 7:01 PM François Dumont 
wrote:

> I just committed this patch as trivial.

> I must have run tests without rebuilding pre-compiled headers. I'll have
> to find out how to build tests without pre-compiled headers to avoid it
> in the future.

I configure with --disable-libstdcxx-pch which also reduces build-time.

RIchard.

> François

> On 20/05/2018 19:06, fdumont at gcc dot gnu.org wrote:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85845
> >
> > François Dumont  changed:
> >
> > What|Removed |Added
> >

> >   Status|NEW |ASSIGNED
> > Assignee|unassigned at gcc dot gnu.org  |fdumont at gcc
dot gnu.org
> >


Re: [Bug libstdc++/85845] [9 Regression] Many libstdc++ test failures

2018-05-21 Thread François Dumont

I just committed this patch as trivial.

I must have run tests without rebuilding pre-compiled headers. I'll have 
to find out how to build tests without pre-compiled headers to avoid it 
in the future.


François

On 20/05/2018 19:06, fdumont at gcc dot gnu.org wrote:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85845

François Dumont  changed:

What|Removed |Added

  Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org  |fdumont at gcc dot 
gnu.org



Index: include/bits/stl_tree.h
===
--- include/bits/stl_tree.h	(revision 260477)
+++ include/bits/stl_tree.h	(working copy)
@@ -980,7 +980,7 @@
 public:
   _Rb_tree(_Rb_tree&& __x, _Node_allocator&& __a)
   noexcept( noexcept(
-	_Rb_tree(std::declval<_Rb_tree>(), std::declval<_Node_allocator>(),
+	_Rb_tree(std::declval<_Rb_tree&&>(), std::declval<_Node_allocator&&>(),
 		 std::declval())) )
   : _Rb_tree(std::move(__x), std::move(__a),
 		 typename _Alloc_traits::is_always_equal{})