Re: [FORTRAN PATCH] Two -Wlogical-not-parentheses fixes (PR fortran/62270)

2014-09-03 Thread Marek Polacek 
On Tue, Sep 02, 2014 at 09:29:51PM +0200, Thomas Koenig wrote:
 Am 02.09.2014 17:32, schrieb Tobias Burnus:
  
  Marek Polacek wrote:
  This patch fixes the last two spots where -Wlogical-not-parentheses
  warns.  See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62270#c3
  if you want more info about the changes.
 
  Bootstrapped/regtested on x86_64-linux, ok for trunk?
  
  Looks good to me. Thanks for the patch!
 
 As this commit fixes obvious errors for not-so-obvious
 cases, what about a backport?

Yep, I'll apply the same patch to 4.9.  And for 4.8 only the
interface.c part.

Marek

Re: [FORTRAN PATCH] Two -Wlogical-not-parentheses fixes (PR fortran/62270)

2014-09-02 Thread Tobias Burnus 

Marek Polacek wrote:
 This patch fixes the last two spots where -Wlogical-not-parentheses
 warns.  See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62270#c3
 if you want more info about the changes.

 Bootstrapped/regtested on x86_64-linux, ok for trunk?

Looks good to me. Thanks for the patch!

Tobias

 2014-09-02  Marek Polacek  pola...@redhat.com

   PR fortran/62270
   * interface.c (compare_parameter): Fix condition.
   * trans-expr.c (gfc_conv_procedure_call): Likewise.
 
   * gfortran.dg/pointer_intent_7.f90: Adjust dg-error.

Re: [FORTRAN PATCH] Two -Wlogical-not-parentheses fixes (PR fortran/62270)

2014-09-02 Thread Thomas Koenig 
Am 02.09.2014 17:32, schrieb Tobias Burnus:
 
 Marek Polacek wrote:
 This patch fixes the last two spots where -Wlogical-not-parentheses
 warns.  See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62270#c3
 if you want more info about the changes.

 Bootstrapped/regtested on x86_64-linux, ok for trunk?
 
 Looks good to me. Thanks for the patch!

As this commit fixes obvious errors for not-so-obvious
cases, what about a backport?

Thomas