Re: [PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-12-13 Thread Chung-Lin Tang
On 2018/12/6 10:43 PM, Jakub Jelinek wrote: On Thu, Dec 06, 2018 at 10:19:43PM +0800, Chung-Lin Tang wrote: Why do you call the non-contiguous arrays dynamic arrays? Is that some OpenACC term? I'd also prefix those with gomp_ and it is important to make it clear what is the ABI type shared

Re: [PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-12-06 Thread Jakub Jelinek
On Thu, Dec 06, 2018 at 10:19:43PM +0800, Chung-Lin Tang wrote: > > Why do you call the non-contiguous arrays dynamic arrays? Is that some > > OpenACC term? > > I'd also prefix those with gomp_ and it is important to make it clear what > > is the ABI type shared with the compiler and what are

Re: [PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-12-06 Thread Chung-Lin Tang
Hi Jakub, thanks for the swift review a few weeks ago, and apologies I haven't been able to respond sooner. On 2018/10/16 9:13 PM, Jakub Jelinek wrote:>> +/* Dynamic array related data structures, interfaces with the compiler. */ + +struct da_dim { + size_t base; + size_t length; + size_t

Re: [PATCH, OpenACC, 7/8] Multi-dimensional dynamic array support for OpenACC data clauses, libgomp support

2018-10-16 Thread Jakub Jelinek
On Tue, Oct 16, 2018 at 08:57:00PM +0800, Chung-Lin Tang wrote: > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -490,6 +490,140 @@ gomp_map_val (struct target_mem_desc *tgt, void > **hostaddrs, size_t i) >return tgt->tgt_start + tgt->list[i].offset; > } > > +/* Dynamic array related