Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-12 Thread Pierre-Marie de Rodat
On 10/12/2016 10:15 AM, Richard Biener wrote: Ok. Thanks, Committed. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-12 Thread Richard Biener
On Tue, Oct 11, 2016 at 4:39 PM, Pierre-Marie de Rodat wrote: > On 09/28/2016 09:48 AM, Richard Biener wrote: >> >> Hmm, interesting approach. It might work reliably at this point of >> the compilation >> but we do actually recycle cgraph nodes. > > > Arf, what a pity. ;-) > >> So I wonder if giv

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-11 Thread Pierre-Marie de Rodat
On 09/28/2016 09:48 AM, Richard Biener wrote: Hmm, interesting approach. It might work reliably at this point of the compilation but we do actually recycle cgraph nodes. Arf, what a pity. ;-) So I wonder if given we do have ->origin / ->next_nested in the cgraph if we can simply perform a wa

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-28 Thread Richard Biener
On Tue, Sep 27, 2016 at 4:01 PM, Pierre-Marie de Rodat wrote: > On 09/07/2016 11:30 AM, Richard Biener wrote: >> >> That said, with the idea of early debug in place and thus giving >> more responsibility to the frontends I wonder in what order the Ada >> FE calls debug_hooks.early_global_decl ()?

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-27 Thread Pierre-Marie de Rodat
On 09/07/2016 11:30 AM, Richard Biener wrote: That said, with the idea of early debug in place and thus giving more responsibility to the frontends I wonder in what order the Ada FE calls debug_hooks.early_global_decl ()? Maybe it's the middle-end and it should arrange for a more natural order on

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-08 Thread Pierre-Marie de Rodat
On 09/07/2016 11:30 AM, Richard Biener wrote: Ok, had time to look at this issue again. I see the patch works like dwarf2out works currently with respect to DIE creation order and re-location. Thank you very much for helping me with this again! So yes, that was the intent of the patch. this

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-07 Thread Richard Biener
On Tue, Sep 6, 2016 at 10:43 AM, Pierre-Marie de Rodat wrote: > Hello, > > On 08/29/2016 11:03 AM, Pierre-Marie de Rodat wrote: >> >> Here is another attempt to solve the original issue. This time, with a >> proper testcase. ;-) >> >> Rebased against trunk, boostrapped and regtested on x86_64-linu