Re: [PATCH, rs6000] pr65479 Add option to fix failing asan test cases.

2016-10-17 Thread Bill Seurer

On 10/14/2016 04:59 PM, Segher Boessenkool wrote:

On Fri, Oct 14, 2016 at 02:37:42PM -0500, Bill Seurer wrote:

[PATCH, rs6000] pr65479 Add option to fix failing asan test cases.

This patch adds the -fasynchronous-unwind-tables option to several of the asan
test cases.  The option causes a full strack trace to be produced when the
sanitizer detects an error.  Without the full trace the 3 test cases fail.


Should we enable this whenever asan is used, instead?  Not just in the
testsuite?  And is this actually PowerPC-specific?


It is needed on these tests because of how they check the traceback 
stack looking for specific functions.  Without the option only the first 
(triggering) function is included.


I don't know if the option is power specific but on x86 for instance the 
traceback gives all the functions without the option.

--

-Bill Seurer



Re: [PATCH, rs6000] pr65479 Add option to fix failing asan test cases.

2016-10-14 Thread Segher Boessenkool
On Fri, Oct 14, 2016 at 02:37:42PM -0500, Bill Seurer wrote:
> [PATCH, rs6000] pr65479 Add option to fix failing asan test cases.
> 
> This patch adds the -fasynchronous-unwind-tables option to several of the asan
> test cases.  The option causes a full strack trace to be produced when the
> sanitizer detects an error.  Without the full trace the 3 test cases fail.

Should we enable this whenever asan is used, instead?  Not just in the
testsuite?  And is this actually PowerPC-specific?


Segher