William J. Schmidt wschm...@linux.vnet.ibm.com writes:
Index: gcc/testsuite/gcc.target/powerpc/pr46728-13.c
===
--- gcc/testsuite/gcc.target/powerpc/pr46728-13.c (revision 185247)
+++
Rainer Orth r...@cebitec.uni-bielefeld.de writes:
+/* { dg-skip-if { powerpc*-*-darwin* } { * } { } } */
Please omit defaults to dg-skip-if: { * } { } are unnecessary and
make the directive harder to read.
Oh, I forgot: please indicate why you are skipping the test in the
comment field,
OK, will do. I just copied the style of some other test cases that
skipped darwin, assuming that was the preferred syntax.
Thanks,
Bill
On Mon, 2012-03-12 at 19:40 +0100, Rainer Orth wrote:
Rainer Orth r...@cebitec.uni-bielefeld.de writes:
+/* { dg-skip-if { powerpc*-*-darwin* } { * } {
William J. Schmidt wschm...@linux.vnet.ibm.com writes:
OK, will do. I just copied the style of some other test cases that
skipped darwin, assuming that was the preferred syntax.
No problem, I'll probably make a pass over the whole testsuite to remove
that cruft to avoid misleading others.
On Mon, 2012-03-12 at 20:15 +0100, Rainer Orth wrote:
William J. Schmidt wschm...@linux.vnet.ibm.com writes:
OK, will do. I just copied the style of some other test cases that
skipped darwin, assuming that was the preferred syntax.
No problem, I'll probably make a pass over the whole
On Mar 12, 2012, at 12:29 PM, William J. Schmidt wrote:
Thanks, Rainer. Here's a revised patch. OK to commit?
Ok. Thanks.
