Re: [PATCH]: Restore alpha boostrap by partial revert

2012-04-02 Thread Richard Guenther
On Mon, 2 Apr 2012, Uros Bizjak wrote:

> On Mon, Apr 2, 2012 at 10:21 AM, Richard Guenther  wrote:
> 
> >> 2012-03-31  Uros Bizjak  
> >>
> >>       Partially revert:
> >>       2012-03-29  Richard Guenther  
> >>
> >>       * rtl.h (extended_count): Remove.
> >>       * combine.c (extended_count): Remove.
> >>
> >> Bootstrapped on alphaev68-pc-linux-gnu.
> >>
> >> OK for mainline?
> >
> > As alpha is the only user and this does not look in any way
> > "combine" specific, can you move it to alpha.c instead please?
> 
> This was the first thing I thought, but the function uses
> nonzero_sign_valid, a variable local to combine.c

Hmm, how ugly ;)  Your patch is ok then.

Sorry for the breakage.

Richard.

Re: [PATCH]: Restore alpha boostrap by partial revert

2012-04-02 Thread Uros Bizjak
On Mon, Apr 2, 2012 at 10:21 AM, Richard Guenther  wrote:

>> 2012-03-31  Uros Bizjak  
>>
>>       Partially revert:
>>       2012-03-29  Richard Guenther  
>>
>>       * rtl.h (extended_count): Remove.
>>       * combine.c (extended_count): Remove.
>>
>> Bootstrapped on alphaev68-pc-linux-gnu.
>>
>> OK for mainline?
>
> As alpha is the only user and this does not look in any way
> "combine" specific, can you move it to alpha.c instead please?

This was the first thing I thought, but the function uses
nonzero_sign_valid, a variable local to combine.c

Uros.


Re: [PATCH]: Restore alpha boostrap by partial revert

2012-04-02 Thread Richard Guenther
On Sat, 31 Mar 2012, Uros Bizjak wrote:

> Hello!
> 
> Attached patch restores alpha bootstrap.
> 
> 2012-03-31  Uros Bizjak  
> 
>   Partially revert:
>   2012-03-29  Richard Guenther  
> 
>   * rtl.h (extended_count): Remove.
>   * combine.c (extended_count): Remove.
> 
> Bootstrapped on alphaev68-pc-linux-gnu.
> 
> OK for mainline?

As alpha is the only user and this does not look in any way
"combine" specific, can you move it to alpha.c instead please?

Thanks,
Richard.