Re: [PATCH][ARM] Fix testism with pure-code tests for non Cortex-M targets

2016-10-20 Thread Kyrill Tkachov


On 20/10/16 10:46, Kyrill Tkachov wrote:

Hi Andre,

On 14/10/16 09:25, Andre Vieira (lists) wrote:

Hi there,

This patch makes sure the pure-code tests only run for Cortex-M targets.
I was hoping '![check_effective_target_arm_arm_ok]' would do the trick
but it seems the options passed with RUNTESTFLAGS take precedence over
the one in the check. Anyhow, I now use 'check_effective_target_cortex_m'.

Is this OK for trunk?
Ran these tests for a ARMv7-A.

Cheers,
Andre


gcc/testsuite/ChangeLog:
2016-10-14  Andre Vieira  

   *  gcc.target/arm/pure-code/pure-code.exp: Adjust targets to test for.

Your ChangeLog entry seems truncated.


Oh, I see what you're saying here.
I think it would be more descriptive to say
"Require arm_cortex_m effective target."

Kyrill



Ok with a proper ChangeLog entry.
Thanks,
Kyrill





Re: [PATCH][ARM] Fix testism with pure-code tests for non Cortex-M targets

2016-10-20 Thread Kyrill Tkachov

Hi Andre,

On 14/10/16 09:25, Andre Vieira (lists) wrote:

Hi there,

This patch makes sure the pure-code tests only run for Cortex-M targets.
I was hoping '![check_effective_target_arm_arm_ok]' would do the trick
but it seems the options passed with RUNTESTFLAGS take precedence over
the one in the check. Anyhow, I now use 'check_effective_target_cortex_m'.

Is this OK for trunk?
Ran these tests for a ARMv7-A.

Cheers,
Andre


gcc/testsuite/ChangeLog:
2016-10-14  Andre Vieira  

   *  gcc.target/arm/pure-code/pure-code.exp: Adjust targets to test for.

Your ChangeLog entry seems truncated.

Ok with a proper ChangeLog entry.
Thanks,
Kyrill