Re: [PATCH] Dump probability for edges a frequency for BBs

2016-12-01 Thread Martin Liška
On 12/01/2016 05:49 PM, Martin Sebor wrote: Okay, thanks for the clarification. One other question though. Why would the probability be near zero? In the absence of any hints the expression 2 != sprintf(d, "%i", 12) should have a very high probability of being true, near 100% in fact. I ask be

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-12-01 Thread Jeff Law
On 12/01/2016 09:49 AM, Martin Sebor wrote: Okay, thanks for the clarification. One other question though. Why would the probability be near zero? In the absence of any hints the expression 2 != sprintf(d, "%i", 12) should have a very high probability of being true, near 100% in fact. I ask be

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-12-01 Thread Martin Sebor
Okay, thanks for the clarification. One other question though. Why would the probability be near zero? In the absence of any hints the expression 2 != sprintf(d, "%i", 12) should have a very high probability of being true, near 100% in fact. I ask because the test I referenced tries to verify t

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-12-01 Thread Martin Sebor
On 12/01/2016 02:48 AM, Martin Liška wrote: On 11/30/2016 11:46 PM, Martin Sebor wrote: On 11/24/2016 05:59 AM, Martin Liška wrote: On 11/24/2016 09:29 AM, Richard Biener wrote: Please guard with ! TDF_GIMPLE, otherwise the output will not be parseable with the GIMPLE FE. RIchard. Done and

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-12-01 Thread Martin Liška
On 11/30/2016 11:46 PM, Martin Sebor wrote: On 11/24/2016 05:59 AM, Martin Liška wrote: On 11/24/2016 09:29 AM, Richard Biener wrote: Please guard with ! TDF_GIMPLE, otherwise the output will not be parseable with the GIMPLE FE. RIchard. Done and verified that and it provides equal dumps for

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-30 Thread Martin Sebor
On 11/24/2016 05:59 AM, Martin Liška wrote: On 11/24/2016 09:29 AM, Richard Biener wrote: Please guard with ! TDF_GIMPLE, otherwise the output will not be parseable with the GIMPLE FE. RIchard. Done and verified that and it provides equal dumps for -fdump*-gimple. Installed as r242837. Hi M

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-24 Thread Martin Liška
On 11/24/2016 09:29 AM, Richard Biener wrote: > Please guard with ! TDF_GIMPLE, otherwise the output will not be parseable > with the GIMPLE FE. > > RIchard. Done and verified that and it provides equal dumps for -fdump*-gimple. Installed as r242837. Thanks for review. Martin >From af3fffab592e5

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-24 Thread Richard Biener
On Thu, Nov 24, 2016 at 10:50 AM, Jan Hubicka wrote: >> > LGTM. While I've often found a way to get this stuff when looking at >> > probability updating code, having it in the standard dumps seems like a >> > good >> > enhancement. >> >> Please guard with ! TDF_GIMPLE, otherwise the output will

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-24 Thread Jan Hubicka
> > LGTM. While I've often found a way to get this stuff when looking at > > probability updating code, having it in the standard dumps seems like a good > > enhancement. > > Please guard with ! TDF_GIMPLE, otherwise the output will not be parseable > with the GIMPLE FE. Since gimple FE builds C

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-24 Thread Richard Biener
On Wed, Nov 23, 2016 at 10:36 PM, Jeff Law wrote: > On 11/11/2016 06:59 AM, Martin Liška wrote: >> >> Hello. >> >> I spent quite time during this stage1 playing with predictors and we found >> with Honza multiple situations where a prediction was oddly calculated. >> Thus, we're suggesting to enha

Re: [PATCH] Dump probability for edges a frequency for BBs

2016-11-23 Thread Jeff Law
On 11/11/2016 06:59 AM, Martin Liška wrote: Hello. I spent quite time during this stage1 playing with predictors and we found with Honza multiple situations where a prediction was oddly calculated. Thus, we're suggesting to enhance default dump format to show BB frequencies and edge probabilitie