Re: [PATCH] Fix PR52571

2012-04-09 Thread Mike Stump
On Mar 14, 2012, at 5:59 AM, Richard Guenther wrote: >> This fixes PR52571, we should not align DECL_COMMON variables as >> they might be pre-empted by a definition with lower alignment. I added this to the PR: Ah, I had another thought. COMDAT and LINKONCE things I don't think can be realigned

Re: [PATCH] Fix PR52571

2012-03-14 Thread Richard Guenther
On Wed, 14 Mar 2012, Richard Guenther wrote: > > This fixes PR52571, we should not align DECL_COMMON variables as > they might be pre-empted by a definition with lower alignment. > > At LTO/WPA level we might recover from missed optimizations by > promoting DECL_COMMON variables to non-common.