Re: [PATCH] Fix PR92324

2019-11-12 Thread Christophe Lyon
On Mon, 11 Nov 2019 at 14:36, Richard Biener wrote: > > On Mon, 11 Nov 2019, Christophe Lyon wrote: > > > On Fri, 8 Nov 2019 at 09:57, Richard Biener wrote: > > > > > > > > > I've been sitting on this for a few days since I'm not 100% happy > > > with how the code looks like. There's possibly st

Re: [PATCH] Fix PR92324

2019-11-11 Thread Richard Biener
On Mon, 11 Nov 2019, Christophe Lyon wrote: > On Fri, 8 Nov 2019 at 09:57, Richard Biener wrote: > > > > > > I've been sitting on this for a few days since I'm not 100% happy > > with how the code looks like. There's possibly still holes in it > > (chains with mixed signed/unsigned adds for exam

Re: [PATCH] Fix PR92324

2019-11-11 Thread Christophe Lyon
On Fri, 8 Nov 2019 at 09:57, Richard Biener wrote: > > > I've been sitting on this for a few days since I'm not 100% happy > with how the code looks like. There's possibly still holes in it > (chains with mixed signed/unsigned adds for example might pick > up signed adds in the epilogue), but the

Re: [PATCH] Fix PR92324

2019-11-08 Thread Richard Sandiford
Richard Biener writes: > On Fri, 8 Nov 2019, Richard Sandiford wrote: > >> Richard Biener writes: >> > I've been sitting on this for a few days since I'm not 100% happy >> > with how the code looks like. There's possibly still holes in it >> > (chains with mixed signed/unsigned adds for example

Re: [PATCH] Fix PR92324

2019-11-08 Thread Richard Biener
On Fri, 8 Nov 2019, Richard Sandiford wrote: > Richard Biener writes: > > I've been sitting on this for a few days since I'm not 100% happy > > with how the code looks like. There's possibly still holes in it > > (chains with mixed signed/unsigned adds for example might pick > > up signed adds i

Re: [PATCH] Fix PR92324

2019-11-08 Thread Richard Sandiford
Richard Biener writes: > I've been sitting on this for a few days since I'm not 100% happy > with how the code looks like. There's possibly still holes in it > (chains with mixed signed/unsigned adds for example might pick > up signed adds in the epilogue), but the wrong-code cases should > work