Re: [PATCH] Remove x86 pcommit instruction
Hi Andrew, On Mon, 27 Feb 2017, Andrew Senkevich wrote: >> +Support for the > + >> href="https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated >> +pcommit instruction has been removed. > Could you please add the same statement for gcc-7 changes? this never was part of a GCC 7-based release, and on top of that we explicitly noted it's removal for both GCC 5 and GCC 6, so I don't think this is necessary. In fact, it would be even confusing? Gerald
Re: [PATCH] Remove x86 pcommit instruction
2017-02-25 18:10 GMT+01:00 Gerald Pfeifer : > On Wed, 7 Dec 2016, Andrew Senkevich wrote: But how to update changes for upcoming GCC 6.3 (and future GCC 5.5)? >>> There are corresponding documents at [1] and [2], please add a "GCC >>> 6.3" or "GCC 5.5" entry with "Target Specific Changes" at the end of >>> the documents. >>> >>> [1] https://gcc.gnu.org/gcc-6/changes.html >>> [2] https://gcc.gnu.org/gcc-5/changes.html >> Attached patches, who will apply them? > > I noticed nobody so far, so I took this. The patch for GCC 6 > required some tweaking (and you can't use the some id for two > different headings). > > Below is what I just applied. > > Gerald > > Index: gcc-6/changes.html > === > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v > retrieving revision 1.93 > diff -u -r1.93 changes.html > --- gcc-6/changes.html 18 Feb 2017 22:15:41 - 1.93 > +++ gcc-6/changes.html 25 Feb 2017 17:06:27 - > @@ -879,5 +879,15 @@ > complete (that is, it is possible that some PRs that have been fixed > are not listed here). > > +Target Specific Changes > + > +IA-32/x86-64 > + > +Support for the + > href="https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated > +pcommit instruction has been removed. > + > + > + > > Thanks Gerald! Could you please add the same statement for gcc-7 changes? -- WBR, Andrew
Re: [PATCH] Remove x86 pcommit instruction
On Sat, 25 Feb 2017, Gerald Pfeifer wrote: > And here is what I applied for GCC 5. Except that I fixed some things, but failed to remove the duplicate id. Applied as a follow-up. Gerald Index: gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.144 diff -u -r1.144 changes.html --- gcc-5/changes.html 25 Feb 2017 20:52:55 - 1.144 +++ gcc-5/changes.html 25 Feb 2017 21:14:09 - @@ -1079,7 +1079,7 @@ Target Specific Changes -IA-32/x86-64 +IA-32/x86-64 Support for the https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated
Re: [PATCH] Remove x86 pcommit instruction
On Sat, 25 Feb 2017, Gerald Pfeifer wrote: > Below is what I just applied. And here is what I applied for GCC 5. Gerald Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.143 diff -u -r1.143 changes.html --- changes.html6 Feb 2017 17:43:33 - 1.143 +++ changes.html25 Feb 2017 20:47:27 - @@ -982,7 +982,8 @@ whenever an internal compiler error is encountered. -GCC 5.2 + +GCC 5.2 This is the https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.2";>list of problem reports (PRs) from GCC's bug tracking system that are @@ -1035,7 +1036,7 @@ header file needs to be included. -GCC 5.3 +GCC 5.3 This is the https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.3";>list of problem reports (PRs) from GCC's bug tracking system that are @@ -1060,7 +1061,7 @@ compile larger GO applications on IBM z Systems. -GCC 5.4 +GCC 5.4 This is the https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.4";>list of problem reports (PRs) from GCC's bug tracking system that are @@ -1068,7 +1069,7 @@ complete (that is, it is possible that some PRs that have been fixed are not listed here). -(Pending) GCC 5.5 +(Pending) GCC 5.5 This is the https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=5.5";>list of problem reports (PRs) from GCC's bug tracking system that are @@ -1076,5 +1077,14 @@ complete (that is, it is possible that some PRs that have been fixed are not listed here). +Target Specific Changes + +IA-32/x86-64 + +Support for the https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated +pcommit instruction has been removed. + +
Re: [PATCH] Remove x86 pcommit instruction
On Wed, 7 Dec 2016, Andrew Senkevich wrote: >>> But how to update changes for upcoming GCC 6.3 (and future GCC 5.5)? >> There are corresponding documents at [1] and [2], please add a "GCC >> 6.3" or "GCC 5.5" entry with "Target Specific Changes" at the end of >> the documents. >> >> [1] https://gcc.gnu.org/gcc-6/changes.html >> [2] https://gcc.gnu.org/gcc-5/changes.html > Attached patches, who will apply them? I noticed nobody so far, so I took this. The patch for GCC 6 required some tweaking (and you can't use the some id for two different headings). Below is what I just applied. Gerald Index: gcc-6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.93 diff -u -r1.93 changes.html --- gcc-6/changes.html 18 Feb 2017 22:15:41 - 1.93 +++ gcc-6/changes.html 25 Feb 2017 17:06:27 - @@ -879,5 +879,15 @@ complete (that is, it is possible that some PRs that have been fixed are not listed here). +Target Specific Changes + +IA-32/x86-64 + +Support for the https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated +pcommit instruction has been removed. + + +
Re: [PATCH] Remove x86 pcommit instruction
2016-12-07 15:34 GMT+03:00 Uros Bizjak : > On Wed, Dec 7, 2016 at 1:25 PM, Andrew Senkevich > wrote: > >> But how to update changes for upcoming GCC 6.3 (and future GCC 5.5)? > > There are corresponding documents at [1] and [2], please add a "GCC > 6.3" or "GCC 5.5" entry with "Target Specific Changes" at the end of > the documents. > > [1] https://gcc.gnu.org/gcc-6/changes.html > [2] https://gcc.gnu.org/gcc-5/changes.html Attached patches, who will apply them? -- WBR, Andrew gcc5.5_changes.patch Description: Binary data gcc6.3_changes.patch Description: Binary data
Re: [PATCH] Remove x86 pcommit instruction
On Wed, Dec 7, 2016 at 1:25 PM, Andrew Senkevich wrote: > But how to update changes for upcoming GCC 6.3 (and future GCC 5.5)? There are corresponding documents at [1] and [2], please add a "GCC 6.3" or "GCC 5.5" entry with "Target Specific Changes" at the end of the documents. [1] https://gcc.gnu.org/gcc-6/changes.html [2] https://gcc.gnu.org/gcc-5/changes.html Uros.
Re: [PATCH] Remove x86 pcommit instruction
2016-10-14 12:23 GMT+03:00 Richard Biener : > On Thu, Oct 13, 2016 at 11:39 PM, H.J. Lu wrote: >> On Thu, Oct 13, 2016 at 5:09 AM, Andrew Senkevich >> wrote: >>> 2016-10-11 20:09 GMT+03:00 H.J. Lu : On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich wrote: > 2016-10-06 1:07 GMT+03:00 H.J. Lu : >> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >> wrote: >>> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich wrote: >> -mpcommit >> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >> -Support PCOMMIT instruction. >> - >> >> You should not simply delete a option that was in the released >> compiler, but a warning should be emitted instead. Please see how >> msse5 is handled in i386.opt. > > Thank you, it is fixed in patch below. Ok for trunk? OK. > Is it subject for backport for 5.* and 6.* releases? Yes, but please wait a couple of days if any problem arises in trunk. (Please also provide an entry for Release Changes, since this is user-facing change. Also for release branches.) >>> >>> Hi HJ, >>> >>> could you please commit this patch for trunk since I have no commit >>> rights. >>> Attached in format for git am. >>> >>> >> >> Done. > > Thanks, HJ! > > Should I ask you or somebody else for backports for to 5.* and 6.* or > may be I can somehow get commit after approval rights to don't disturb > others with commits? I am preparing several patches. > Please provide patches for GCC 5 and 6. >>> >>> Attached. >> >> I checked them into GCC 5 and GCC 6 branches. >> >>> Have you possibility to update according changes.html files? >>> >> >> Here is the patch for GCC 7. I am not sure what to do with GCC >> 5 and 6. > > There are entries for each sub-release (if not for the next then add one). > > Richard. > >> -- >> H.J. >> --- >> Index: gcc-7/changes.html >> === >> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v >> retrieving revision 1.18 >> diff -u -p -r1.18 changes.html >> --- gcc-7/changes.html 12 Oct 2016 11:08:25 - 1.18 >> +++ gcc-7/changes.html 13 Oct 2016 21:37:18 - >> @@ -318,7 +318,14 @@ const int* get_address (unsigned idx) >> >> >> >> - >> +IA-32/x86-64 >> + >> + >> + Support for >> + > href="https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated >> + pcommit instruction has been removed. >> + >> + >> >> But how to update changes for upcoming GCC 6.3 (and future GCC 5.5)? -- WBR, Andrew
Re: [PATCH] Remove x86 pcommit instruction
> That said - why do we need to remove pcommit support on the branches at all? I think it is better to have old branches updated because pcommit will not be implemented in hardware. -- WBR, Andrew
Re: [PATCH] Remove x86 pcommit instruction
On Fri, Oct 14, 2016 at 11:23 AM, Richard Biener wrote: > On Thu, Oct 13, 2016 at 11:39 PM, H.J. Lu wrote: >> On Thu, Oct 13, 2016 at 5:09 AM, Andrew Senkevich >> wrote: >>> 2016-10-11 20:09 GMT+03:00 H.J. Lu : On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich wrote: > 2016-10-06 1:07 GMT+03:00 H.J. Lu : >> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >> wrote: >>> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich wrote: >> -mpcommit >> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >> -Support PCOMMIT instruction. >> - >> >> You should not simply delete a option that was in the released >> compiler, but a warning should be emitted instead. Please see how >> msse5 is handled in i386.opt. > > Thank you, it is fixed in patch below. Ok for trunk? OK. > Is it subject for backport for 5.* and 6.* releases? Yes, but please wait a couple of days if any problem arises in trunk. (Please also provide an entry for Release Changes, since this is user-facing change. Also for release branches.) >>> >>> Hi HJ, >>> >>> could you please commit this patch for trunk since I have no commit >>> rights. >>> Attached in format for git am. >>> >>> >> >> Done. > > Thanks, HJ! > > Should I ask you or somebody else for backports for to 5.* and 6.* or > may be I can somehow get commit after approval rights to don't disturb > others with commits? I am preparing several patches. > Please provide patches for GCC 5 and 6. >>> >>> Attached. >> >> I checked them into GCC 5 and GCC 6 branches. >> >>> Have you possibility to update according changes.html files? >>> >> >> Here is the patch for GCC 7. I am not sure what to do with GCC >> 5 and 6. > > There are entries for each sub-release (if not for the next then add one). That said - why do we need to remove pcommit support on the branches at all? Richard. > Richard. > >> -- >> H.J. >> --- >> Index: gcc-7/changes.html >> === >> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v >> retrieving revision 1.18 >> diff -u -p -r1.18 changes.html >> --- gcc-7/changes.html 12 Oct 2016 11:08:25 - 1.18 >> +++ gcc-7/changes.html 13 Oct 2016 21:37:18 - >> @@ -318,7 +318,14 @@ const int* get_address (unsigned idx) >> >> >> >> - >> +IA-32/x86-64 >> + >> + >> + Support for >> + > href="https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated >> + pcommit instruction has been removed. >> + >> + >> >>
Re: [PATCH] Remove x86 pcommit instruction
On Thu, Oct 13, 2016 at 11:39 PM, H.J. Lu wrote: > On Thu, Oct 13, 2016 at 5:09 AM, Andrew Senkevich > wrote: >> 2016-10-11 20:09 GMT+03:00 H.J. Lu : >>> On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich >>> wrote: 2016-10-06 1:07 GMT+03:00 H.J. Lu : > On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich > wrote: >> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >>> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >>> wrote: > -mpcommit > -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save > -Support PCOMMIT instruction. > - > > You should not simply delete a option that was in the released > compiler, but a warning should be emitted instead. Please see how > msse5 is handled in i386.opt. Thank you, it is fixed in patch below. Ok for trunk? >>> >>> OK. >>> Is it subject for backport for 5.* and 6.* releases? >>> >>> Yes, but please wait a couple of days if any problem arises in trunk. >>> >>> (Please also provide an entry for Release Changes, since this is >>> user-facing change. Also for release branches.) >> >> Hi HJ, >> >> could you please commit this patch for trunk since I have no commit >> rights. >> Attached in format for git am. >> >> > > Done. Thanks, HJ! Should I ask you or somebody else for backports for to 5.* and 6.* or may be I can somehow get commit after approval rights to don't disturb others with commits? I am preparing several patches. >>> >>> Please provide patches for GCC 5 and 6. >> >> Attached. > > I checked them into GCC 5 and GCC 6 branches. > >> Have you possibility to update according changes.html files? >> > > Here is the patch for GCC 7. I am not sure what to do with GCC > 5 and 6. There are entries for each sub-release (if not for the next then add one). Richard. > -- > H.J. > --- > Index: gcc-7/changes.html > === > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v > retrieving revision 1.18 > diff -u -p -r1.18 changes.html > --- gcc-7/changes.html 12 Oct 2016 11:08:25 - 1.18 > +++ gcc-7/changes.html 13 Oct 2016 21:37:18 - > @@ -318,7 +318,14 @@ const int* get_address (unsigned idx) > > > > - > +IA-32/x86-64 > + > + > + Support for > +href="https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated > + pcommit instruction has been removed. > + > + > >
Re: [PATCH] Remove x86 pcommit instruction
On Thu, Oct 13, 2016 at 5:09 AM, Andrew Senkevich wrote: > 2016-10-11 20:09 GMT+03:00 H.J. Lu : >> On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich >> wrote: >>> 2016-10-06 1:07 GMT+03:00 H.J. Lu : On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich wrote: > 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >> wrote: -mpcommit -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save -Support PCOMMIT instruction. - You should not simply delete a option that was in the released compiler, but a warning should be emitted instead. Please see how msse5 is handled in i386.opt. >>> >>> Thank you, it is fixed in patch below. Ok for trunk? >> >> OK. >> >>> Is it subject for backport for 5.* and 6.* releases? >> >> Yes, but please wait a couple of days if any problem arises in trunk. >> >> (Please also provide an entry for Release Changes, since this is >> user-facing change. Also for release branches.) > > Hi HJ, > > could you please commit this patch for trunk since I have no commit > rights. > Attached in format for git am. > > Done. >>> >>> Thanks, HJ! >>> >>> Should I ask you or somebody else for backports for to 5.* and 6.* or >>> may be I can somehow get commit after approval rights to don't disturb >>> others with commits? I am preparing several patches. >>> >> >> Please provide patches for GCC 5 and 6. > > Attached. I checked them into GCC 5 and GCC 6 branches. > Have you possibility to update according changes.html files? > Here is the patch for GCC 7. I am not sure what to do with GCC 5 and 6. -- H.J. --- Index: gcc-7/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v retrieving revision 1.18 diff -u -p -r1.18 changes.html --- gcc-7/changes.html 12 Oct 2016 11:08:25 - 1.18 +++ gcc-7/changes.html 13 Oct 2016 21:37:18 - @@ -318,7 +318,14 @@ const int* get_address (unsigned idx) - +IA-32/x86-64 + + + Support for + https://software.intel.com/en-us/blogs/2016/09/12/deprecate-pcommit-instruction";>deprecated + pcommit instruction has been removed. + +
Re: [PATCH] Remove x86 pcommit instruction
2016-10-11 20:09 GMT+03:00 H.J. Lu : > On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich > wrote: >> 2016-10-06 1:07 GMT+03:00 H.J. Lu : >>> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >>> wrote: 2016-10-05 18:06 GMT+03:00 Uros Bizjak : > On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich > wrote: >>> -mpcommit >>> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >>> -Support PCOMMIT instruction. >>> - >>> >>> You should not simply delete a option that was in the released >>> compiler, but a warning should be emitted instead. Please see how >>> msse5 is handled in i386.opt. >> >> Thank you, it is fixed in patch below. Ok for trunk? > > OK. > >> Is it subject for backport for 5.* and 6.* releases? > > Yes, but please wait a couple of days if any problem arises in trunk. > > (Please also provide an entry for Release Changes, since this is > user-facing change. Also for release branches.) Hi HJ, could you please commit this patch for trunk since I have no commit rights. Attached in format for git am. >>> >>> Done. >> >> Thanks, HJ! >> >> Should I ask you or somebody else for backports for to 5.* and 6.* or >> may be I can somehow get commit after approval rights to don't disturb >> others with commits? I am preparing several patches. >> > > Please provide patches for GCC 5 and 6. Attached. Have you possibility to update according changes.html files? -- WBR, Andrew remove_pcommit_gcc-5-branch.patch Description: Binary data remove_pcommit_gcc-6-branch.patch Description: Binary data
Re: [PATCH] Remove x86 pcommit instruction
On Tue, Oct 11, 2016 at 10:04 AM, Andrew Senkevich wrote: > 2016-10-06 1:07 GMT+03:00 H.J. Lu : >> On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich >> wrote: >>> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich wrote: >> -mpcommit >> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >> -Support PCOMMIT instruction. >> - >> >> You should not simply delete a option that was in the released >> compiler, but a warning should be emitted instead. Please see how >> msse5 is handled in i386.opt. > > Thank you, it is fixed in patch below. Ok for trunk? OK. > Is it subject for backport for 5.* and 6.* releases? Yes, but please wait a couple of days if any problem arises in trunk. (Please also provide an entry for Release Changes, since this is user-facing change. Also for release branches.) >>> >>> Hi HJ, >>> >>> could you please commit this patch for trunk since I have no commit rights. >>> Attached in format for git am. >>> >>> >> >> Done. > > Thanks, HJ! > > Should I ask you or somebody else for backports for to 5.* and 6.* or > may be I can somehow get commit after approval rights to don't disturb > others with commits? I am preparing several patches. > Please provide patches for GCC 5 and 6. -- H.J.
Re: [PATCH] Remove x86 pcommit instruction
2016-10-06 1:07 GMT+03:00 H.J. Lu : > On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich > wrote: >> 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >>> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >>> wrote: > -mpcommit > -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save > -Support PCOMMIT instruction. > - > > You should not simply delete a option that was in the released > compiler, but a warning should be emitted instead. Please see how > msse5 is handled in i386.opt. Thank you, it is fixed in patch below. Ok for trunk? >>> >>> OK. >>> Is it subject for backport for 5.* and 6.* releases? >>> >>> Yes, but please wait a couple of days if any problem arises in trunk. >>> >>> (Please also provide an entry for Release Changes, since this is >>> user-facing change. Also for release branches.) >> >> Hi HJ, >> >> could you please commit this patch for trunk since I have no commit rights. >> Attached in format for git am. >> >> > > Done. Thanks, HJ! Should I ask you or somebody else for backports for to 5.* and 6.* or may be I can somehow get commit after approval rights to don't disturb others with commits? I am preparing several patches. -- WBR, Andrew
Re: [PATCH] Remove x86 pcommit instruction
On Wed, Oct 5, 2016 at 1:42 PM, Andrew Senkevich wrote: > 2016-10-05 18:06 GMT+03:00 Uros Bizjak : >> On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich >> wrote: -mpcommit -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save -Support PCOMMIT instruction. - You should not simply delete a option that was in the released compiler, but a warning should be emitted instead. Please see how msse5 is handled in i386.opt. >>> >>> Thank you, it is fixed in patch below. Ok for trunk? >> >> OK. >> >>> Is it subject for backport for 5.* and 6.* releases? >> >> Yes, but please wait a couple of days if any problem arises in trunk. >> >> (Please also provide an entry for Release Changes, since this is >> user-facing change. Also for release branches.) > > Hi HJ, > > could you please commit this patch for trunk since I have no commit rights. > Attached in format for git am. > > Done. -- H.J.
Re: [PATCH] Remove x86 pcommit instruction
2016-10-05 18:06 GMT+03:00 Uros Bizjak : > On Wed, Oct 5, 2016 at 3:47 PM, Andrew Senkevich > wrote: >>> -mpcommit >>> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save >>> -Support PCOMMIT instruction. >>> - >>> >>> You should not simply delete a option that was in the released >>> compiler, but a warning should be emitted instead. Please see how >>> msse5 is handled in i386.opt. >> >> Thank you, it is fixed in patch below. Ok for trunk? > > OK. > >> Is it subject for backport for 5.* and 6.* releases? > > Yes, but please wait a couple of days if any problem arises in trunk. > > (Please also provide an entry for Release Changes, since this is > user-facing change. Also for release branches.) Hi HJ, could you please commit this patch for trunk since I have no commit rights. Attached in format for git am. -- WBR, Andrew 0001-Deleted-x86-pcommit-instruction-since-it-is-deprecat.patch Description: Binary data
Re: [PATCH] Remove x86 pcommit instruction
On Wed, Oct 5, 2016 at 9:03 PM, Andrew Senkevich wrote: >> (Please also provide an entry for Release Changes, since this is >> user-facing change. Also for release branches.) > > What is BKM for doing that for 7.1 release? File a PR and mention it > in ChangeLog? No, just mention the change at [1] for trunk and [2], [3] for release branches. [1] https://gcc.gnu.org/gcc-7/changes.html [2] https://gcc.gnu.org/gcc-6/changes.html [3] https://gcc.gnu.org/gcc-5/changes.html Uros.
Re: [PATCH] Remove x86 pcommit instruction
> (Please also provide an entry for Release Changes, since this is > user-facing change. Also for release branches.) What is BKM for doing that for 7.1 release? File a PR and mention it in ChangeLog? -- WBR, Andrew
Re: [PATCH] Remove x86 pcommit instruction
> -mpcommit
> -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save
> -Support PCOMMIT instruction.
> -
>
> You should not simply delete a option that was in the released
> compiler, but a warning should be emitted instead. Please see how
> msse5 is handled in i386.opt.
Thank you, it is fixed in patch below. Ok for trunk?
Is it subject for backport for 5.* and 6.* releases?
2016-10-05 Andrew Senkevich
gcc/
* common/config/i386/i386-common.c (OPTION_MASK_ISA_PCOMMIT_UNSET,
OPTION_MASK_ISA_PCOMMIT_SET): Deleted definitions.
(ix86_handle_option): Deleted handle of OPT_mpcommit.
* config.gcc: Deleted pcommitintrin.h
* config/i386/pcommitintrin.h: Deleted file.
* config/i386/cpuid.h (bit_PCOMMIT): Deleted.
* config/i386/driver-i386.c (host_detect_local_cpu): Deleted pcommit
detection.
* config/i386/i386-c.c (ix86_target_macros_internal): Deleted define
__PCOMMIT__.
* config/i386/i386.c (ix86_target_string): Deleted -mpcommit.
(PTA_PCOMMIT): Deleted define.
(ix86_option_override_internal): Deleted handle of option.
(ix86_valid_target_attribute_inner_p): Deleted pcommit.
* config/i386/i386-builtin.def (IX86_BUILTIN_PCOMMIT,
__builtin_ia32_pcommit): Deleted.
* config/i386/i386.h (TARGET_PCOMMIT, TARGET_PCOMMIT_P): Deleted.
* config/i386/i386.md (unspecv): Deleted UNSPECV_PCOMMIT.
(pcommit): Deleted instruction.
* config/i386/i386.opt: Warning about mpcommit deprecation.
* config/i386/x86intrin.h: Deleted inclusion of pcommitintrin.h.
gcc/testsuite/
* gcc.target/i386/pcommit-1.c: Deleted.
* gcc.target/i386/sse-12.c: Deleted -mpcommit option.
* gcc.target/i386/sse-13.c: Ditto.
* gcc.target/i386/sse-14.c: Ditto.
* gcc.target/i386/sse-22.c: Ditto.
* gcc.target/i386/sse-23.c: Ditto.
* g++.dg/other/i386-2.C: Ditto.
* g++.dg/other/i386-3.C: Ditto.
diff --git a/gcc/common/config/i386/i386-common.c
b/gcc/common/config/i386/i386-common.c
index 4f0a55f..ce1b5f7 100644
--- a/gcc/common/config/i386/i386-common.c
+++ b/gcc/common/config/i386/i386-common.c
@@ -86,7 +86,6 @@ along with GCC; see the file COPYING3. If not see
#define OPTION_MASK_ISA_XSAVEC_SET \
(OPTION_MASK_ISA_XSAVEC | OPTION_MASK_ISA_XSAVE)
#define OPTION_MASK_ISA_CLWB_SET OPTION_MASK_ISA_CLWB
-#define OPTION_MASK_ISA_PCOMMIT_SET OPTION_MASK_ISA_PCOMMIT
/* SSE4 includes both SSE4.1 and SSE4.2. -msse4 should be the same
as -msse4.2. */
@@ -187,7 +186,6 @@ along with GCC; see the file COPYING3. If not see
#define OPTION_MASK_ISA_CLFLUSHOPT_UNSET OPTION_MASK_ISA_CLFLUSHOPT
#define OPTION_MASK_ISA_XSAVEC_UNSET OPTION_MASK_ISA_XSAVEC
#define OPTION_MASK_ISA_XSAVES_UNSET OPTION_MASK_ISA_XSAVES
-#define OPTION_MASK_ISA_PCOMMIT_UNSET OPTION_MASK_ISA_PCOMMIT
#define OPTION_MASK_ISA_CLWB_UNSET OPTION_MASK_ISA_CLWB
#define OPTION_MASK_ISA_MWAITX_UNSET OPTION_MASK_ISA_MWAITX
#define OPTION_MASK_ISA_CLZERO_UNSET OPTION_MASK_ISA_CLZERO
@@ -933,19 +931,6 @@ ix86_handle_option (struct gcc_options *opts,
}
return true;
-case OPT_mpcommit:
- if (value)
- {
- opts->x_ix86_isa_flags |= OPTION_MASK_ISA_PCOMMIT_SET;
- opts->x_ix86_isa_flags_explicit |= OPTION_MASK_ISA_PCOMMIT_SET;
- }
- else
- {
- opts->x_ix86_isa_flags &= ~OPTION_MASK_ISA_PCOMMIT_UNSET;
- opts->x_ix86_isa_flags_explicit |= OPTION_MASK_ISA_PCOMMIT_UNSET;
- }
- return true;
-
case OPT_mclwb:
if (value)
{
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 7d24561..8fd07c5 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -373,8 +373,8 @@ i[34567]86-*-*)
xsavesintrin.h avx512dqintrin.h avx512bwintrin.h
avx512vlintrin.h avx512vlbwintrin.h avx512vldqintrin.h
avx512ifmaintrin.h avx512ifmavlintrin.h
avx512vbmiintrin.h
- avx512vbmivlintrin.h clwbintrin.h pcommitintrin.h
- mwaitxintrin.h clzerointrin.h pkuintrin.h"
+ avx512vbmivlintrin.h clwbintrin.h mwaitxintrin.h
+ clzerointrin.h pkuintrin.h"
;;
x86_64-*-*)
cpu_type=i386
@@ -395,8 +395,8 @@ x86_64-*-*)
xsavesintrin.h avx512dqintrin.h avx512bwintrin.h
avx512vlintrin.h avx512vlbwintrin.h avx512vldqintrin.h
avx512ifmaintrin.h avx512ifmavlintrin.h
avx512vbmiintrin.h
- avx512vbmivlintrin.h clwbintrin.h pcommitintrin.h
- mwaitxintrin.h clzerointrin.h pkuintrin.h"
+ avx512vbmivlintrin.h clwbintrin.h mwaitxintrin.h
+ clzerointrin.h pkuintrin.h"
;;
ia64-*-*)
extra_headers=ia64intrin.h
diff --git a/gcc/config/i386/cpuid.h b/gcc/config/i386/cpuid.h
index 4ea3f74..2a946
Re: [PATCH] Remove x86 pcommit instruction
Hello! > 2016-10-03 Andrew Senkevich > >gcc/ > >* common/config/i386/i386-common.c (OPTION_MASK_ISA_PCOMMIT_UNSET, >OPTION_MASK_ISA_PCOMMIT_SET): Deleted definitions. >(ix86_handle_option): Deleted handle of OPT_mpcommit. >* config.gcc: Deleted pcommitintrin.h >* config/i386/pcommitintrin.h: Deleted file. >* config/i386/cpuid.h (bit_PCOMMIT): Deleted. >* config/i386/driver-i386.c (host_detect_local_cpu): Deleted pcommit >detection. >* config/i386/i386-c.c (ix86_target_macros_internal): Deleted define >__PCOMMIT__. >* config/i386/i386.c (ix86_target_string): Deleted -mpcommit. >(PTA_PCOMMIT): Deleted define. >(ix86_option_override_internal): Deleted handle of option. >(ix86_valid_target_attribute_inner_p): Deleted pcommit. >* config/i386/i386-builtin.def (IX86_BUILTIN_PCOMMIT, >__builtin_ia32_pcommit): Deleted. >* config/i386/i386.h (TARGET_PCOMMIT, TARGET_PCOMMIT_P): Deleted. >* config/i386/i386.md (unspecv): Deleted UNSPECV_PCOMMIT. >(pcommit): Deleted instruction. >* config/i386/i386.opt: Deleted mpcommit. >* config/i386/x86intrin.h: Deleted inclusion of pcommitintrin.h. > >gcc/testsuite/ > >* gcc.target/i386/pcommit-1.c: Deleted. >* gcc.target/i386/sse-12.c: Deleted -mpcommit option. >* gcc.target/i386/sse-13.c: Ditto. >* gcc.target/i386/sse-14.c: Ditto. >* gcc.target/i386/sse-22.c: Ditto. >* gcc.target/i386/sse-23.c: Ditto. >* g++.dg/other/i386-2.C: Ditto. >* g++.dg/other/i386-3.C: Ditto. -mpcommit -Target Report Mask(ISA_PCOMMIT) Var(ix86_isa_flags) Save -Support PCOMMIT instruction. - You should not simply delete a option that was in the released compiler, but a warning should be emitted instead. Please see how msse5 is handled in i386.opt. Uros.
