Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-04-15 Thread Martin Liška
On 4/15/19 9:27 AM, Richard Biener wrote: > On Mon, Apr 15, 2019 at 8:48 AM Martin Liška wrote: >> >> Hi. >> >> Apparently, there's one another PR: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90083 >> >> May I backport the patch to GCC-8 branch? > > Hmm, it isn't a regression, right? But it

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-04-15 Thread Richard Biener
On Mon, Apr 15, 2019 at 8:48 AM Martin Liška wrote: > > Hi. > > Apparently, there's one another PR: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90083 > > May I backport the patch to GCC-8 branch? Hmm, it isn't a regression, right? But it only affects multi-versioning, so yes, go ahead. Might

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-04-15 Thread Martin Liška
Hi. Apparently, there's one another PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90083 May I backport the patch to GCC-8 branch? Thanks, Martin

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-18 Thread H.J. Lu
On Fri, Jan 18, 2019 at 6:25 AM H.J. Lu wrote: > > On Thu, Jan 17, 2019 at 4:51 AM Richard Biener > wrote: > > > > On Thu, Jan 17, 2019 at 12:21 PM Martin Liška wrote: > > > > > > On 1/16/19 1:06 PM, Richard Biener wrote: > > > > On Wed, Jan 16, 2019 at 10:20 AM Martin Liška wrote: > > > >> >

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-18 Thread H.J. Lu
On Thu, Jan 17, 2019 at 4:51 AM Richard Biener wrote: > > On Thu, Jan 17, 2019 at 12:21 PM Martin Liška wrote: > > > > On 1/16/19 1:06 PM, Richard Biener wrote: > > > On Wed, Jan 16, 2019 at 10:20 AM Martin Liška wrote: > > >> > > >> Hi. > > >> > > >> The patch is about resetting TYPE_MODE of

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-17 Thread Richard Biener
On Thu, Jan 17, 2019 at 12:21 PM Martin Liška wrote: > > On 1/16/19 1:06 PM, Richard Biener wrote: > > On Wed, Jan 16, 2019 at 10:20 AM Martin Liška wrote: > >> > >> Hi. > >> > >> The patch is about resetting TYPE_MODE of vector types. This is problematic > >> when an inlining among different

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-17 Thread Martin Liška
On 1/16/19 1:06 PM, Richard Biener wrote: > On Wed, Jan 16, 2019 at 10:20 AM Martin Liška wrote: >> >> Hi. >> >> The patch is about resetting TYPE_MODE of vector types. This is problematic >> when an inlining among different ISAs happen. Then we end up with a different >> mode than when it's

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-16 Thread Richard Biener
On Wed, Jan 16, 2019 at 10:20 AM Martin Liška wrote: > > Hi. > > The patch is about resetting TYPE_MODE of vector types. This is problematic > when an inlining among different ISAs happen. Then we end up with a different > mode than when it's expected from debug info. > > When creating a new

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-16 Thread Richard Biener
On Wed, Jan 16, 2019 at 12:59 PM Jakub Jelinek wrote: > > On Wed, Jan 16, 2019 at 12:50:23PM +0100, Richard Biener wrote: > > I guess so. There's not much we can do about this other than making > > DECL_MODE dynamic the same way as TYPE_MODE. I still believe > > this is the wrong direction and

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-16 Thread Jakub Jelinek
On Wed, Jan 16, 2019 at 12:50:23PM +0100, Richard Biener wrote: > I guess so. There's not much we can do about this other than making > DECL_MODE dynamic the same way as TYPE_MODE. I still believe > this is the wrong direction and instead RTL expansion should properly > adjust DECL_RTL and

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-16 Thread Richard Biener
On Wed, Jan 16, 2019 at 10:26 AM Martin Liška wrote: > > And there's patch with Richi's validation check that he provided. > It fails on following 2 tests in test-suite: > > $ ./xgcc -B. > /home/marxin/Programming/gcc/gcc/testsuite/gcc.target/i386/pr68674.c > DECL_MODE BLK vs TYPE_MODE V8SI

Re: [PATCH] Reset proper type on vector types (PR middle-end/88587).

2019-01-16 Thread Martin Liška
And there's patch with Richi's validation check that he provided. It fails on following 2 tests in test-suite: $ ./xgcc -B. /home/marxin/Programming/gcc/gcc/testsuite/gcc.target/i386/pr68674.c DECL_MODE BLK vs TYPE_MODE V8SI [V8SI]: a ... $ ./xgcc -B.