Re: [PATCH 0/3] wwwdocs: Updates for gcc 8 changes

2018-03-18 Thread David Malcolm
On Mon, 2018-03-19 at 00:02 +0100, Gerald Pfeifer wrote:
> Hi David,
> 
> On Fri, 16 Mar 2018, David Malcolm wrote:
> > This patch kit is for the website; I generated it against a local
> > git mirror of the CVS repo.
> > 
> > It adds lots of examples of colorized output from GCC, which
> > I generated using ansi2html.sh, an LGPLv2 script for turning ANSI
> > color codes into HTML spans.  It also emits a .css file for mapping
> > the span classes into HTML colorization.
> 
> do we really need to import ansi2html.sh here?  It's only supposed
> to be used once, to generate the CSS file, I think, or do you expect
> to be further use?

I used it to generate the content for changes.html, and I expect to use
it in the future when generating similar patches.

> As for the CSS, have you considered using more meaningful class names
> instead of those color codes (most of which aren't actually used in
> your patch to the website)?  I guess I'm really wondering about two
> things:
> 
>  (a) Can we only introduce those styles we actually use?, and
> 
>  (b) The question on class names.
> 
> (I can see that you possibly may want to keep the names as is, but
> in that case, could we prune and only keep what we use?)

I guess; I just found it easier to simply copy the latest version of 
ansi2html.sh and to use it as-is.

Dave


Re: [PATCH 0/3] wwwdocs: Updates for gcc 8 changes

2018-03-18 Thread Gerald Pfeifer
Hi David,

On Fri, 16 Mar 2018, David Malcolm wrote:
> This patch kit is for the website; I generated it against a local
> git mirror of the CVS repo.
> 
> It adds lots of examples of colorized output from GCC, which
> I generated using ansi2html.sh, an LGPLv2 script for turning ANSI
> color codes into HTML spans.  It also emits a .css file for mapping
> the span classes into HTML colorization.

do we really need to import ansi2html.sh here?  It's only supposed
to be used once, to generate the CSS file, I think, or do you expect
to be further use?

As for the CSS, have you considered using more meaningful class names
instead of those color codes (most of which aren't actually used in
your patch to the website)?  I guess I'm really wondering about two
things:

 (a) Can we only introduce those styles we actually use?, and

 (b) The question on class names.

(I can see that you possibly may want to keep the names as is, but
in that case, could we prune and only keep what we use?)

Gerald