Re: [PATCH 08/17] testsuite: arm: Use effective-target for vect-early-break-cbranch test

[Torbjorn SVENSSON]

On 2024-11-19 17:41, Richard Earnshaw (lists) wrote:

On 19/11/2024 10:23, Torbjörn SVENSSON wrote:

Update test cases to use -mcpu=unset/-march=unset feature introduced in
r15-3606-g7d6c6a0d15c.

gcc/testsuite/ChangeLog:

* gcc.target/arm/vect-early-break-cbranch.c: Use
effective-target arm_arch_v8a_hard.

Signed-off-by: Torbjörn SVENSSON 
---
  gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c 
b/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
index 334e064a239..fb12bfb3197 100644
--- a/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
+++ b/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
@@ -2,7 +2,9 @@
  /* { dg-require-effective-target vect_early_break } */


I think this is technically redundant (it just checks for neon on armv8a), but 
it's probably a good idea to keep it just in case it grows an additional check 
at some point.


  /* { dg-require-effective-target arm_neon_ok } */
  /* { dg-require-effective-target arm32 } */


These two are, I think, redundant, so can be removed; the flags added below 
will ensure they are true.


-/* { dg-options "-O3 -march=armv8-a+simd -mfpu=auto -mfloat-abi=hard  
-fno-schedule-insns -fno-reorder-blocks -fno-schedule-insns2" } */
+/* { dg-require-effective-target arm_arch_v8a_hard_ok } */
+/* { dg-options "-O3 -fno-schedule-insns -fno-reorder-blocks 
-fno-schedule-insns2" } */
+/* { dg-add-options arm_arch_v8a_hard } */
  /* { dg-final { check-function-bodies "**" "" "" } } */
  
  #define N 640


OK with that change.


Pushed as r15-5544-gec5adef9bec.

Kind regards,
Torbjörn



R.

Re: [PATCH 08/17] testsuite: arm: Use effective-target for vect-early-break-cbranch test

[Richard Earnshaw (lists)]

On 19/11/2024 10:23, Torbjörn SVENSSON wrote:
> Update test cases to use -mcpu=unset/-march=unset feature introduced in
> r15-3606-g7d6c6a0d15c.
> 
> gcc/testsuite/ChangeLog:
> 
>   * gcc.target/arm/vect-early-break-cbranch.c: Use
>   effective-target arm_arch_v8a_hard.
> 
> Signed-off-by: Torbjörn SVENSSON 
> ---
>  gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c 
> b/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
> index 334e064a239..fb12bfb3197 100644
> --- a/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
> +++ b/gcc/testsuite/gcc.target/arm/vect-early-break-cbranch.c
> @@ -2,7 +2,9 @@
>  /* { dg-require-effective-target vect_early_break } */

I think this is technically redundant (it just checks for neon on armv8a), but 
it's probably a good idea to keep it just in case it grows an additional check 
at some point.

>  /* { dg-require-effective-target arm_neon_ok } */
>  /* { dg-require-effective-target arm32 } */

These two are, I think, redundant, so can be removed; the flags added below 
will ensure they are true.

> -/* { dg-options "-O3 -march=armv8-a+simd -mfpu=auto -mfloat-abi=hard  
> -fno-schedule-insns -fno-reorder-blocks -fno-schedule-insns2" } */
> +/* { dg-require-effective-target arm_arch_v8a_hard_ok } */
> +/* { dg-options "-O3 -fno-schedule-insns -fno-reorder-blocks 
> -fno-schedule-insns2" } */
> +/* { dg-add-options arm_arch_v8a_hard } */
>  /* { dg-final { check-function-bodies "**" "" "" } } */
>  
>  #define N 640

OK with that change.

R.