Re: [PATCH 09/11] doc: Mention floating point atomic fetch_add etc in docs
On Thu, 14 Nov 2024, Sandra Loosemore wrote: > I am 100% in favor of Oxford commas. :-) : >> I'm not sure I understand what "same format" means here? Do we need this >> sentence, or can we actually drop it? > I think "same format" means "same arguments", but the whole sentence can > be dropped. > > Also, please s/floating point type/floating-point type/g per the GCC coding > conventions. Thank you, Sandra! Matthew, for the benefit of the doubt: This patch is okay with Sandra's and my suggestions taken care of. Gerald
Re: [PATCH 09/11] doc: Mention floating point atomic fetch_add etc in docs
On 11/14/24 07:51, Gerald Pfeifer wrote:
On Thu, 14 Nov 2024, mmalcom...@nvidia.com wrote:
gcc/ChangeLog:
* doc/extend.texi: Document ability to use floating point atomic
fetch_add/fetch_sub/add_fetch/sub_fetch builtins.
+Moreover, the @samp{__atomic_fetch_add}, @samp{__atomic_fetch_sub},
+@samp{__atomic_add_fetch} and @samp{__atomic_sub_fetch} builtins can accept
^^^
Do we encourage the use of Oxford commas? Mostly a question to Sandra and
Joseph, I guess.
I am 100% in favor of Oxford commas. :-)
I suggest "accept" instead of "can accept" and ...
... They
+can handle @code{bfloat16}, @code{_Float16}, @code{_Float32}, @code{_Float64}
... "handle" instead of "can handle" (the latter being a weaker
recommendation).
Yes.
... This external
+call is of the same format but specialised to the given floating point type.
I'm not sure I understand what "same format" means here? Do we need this
sentence, or can we actually drop it?
I think "same format" means "same arguments", but the whole sentence can
be dropped.
Also, please s/floating point type/floating-point type/g per the GCC
coding conventions.
https://gcc.gnu.org/codingconventions.html#Spelling
-Sandra
Re: [PATCH 09/11] doc: Mention floating point atomic fetch_add etc in docs
On Thu, 14 Nov 2024, mmalcom...@nvidia.com wrote:
> gcc/ChangeLog:
>
> * doc/extend.texi: Document ability to use floating point atomic
> fetch_add/fetch_sub/add_fetch/sub_fetch builtins.
> +Moreover, the @samp{__atomic_fetch_add}, @samp{__atomic_fetch_sub},
> +@samp{__atomic_add_fetch} and @samp{__atomic_sub_fetch} builtins can accept
^^^
Do we encourage the use of Oxford commas? Mostly a question to Sandra and
Joseph, I guess.
I suggest "accept" instead of "can accept" and ...
> ... They
> +can handle @code{bfloat16}, @code{_Float16}, @code{_Float32}, @code{_Float64}
... "handle" instead of "can handle" (the latter being a weaker
recommendation).
> ... This external
> +call is of the same format but specialised to the given floating point type.
I'm not sure I understand what "same format" means here? Do we need this
sentence, or can we actually drop it?
Gerald
