Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-15 Thread Nick Clifton
Hi Jozef, > Sorry, didn't mention in that last post that I don't have write access, > could someone please apply this for me. Applied. Sorry about the delay (again). Cheers Nick

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Jozef Lawrynowicz
On 13/06/2017 16:54, Nick Clifton wrote: Hi Jozef, Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick Sorry, didn't mention in that last post that I don't have write access, could someone please apply this for me. Thanks, Jozef

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Nick Clifton
Hi Jozef, > Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-08 Thread Jozef Lawrynowicz
On 30/05/2017 12:50, Nick Clifton wrote: When I applied this patch to the sources and ran the new test, I encountered an internal compiler error: msp430-elf/gcc/xgcc [...] pr78818-auto-warn.c [...] [...] gcc/testsuite/gcc.target/msp430/pr78818-auto-warn.c: In function 'main':

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-30 Thread Nick Clifton
Hi Jozef, > Attached patch with the string wrapped in G_(). When I applied this patch to the sources and ran the new test, I encountered an internal compiler error: msp430-elf/gcc/xgcc [...] pr78818-auto-warn.c [...] [...] gcc/testsuite/gcc.target/msp430/pr78818-auto-warn.c: In function

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-18 Thread Jozef Lawrynowicz
On 18 May 2017 at 16:46, Martin Sebor wrote: > + if (!message && TREE_NAME_EQ (name, ATTR_PERSIST) && !TREE_STATIC (* > node) > + && !TREE_PUBLIC (* node) && !DECL_EXTERNAL (* node)) > +message = "%qE attribute has no effect on automatic variables"; > > In code like

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-05-18 Thread Martin Sebor
On 05/17/2017 09:45 AM, Jozef Lawrynowicz wrote: Add warning to back end and add test. Patch is attached. If the patch is acceptable, I would appreciate if someone could commit it for me as I do not have write access. 2017-05-XX Jozef Lawrynowicz gcc/ PR