Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Ian Lance Taylor
On Wed, Jan 16, 2019 at 2:18 PM Tom de Vries wrote: > > On 16-01-19 18:17, Ian Lance Taylor wrote: > > On Wed, Jan 16, 2019 at 8:33 AM Tom de Vries wrote: > >> > >>> Why is it void**? > >> > >> It's really struct dwarf_data *, but struct dwarf_data is a type > >> declared in dwarf.c, so it's not

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Ian Lance Taylor
On Wed, Jan 16, 2019 at 2:20 PM Tom de Vries wrote: > > On 16-01-19 17:34, Tom de Vries wrote: > > On 16-01-19 17:33, Tom de Vries wrote: > >> On 16-01-19 02:02, Ian Lance Taylor wrote: > >>> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: > > Add an altlink field to struct

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 17:34, Tom de Vries wrote: > On 16-01-19 17:33, Tom de Vries wrote: >> On 16-01-19 02:02, Ian Lance Taylor wrote: >>> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: Add an altlink field to struct dwarf_data, and initialize it with the pointer to the struct

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 18:17, Ian Lance Taylor wrote: > On Wed, Jan 16, 2019 at 8:33 AM Tom de Vries wrote: >> >>> Why is it void**? >> >> It's really struct dwarf_data *, but struct dwarf_data is a type >> declared in dwarf.c, so it's not known in other files. > > It woud be OK to add "struct dwarf_data;"

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Ian Lance Taylor
On Wed, Jan 16, 2019 at 8:33 AM Tom de Vries wrote: > > > Why is it void**? > > It's really struct dwarf_data *, but struct dwarf_data is a type > declared in dwarf.c, so it's not known in other files. It woud be OK to add "struct dwarf_data;" to internal.h and refer to the struct, without

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 17:33, Tom de Vries wrote: > On 16-01-19 02:02, Ian Lance Taylor wrote: >> On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >>> >>> Add an altlink field to struct dwarf_data, and initialize it with the >>> pointer >>> to the struct dwarf_data for the .gnu_debugaltlink. >>> >>>

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-16 Thread Tom de Vries
On 16-01-19 02:02, Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: >> >> Add an altlink field to struct dwarf_data, and initialize it with the pointer >> to the struct dwarf_data for the .gnu_debugaltlink. >> >> 2018-11-11 Tom de Vries >> >> * dwarf.c

Re: [PATCH 2/9] [libbacktrace] Add altlink field to struct dwarf_data

2019-01-15 Thread Ian Lance Taylor
On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: > > Add an altlink field to struct dwarf_data, and initialize it with the pointer > to the struct dwarf_data for the .gnu_debugaltlink. > > 2018-11-11 Tom de Vries > > * dwarf.c (struct dwarf_data): Add altlink field. >