Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 03:54:43PM +0200, Bernd Schmidt wrote: > On 10/18/2016 03:54 PM, Trevor Saunders wrote: > > > > I do really prefer reading code where variables are declared at first > > use > > In general, so do I, but in this case it's one variable out of a whole > bunch, which makes

Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Bernd Schmidt
On 10/18/2016 03:54 PM, Trevor Saunders wrote: I do really prefer reading code where variables are declared at first use In general, so do I, but in this case it's one variable out of a whole bunch, which makes the entire thing look a little inconsistent. Bernd

Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Trevor Saunders
On Tue, Oct 18, 2016 at 01:18:42PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > { > > - rtx r0, r16, eqv, tga, tp, insn, dest, seq; > > + rtx r0, r16, eqv, tga, tp, dest, seq; > > + rtx_insn *insn; > > > >switch

Re: [PATCH 3/7] use rtx_insn * more

2016-10-18 Thread Bernd Schmidt
On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: { - rtx r0, r16, eqv, tga, tp, insn, dest, seq; + rtx r0, r16, eqv, tga, tp, dest, seq; + rtx_insn *insn; switch (tls_symbolic_operand_type (x)) { @@ -1025,66 +1026,70 @@ alpha_legitimize_address_1 (rtx