Re: [PATCH 7/7] make targetm.gen_ccmp{first,next} take rtx_insn **
On Tue, Oct 18, 2016 at 01:25:55PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-10-17 Trevor Saunders > > > > * ccmp.c (expand_ccmp_expr_1): Adjust. > > (expand_ccmp_expr): Likewise. > > (expand_ccmp_next): Likewise. > > * config/aarch64/aarch64.c (aarch64_gen_ccmp_next): Likewise. > > (aarch64_gen_ccmp_first): Likewise. > > * doc/tm.texi: Regenerate. > > * target.def (gen_ccmp_first): Change argument types to rtx_insn *. > > (gen_ccmp_next): Likewise. > > Looks reasonable, but has this been tested on aarch64? I think that's a > prerequisite for this patch. I just bootstrapped and regtested this against recent trunk on aarch64-linux-gnu without regressions. Thanks! Trev > > > Bernd
Re: [PATCH 7/7] make targetm.gen_ccmp{first,next} take rtx_insn **
On Tue, Oct 18, 2016 at 01:25:55PM +0200, Bernd Schmidt wrote: > On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-10-17 Trevor Saunders > > > > * ccmp.c (expand_ccmp_expr_1): Adjust. > > (expand_ccmp_expr): Likewise. > > (expand_ccmp_next): Likewise. > > * config/aarch64/aarch64.c (aarch64_gen_ccmp_next): Likewise. > > (aarch64_gen_ccmp_first): Likewise. > > * doc/tm.texi: Regenerate. > > * target.def (gen_ccmp_first): Change argument types to rtx_insn *. > > (gen_ccmp_next): Likewise. > > Looks reasonable, but has this been tested on aarch64? I think that's a > prerequisite for this patch. So far I've only checked that I can build a compiler targeting aarch64, which given the changes in the patch theoretically should be enough. However it shouldn't be hard to actually test it on an aarch64 machine so I'll do that. Thanks! Trev > > > Bernd
Re: [PATCH 7/7] make targetm.gen_ccmp{first,next} take rtx_insn **
On 10/17/2016 09:46 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2016-10-17 Trevor Saunders * ccmp.c (expand_ccmp_expr_1): Adjust. (expand_ccmp_expr): Likewise. (expand_ccmp_next): Likewise. * config/aarch64/aarch64.c (aarch64_gen_ccmp_next): Likewise. (aarch64_gen_ccmp_first): Likewise. * doc/tm.texi: Regenerate. * target.def (gen_ccmp_first): Change argument types to rtx_insn *. (gen_ccmp_next): Likewise. Looks reasonable, but has this been tested on aarch64? I think that's a prerequisite for this patch. Bernd
