Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative

2018-05-21 Thread Gerald Pfeifer
On Mon, 23 Apr 2018, Segher Boessenkool wrote:
>> Can I push this to ibm/gcc-7-branch?
> Don't ask me, I'm not maintainer of that branch.  I would point you
> to the wiki page explaining who owns it, but i cannot find that page.

https://gcc.gnu.org/svn.html

Except that the ibm/gcc-7-branch is not listed there, just a couple
of other ibm/ branches.

Perhaps you guys can address that?

Gerald


Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative

2018-04-23 Thread Paul Clarke
On 04/23/2018 02:47 PM, Segher Boessenkool wrote:
> On Mon, Apr 23, 2018 at 02:23:42PM -0500, Paul Clarke wrote:
>> Can I push this to ibm/gcc-7-branch?

> Don't ask me, I'm not maintainer of that branch.  I would point you
> to the wiki page explaining who owns it, but i cannot find that page.
> Ugh.

> You would normally get stuff onto the ibm 7 branch by just merging
> the fsf 7 branch; is there any reason it cannot go there?

Yes, the patch applies to code which was itself backported from trunk (GCC 8) 
and doesn't exist in GCC 7.

PC



Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative

2018-04-23 Thread Segher Boessenkool
On Mon, Apr 23, 2018 at 02:23:42PM -0500, Paul Clarke wrote:
> On 04/13/2018 05:40 PM, Segher Boessenkool wrote:
> > Rest looks fine...  Let's see if I manage to commit it :-)
> 
> Thanks, Segher!
> 
> Can I push this to ibm/gcc-7-branch?

Don't ask me, I'm not maintainer of that branch.  I would point you
to the wiki page explaining who owns it, but i cannot find that page.
Ugh.

You would normally get stuff onto the ibm 7 branch by just merging
the fsf 7 branch; is there any reason it cannot go there?


Segher


Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative

2018-04-23 Thread Paul Clarke
On 04/13/2018 05:40 PM, Segher Boessenkool wrote:
> Rest looks fine...  Let's see if I manage to commit it :-)

Thanks, Segher!

Can I push this to ibm/gcc-7-branch?

PC



Re: [PATCH v2, rs6000] (PR84302) Fix _mm_slli_epi{32,64} for shift values 16 through 31 and negative

2018-04-13 Thread Segher Boessenkool
Hi!

On Fri, Apr 13, 2018 at 03:21:14PM -0500, Paul Clarke wrote:
> -  if (__builtin_constant_p(__B))
> - lshift = (__v4su) vec_splat_s32(__B);
> +  if (__builtin_constant_p(__B) && __B < 16)
> +lshift = (__v4su) vec_splat_s32(__B);
>else
> - lshift = vec_splats ((unsigned int) __B);
> +lshift = vec_splats ((unsigned int) __B);

You changed the tab chars to spaces here.  Please don't.  I'll fix it.

Rest looks fine...  Let's see if I manage to commit it :-)

Thanks,


Segher