Re: [PATCH v3] Support ASan ODR indicators at compiler side.

2016-12-01 Thread Maxim Ostapenko
Jakub, thank you for review. I'll commit following patch if no issues occur after regtesting and bootstrapping. On 01/12/16 13:42, Jakub Jelinek wrote: On Thu, Dec 01, 2016 at 01:25:43PM +0300, Maxim Ostapenko wrote: + int len = strlen (IDENTIFIER_POINTER (decl_name)) + + sizeof ("_

Re: [PATCH v3] Support ASan ODR indicators at compiler side.

2016-12-01 Thread Jakub Jelinek
On Thu, Dec 01, 2016 at 01:25:43PM +0300, Maxim Ostapenko wrote: > + int len = strlen (IDENTIFIER_POINTER (decl_name)) > + + sizeof ("__odr_asan_") + 1; Please use size_t len instead of int len. Why the + 1? sizeof ("__odr_asan_") should be already strlen ("__odr_asan_") + 1. > + name