Re: [PING][PATCH, rs6000, C/C++] Fix PR target/86324: divkc3-1.c FAILs when compiling with -mabi=ieeelongdouble
On 07/06/2018 02:59 PM, Peter Bergner wrote: > On 7/5/18 2:36 PM, Jeff Law wrote: >> On 07/02/2018 03:50 PM, Peter Bergner wrote: >>> I'd like to PING: >>> >>> https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01713.html >>> >>> I've included the entire patch below, since I missed the test cases in >>> the original submission and Segher asked for some updated text for the >>> hook documentation which I've included below. >> >> OK. > > Is that an ok for GCC 8 as well which I asked for in the initial patch > submission? Well, I think that's more up to Jakub and Richi -- it doesn't seem to me like it fixes a regression, so ISTM they'd need to agree to an exception here. I don't think it's risky at all. BUt I don't want to step on their toes since they're the release managers. jeff
Re: [PING][PATCH, rs6000, C/C++] Fix PR target/86324: divkc3-1.c FAILs when compiling with -mabi=ieeelongdouble
On 7/5/18 2:36 PM, Jeff Law wrote: > On 07/02/2018 03:50 PM, Peter Bergner wrote: >> I'd like to PING: >> >> https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01713.html >> >> I've included the entire patch below, since I missed the test cases in >> the original submission and Segher asked for some updated text for the >> hook documentation which I've included below. > > OK. Is that an ok for GCC 8 as well which I asked for in the initial patch submission? Peter
Re: [PING][PATCH, rs6000, C/C++] Fix PR target/86324: divkc3-1.c FAILs when compiling with -mabi=ieeelongdouble
On 07/02/2018 03:50 PM, Peter Bergner wrote: > I'd like to PING: > > https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01713.html > > I've included the entire patch below, since I missed the test cases in > the original submission and Segher asked for some updated text for the > hook documentation which I've included below. > > Peter > > > gcc/ > PR target/86324 > * target.def (translate_mode_attribute): New hook. > * targhooks.h (default_translate_mode_attribute): Declare. > * targhooks.c (default_translate_mode_attribute): New function. > * doc/tm.texi.in (TARGET_TRANSLATE_MODE_ATTRIBUTE): New hook. > * doc/tm.texi: Regenerate. > * config/rs6000/rs6000.c (TARGET_TRANSLATE_MODE_ATTRIBUTE): Define. > (rs6000_translate_mode_attribute): New function. > > gcc/c-family/ > PR target/86324 > * c-attribs.c (handle_mode_attribute): Call new translate_mode_attribute > target hook. > > gcc/testsuite/ > PR target/86324 > gcc.target/powerpc/pr86324-1.c: New test. > gcc.target/powerpc/pr86324-2.c: Likewise. OK. jeff
