Re: [Patch] test_summary: handle single quotes
On 02/28/2018 02:30 AM, Christophe Lyon wrote: > Hi, > > We happen to build GCC with '~' in the src and build dirs, leading to > single quotes around the configure path in config.status. For example: > [...] > S["TOPLEVEL_CONFIGURE_ARGUMENTS"]="'/home/christophe.lyon/src/Linaro/abe/abe-contrib-summary/mybuild/snapshots/gcc.git~linaro~gcc-7-branch/configure' > SHELL=/bin/bash --with-mpc=/home/"\ > [...] > > This confuses contrib/test_summary which matches "/configure .* in its > awk script, which fails to match when we have "/configure' XXX" > instead. > > This patch fixes that by adding matches for the optional single > quotes. I use \047 to match the ascii "'", because I couldn't find how > to quote this properly in the awk script. > > OK for trunk? OK. jeff
Re: [Patch] test_summary: handle single quotes
ping? On 28 February 2018 at 10:30, Christophe Lyon wrote: > Hi, > > We happen to build GCC with '~' in the src and build dirs, leading to > single quotes around the configure path in config.status. For example: > [...] > S["TOPLEVEL_CONFIGURE_ARGUMENTS"]="'/home/christophe.lyon/src/Linaro/abe/abe-contrib-summary/mybuild/snapshots/gcc.git~linaro~gcc-7-branch/configure' > SHELL=/bin/bash --with-mpc=/home/"\ > [...] > > This confuses contrib/test_summary which matches "/configure .* in its > awk script, which fails to match when we have "/configure' XXX" > instead. > > This patch fixes that by adding matches for the optional single > quotes. I use \047 to match the ascii "'", because I couldn't find how > to quote this properly in the awk script. > > OK for trunk? > > Thanks, > > Christophe