Re: [fortran, patch] Fix display of locus when source contains wide characters

2012-03-04 Thread FX
> Looks OK to me except for:
> 
>> -  for (; i > 0; i--)
>> +  for (; i > 0;)
> 
> Might as well just make that a while loop.

Indeed! Committed with a while loop, thanks for the review!

FX


Re: [fortran, patch] Fix display of locus when source contains wide characters

2012-03-04 Thread Steven Bosscher
On Sat, Mar 3, 2012 at 4:08 PM, FX  wrote:
> The attached patch fixes PR 36160 
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36160). It should correctly 
> account for wide characters when display error loci. I'm not sure if we can 
> check that in the testsuite harness, but you can manually see it at work on 
> the attached test.f90.
>
> Bootstrapped and regtested on x86_64-apple-darwin11, OK for trunk?
> FX
>

Looks OK to me except for:

> -  for (; i > 0; i--)
> +  for (; i > 0;)

Might as well just make that a while loop.

Ciao!
Steven