Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread H.J. Lu
On Tue, Dec 19, 2017 at 4:41 AM, Andreas Schwab wrote: > On Dez 19 2017, "H.J. Lu" wrote: > >> This isn't sufficient. I did get >> >> ../sysdeps/unix/sysv/linux/x86/tst-ucontext-1a.c:25:10: error: call to >> \u2018getcontext\u2019 declared with attribute

Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread Andreas Schwab
On Dez 19 2017, "H.J. Lu" wrote: > This isn't sufficient. I did get > > ../sysdeps/unix/sysv/linux/x86/tst-ucontext-1a.c:25:10: error: call to > \u2018getcontext\u2019 declared with attribute error: -mshstk > incompatible with ucontext.h APIs >return getcontext (ucp);

Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread H.J. Lu
On Tue, Dec 19, 2017 at 2:25 AM, Jakub Jelinek wrote: > On Tue, Dec 19, 2017 at 09:42:11AM +, Tsimbalist, Igor V wrote: >> > I don't see any discussion in the bugzilla issue to explain this. >> >> This option is needed to support two cases: >> >> 1. Compilation of ucontext

Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread Jakub Jelinek
On Tue, Dec 19, 2017 at 09:42:11AM +, Tsimbalist, Igor V wrote: > > I don't see any discussion in the bugzilla issue to explain this. > > This option is needed to support two cases: > > 1. Compilation of ucontext functions inside glibc. To have glibc itself be CET > compatible all files

RE: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread Tsimbalist, Igor V
.@gmail.com> > Subject: Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with > makecontext family functions > > On 12/18/2017 12:39 PM, Sandra Loosemore wrote: > > On 12/17/2017 05:05 PM, Tsimbalist, Igor V wrote: > >> -fcf-protection -mcet is incom

RE: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-19 Thread Tsimbalist, Igor V
ct: Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with > makecontext family functions > > On 12/17/2017 05:05 PM, Tsimbalist, Igor V wrote: > > -fcf-protection -mcet is incompatible with makecontext family functions > > since they can't properly set up and destroy shad

Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-18 Thread Jeff Law
On 12/18/2017 12:39 PM, Sandra Loosemore wrote: > On 12/17/2017 05:05 PM, Tsimbalist, Igor V wrote: >> -fcf-protection -mcet is incompatible with makecontext family functions >> since they can't properly set up and destroy shadow stack pointer. This >> change provides a mechanism to help detection

Re: [i386] PR81842 [CET] -fcf-protection -mcet is incompatible with makecontext family functions

2017-12-18 Thread Sandra Loosemore
On 12/17/2017 05:05 PM, Tsimbalist, Igor V wrote: -fcf-protection -mcet is incompatible with makecontext family functions since they can't properly set up and destroy shadow stack pointer. This change provides a mechanism to help detection shadow stack compatibility. The current proposal is to