Re: Add std::copy_n overload for istreambuf_iterator

2019-10-14 Thread Christophe Lyon
On Thu, 10 Oct 2019 at 21:57, François Dumont wrote: > I think this build has been done between the 2 commits I used to apply > this patch (because of a problem between the chair and the keyboard). Now > it should be fine. > Indeed the test passes since at least r 276644 Thanks > But it shows

Re: Add std::copy_n overload for istreambuf_iterator

2019-10-10 Thread François Dumont
I think this build has been done between the 2 commits I used to apply this patch (because of a problem between the chair and the keyboard). Now it should be fine. But it shows that it changed the behavior of std::copy_n as soon as the new specialization is being used. Without this change

Re: Add std::copy_n overload for istreambuf_iterator

2019-10-09 Thread François Dumont
On 10/9/19 10:18 PM, Christophe Lyon wrote: On Fri, 4 Oct 2019 at 07:01, François Dumont > wrote: On 9/27/19 1:00 PM, Jonathan Wakely wrote: > On 19/07/19 23:37 +0200, François Dumont wrote: >> It sounds reasonable to overload std::copy_n for

Re: Add std::copy_n overload for istreambuf_iterator

2019-10-09 Thread Christophe Lyon
On Fri, 4 Oct 2019 at 07:01, François Dumont wrote: > On 9/27/19 1:00 PM, Jonathan Wakely wrote: > > On 19/07/19 23:37 +0200, François Dumont wrote: > >> It sounds reasonable to overload std::copy_n for istreambuf_iterator. > > I wonder whether it's worth doing: > > > > #if __cplusplus >=

Re: Add std::copy_n overload for istreambuf_iterator

2019-10-04 Thread Jonathan Wakely
On 04/10/19 07:01 +0200, François Dumont wrote: On 9/27/19 1:00 PM, Jonathan Wakely wrote: On 19/07/19 23:37 +0200, François Dumont wrote: It sounds reasonable to overload std::copy_n for istreambuf_iterator. I wonder whether it's worth doing: #if __cplusplus >= 201703L    if constexpr

Re: Add std::copy_n overload for istreambuf_iterator

2019-10-03 Thread François Dumont
On 9/27/19 1:00 PM, Jonathan Wakely wrote: On 19/07/19 23:37 +0200, François Dumont wrote: It sounds reasonable to overload std::copy_n for istreambuf_iterator. I wonder whether it's worth doing: #if __cplusplus >= 201703L    if constexpr (is_same_v<_OutputIterator, _CharT*>) return

Re: Add std::copy_n overload for istreambuf_iterator

2019-09-27 Thread Jonathan Wakely
On 19/07/19 23:37 +0200, François Dumont wrote: It sounds reasonable to overload std::copy_n for istreambuf_iterator.     * include/bits/stl_algo.h (copy_n(istreambuf_iterator<>, _Size, _OIte)):     New declaration.     * include/bits/streambuf_iterator.h (istreambuf_iterator<>): Declare