Re: Import libcilkrts Build 4467 (PR target/68945)
Hi Jeff, >> The following patch has passed x86_64-pc-linux-gnu bootstrap without >> regressions; i386-pc-solaris2.12 and sparc-sun-solaris2.12 bootstraps >> are currently running. >> >> Ok for mainline if they pass? > Yes. Sorry for not getting back to you sooner. no worries; I've been on vacation for a week anyway. Thanks. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Import libcilkrts Build 4467 (PR target/68945)
On 11/17/2016 06:06 AM, Rainer Orth wrote:
I happened to notice that my libcilkrts SPARC port has been applied
upstream. So to reach closure on this issue for the GCC 7 release, I'd
like to import upstream into mainline which seems to be covered by the
free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even
though https://gcc.gnu.org/codingconventions.html#upstream lists nothing
specific and we have no listed maintainer.
A few issues are worth mention:
* Upstream still has a typo in the git URL in many files. I've
corrected that during the import to avoid a massive diff:
-# https://bitbucket.org/intelcilkruntime/itnel-cilk-runtime.git are
+# https://bitbucket.org/intelcilkruntime/intel-cilk-runtime.git are
* libcilkrts.spec.in is missing upstream. I've no idea if this is
intentional.
* A few of my changes have been lost and I can't tell if this is by
accident:
** Lost whitespace:
--- libcilkrts-old/Makefile.am 2016-05-04 16:44:24.0 +
+++ libcilkrts-new/Makefile.am 2016-11-17 11:35:33.782987017 +
@@ -54,7 +54,7 @@ GENERAL_FLAGS = -I$(top_srcdir)/include
# Enable Intel Cilk Plus extension
GENERAL_FLAGS += -fcilkplus
-# Always generate unwind tables
+#Always generate unwind tables
GENERAL_FLAGS += -funwind-tables
AM_CFLAGS = $(XCFLAGS) $(GENERAL_FLAGS) -std=c99
** Lost alphabetical order of targets:
diff -rup libcilkrts-old/configure.ac libcilkrts-new/configure.ac
--- libcilkrts-old/configure.ac 2016-11-16 18:34:28.0 +
+++ libcilkrts-new/configure.ac 2016-11-17 11:35:33.800015570 +
@@ -143,14 +145,14 @@ esac
# contains information on what's needed
case "${target}" in
- arm-*-*)
-config_dir="arm"
-;;
-
i?86-*-* | x86_64-*-*)
config_dir="x86"
;;
+ arm-*-*)
+config_dir="arm"
+;;
+
sparc*-*-*)
config_dir="sparc"
;;
diff -rup libcilkrts-old/configure.tgt libcilkrts-new/configure.tgt
--- libcilkrts-old/configure.tgt2016-11-16 18:34:28.0 +
+++ libcilkrts-new/configure.tgt2016-11-17 11:35:33.807873451 +
@@ -44,10 +44,10 @@
# Disable Cilk Runtime library for unsupported architectures.
case "${target}" in
- arm-*-*)
-;;
i?86-*-* | x86_64-*-*)
;;
+ arm-*-*)
+;;
sparc*-*-*)
;;
*-*-*)
I've done nothing about those, just wanted to point them out.
The following patch has passed x86_64-pc-linux-gnu bootstrap without
regressions; i386-pc-solaris2.12 and sparc-sun-solaris2.12 bootstraps
are currently running.
Ok for mainline if they pass?
Yes. Sorry for not getting back to you sooner.
jeff
Re: Import libcilkrts Build 4467 (PR target/68945)
2016-11-17 20:01 GMT+03:00 Jeff Law : > On 11/17/2016 09:56 AM, Ilya Verbin wrote: >> >> 2016-11-17 18:50 GMT+03:00 Rainer Orth : >>> >>> Rainer Orth writes: >>> I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems to be covered by the free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even though https://gcc.gnu.org/codingconventions.html#upstream lists nothing specific and we have no listed maintainer. >>> >>> >>> I initially used Ilya's intel.com address, which bounced. Now using the >>> current address listed in MAINTAINERS... >> >> >> Yeah, I don't work for Intel anymore. And I'm not a libcilkrts >> maintainer, so I can't approve it. > > Do you want to be? IIRC I was going to nominate you, but held off knowing > your situation was going to change. > > If you're interested in maintainer positions, I can certainly still nominate > you. I have little experience with this library, and no longer have a connection with Cilk developers an Intel, so I'm not interested. -- Ilya
Re: Import libcilkrts Build 4467 (PR target/68945)
On 11/17/2016 09:56 AM, Ilya Verbin wrote: 2016-11-17 18:50 GMT+03:00 Rainer Orth : Rainer Orth writes: I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems to be covered by the free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even though https://gcc.gnu.org/codingconventions.html#upstream lists nothing specific and we have no listed maintainer. I initially used Ilya's intel.com address, which bounced. Now using the current address listed in MAINTAINERS... Yeah, I don't work for Intel anymore. And I'm not a libcilkrts maintainer, so I can't approve it. Do you want to be? IIRC I was going to nominate you, but held off knowing your situation was going to change. If you're interested in maintainer positions, I can certainly still nominate you. jeff
Re: Import libcilkrts Build 4467 (PR target/68945)
2016-11-17 18:50 GMT+03:00 Rainer Orth : > Rainer Orth writes: > >> I happened to notice that my libcilkrts SPARC port has been applied >> upstream. So to reach closure on this issue for the GCC 7 release, I'd >> like to import upstream into mainline which seems to be covered by the >> free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even >> though https://gcc.gnu.org/codingconventions.html#upstream lists nothing >> specific and we have no listed maintainer. > > I initially used Ilya's intel.com address, which bounced. Now using the > current address listed in MAINTAINERS... Yeah, I don't work for Intel anymore. And I'm not a libcilkrts maintainer, so I can't approve it. -- Ilya >> The following patch has passed x86_64-pc-linux-gnu bootstrap without >> regressions; i386-pc-solaris2.12 and sparc-sun-solaris2.12 bootstraps >> are currently running. >> >> Ok for mainline if they pass? > > Both Solaris bootstraps have completed successfully now. > > Rainer > > -- > - > Rainer Orth, Center for Biotechnology, Bielefeld University
Re: Import libcilkrts Build 4467 (PR target/68945)
Rainer Orth writes: > I happened to notice that my libcilkrts SPARC port has been applied > upstream. So to reach closure on this issue for the GCC 7 release, I'd > like to import upstream into mainline which seems to be covered by the > free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even > though https://gcc.gnu.org/codingconventions.html#upstream lists nothing > specific and we have no listed maintainer. I initially used Ilya's intel.com address, which bounced. Now using the current address listed in MAINTAINERS... > The following patch has passed x86_64-pc-linux-gnu bootstrap without > regressions; i386-pc-solaris2.12 and sparc-sun-solaris2.12 bootstraps > are currently running. > > Ok for mainline if they pass? Both Solaris bootstraps have completed successfully now. Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University
