Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-11-23 Thread Jakub Jelinek
On Fri, Sep 01, 2017 at 03:47:10PM +0200, dbroemmel wrote: > > If you really need a testcase, it would be enough to do something like: > > use omp_lib > > !$omp parallel num_threads(2) > > int2 = omp_get_thread_num () > > !$omp barrier > > if (int2 != omp_get_thread_num ()) call abort >

Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-09-01 Thread Jakub Jelinek
On Fri, Sep 01, 2017 at 03:47:10PM +0200, dbroemmel wrote: > > If you really need a testcase, it would be enough to do something like: > > use omp_lib > > !$omp parallel num_threads(2) > > int2 = omp_get_thread_num () > > !$omp barrier > > if (int2 != omp_get_thread_num ()) call abort >

Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-09-01 Thread dbroemmel
> If you really need a testcase, it would be enough to do something like: > use omp_lib > !$omp parallel num_threads(2) > int2 = omp_get_thread_num () > !$omp barrier > if (int2 != omp_get_thread_num ()) call abort > !$omp end parallel > or so to ensure it has the threadprivate

Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-09-01 Thread Jakub Jelinek
On Fri, Sep 01, 2017 at 02:27:40PM +0200, dbroemmel wrote: > > This is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/. > Well, that's a path where I found some Fortran OpenMP stuff, I didn't > look for other places. > > > That said, I fail to see why such a large testcase is

Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-09-01 Thread dbroemmel
> This is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/. Well, that's a path where I found some Fortran OpenMP stuff, I didn't look for other places. > That said, I fail to see why such a large testcase is needed, wouldn't a > simple > ! PR fortran/81841 > ! { dg-do compile

Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA

2017-09-01 Thread Jakub Jelinek
On Fri, Sep 01, 2017 at 11:09:47AM +0200, dbroemmel wrote: > Hi all, > > attached are a proposed fix and new testcase for PR81841. The > THREADPRIVATE statement is currently wrongly rejected as part of BLOCK DATA. > > The testcase also does (very basic) runtime checks. It fails (compiling) >