Warning flags for compatibility with clang.

2014-05-21 Thread Pedro Giffuni

Hello;

FWIW, I have been looking at some changes from Apple's GCC and these two 
small changes should be interesting to have in the official gcc.


Implement -Wmost for compatibility with clang.
http://svnweb.freebsd.org/base?view=revisionrevision=259920

Add Apple compatible -Wnewline-eof
http://svnweb.freebsd.org/base?view=revisionrevision=259555

I don't own them but I doubt any of them is copyrightable. Perhaps they 
are available in the old Apple branches that the FSF has control of.


Regards,

Pedro.


Re: Warning flags for compatibility with clang.

2014-05-21 Thread Andrew Pinski
On Wed, May 21, 2014 at 7:50 PM, Pedro Giffuni giffu...@tutopia.com wrote:
 Hello;

 FWIW, I have been looking at some changes from Apple's GCC and these two
 small changes should be interesting to have in the official gcc.

 Implement -Wmost for compatibility with clang.
 http://svnweb.freebsd.org/base?view=revisionrevision=259920

 Add Apple compatible -Wnewline-eof
 http://svnweb.freebsd.org/base?view=revisionrevision=259555

There is an older patch for this:
https://gcc.gnu.org/ml/gcc-patches/2007-04/msg00457.html

I really don't like it and hate editors which don't add a newline at
the end of the file.

Thanks,
Andrew Pinski



 I don't own them but I doubt any of them is copyrightable. Perhaps they are
 available in the old Apple branches that the FSF has control of.

 Regards,

 Pedro.


Re: Warning flags for compatibility with clang.

2014-05-21 Thread Andrew Pinski
On Wed, May 21, 2014 at 7:58 PM, Andrew Pinski pins...@gmail.com wrote:
 On Wed, May 21, 2014 at 7:50 PM, Pedro Giffuni giffu...@tutopia.com wrote:
 Hello;

 FWIW, I have been looking at some changes from Apple's GCC and these two
 small changes should be interesting to have in the official gcc.

 Implement -Wmost for compatibility with clang.
 http://svnweb.freebsd.org/base?view=revisionrevision=259920

 Add Apple compatible -Wnewline-eof
 http://svnweb.freebsd.org/base?view=revisionrevision=259555

 There is an older patch for this:
 https://gcc.gnu.org/ml/gcc-patches/2007-04/msg00457.html

 I really don't like it and hate editors which don't add a newline at
 the end of the file.


Oh we no longer warn about the newline missing at eof which is why the
patch was needed in the first place.

Thanks,
Andrew


 Thanks,
 Andrew Pinski



 I don't own them but I doubt any of them is copyrightable. Perhaps they are
 available in the old Apple branches that the FSF has control of.

 Regards,

 Pedro.