Re: Experimental Patchwork setup

2010-06-19 Thread Ryan Hill
On Wed, 09 Jun 2010 08:13:02 +0200 Paolo Bonzini bonz...@gnu.org wrote: Another point about (1): I believe patchwork should *not* track most of the branch patches, and the commit detection shouldn't care about release branch commits, only trunk. This is because those are 99% of the time

Re: Experimental Patchwork setup

2010-06-10 Thread Paolo Bonzini
On 06/10/2010 06:28 AM, Jeremy Kerr wrote: Hi Paolo, The hash would be different for git diff and svn diff due to the different headers. The headers are not included in the hash. However, the filenames will need to be the same - patchwork expects '-p1' patches, but normalises the top-level

Re: Experimental Patchwork setup

2010-06-09 Thread Paolo Bonzini
On 06/08/2010 10:37 PM, Ian Lance Taylor wrote: Are there ways that we can adjust our e-mail messages to make this work better? Two things: 1) we should make the [bracket] prefixes more standard for patches destined to feature branches; 2) we should likely not send multiple patches in one

Re: Experimental Patchwork setup

2010-06-09 Thread Manuel López-Ibáñez
On 9 June 2010 02:21, Jeremy Kerr j...@ozlabs.org wrote: There is one header you can add to emails:  X-Patchwork-Hint: ignore I am not sure how to add headers with gmail which is what I use for GCC development. I would rather have patchwork recognize something like: :patchwork: ignore: in

Re: Experimental Patchwork setup

2010-06-09 Thread Manuel López-Ibáñez
On 9 June 2010 02:21, Jeremy Kerr j...@ozlabs.org wrote: Hi Ian, I can see already that to be useful for gcc today it will need some curating.  E.g., http://patchwork.ozlabs.org/patch/54974/ is both 1) committed; 2) on a branch.  This one http://patchwork.ozlabs.org/patch/54958/ is committed

Re: Experimental Patchwork setup

2010-06-09 Thread Jeremy Kerr
Hi Manuel, 2) Use the command-line patchwork client to update patch state when a patch is committed. People have done this with a git post-commit hook to update the state of the patch in patchwork; I'm not sure if svn has something equivalent. Yes it does. If you tell us how the git

Re: Experimental Patchwork setup

2010-06-09 Thread Martin Jambor
Hi, On Wed, Jun 09, 2010 at 08:21:17AM +0800, Jeremy Kerr wrote: There is one header you can add to emails: X-Patchwork-Hint: ignore - this will tell patchwork to ignore the patch completely. I use this when sending a this is the stuff I'm merging for the next release email, as all of

Re: Experimental Patchwork setup

2010-06-09 Thread Jeremy Kerr
Hi Martin, There is one header you can add to emails: X-Patchwork-Hint: ignore - this will tell patchwork to ignore the patch completely. I use this when sending a this is the stuff I'm merging for the next release email, as all of the patches have already been through the list.

Re: Experimental Patchwork setup

2010-06-09 Thread Segher Boessenkool
Yes it does. If you tell us how the git pots-commit hook works, we could try to implement a version for svn and GCC. This is what I've used for git: [...@pororo helloworld]$ cat .git/hooks/post-applypatch #!/bin/bash sha=$(git rev-parse HEAD) hash=$(git show $sha

Re: Experimental Patchwork setup

2010-06-09 Thread Segher Boessenkool
Two things: 1) we should make the [bracket] prefixes more standard for patches destined to feature branches; Another point about (1): I believe patchwork should *not* track most of the branch patches, and the commit detection shouldn't care about release branch commits, only trunk. This is

Re: Experimental Patchwork setup

2010-06-09 Thread Paolo Bonzini
On 06/09/2010 10:03 AM, Jeremy Kerr wrote: Hi Manuel, 2) Use the command-line patchwork client to update patch state when a patch is committed. People have done this with a git post-commit hook to update the state of the patch in patchwork; I'm not sure if svn has something equivalent. Yes

Re: Experimental Patchwork setup

2010-06-09 Thread Jeremy Kerr
Hi Paolo, The hash would be different for git diff and svn diff due to the different headers. The headers are not included in the hash. However, the filenames will need to be the same - patchwork expects '-p1' patches, but normalises the top-level directory. For example, at

Re: Experimental Patchwork setup

2010-06-08 Thread Ian Lance Taylor
Segher Boessenkool seg...@kernel.crashing.org writes: Jeremy has set up a Patchwork instance for us at http://patchwork.ozlabs.org/project/gcc/list/ . It is feeding from gcc-patches; the plan is to make it automatically recognise what patches went into the tree, probably by snooping the

Re: Experimental Patchwork setup

2010-06-08 Thread Segher Boessenkool
It is feeding from gcc-patches; the plan is to make it automatically recognise what patches went into the tree, probably by snooping the gcc-cvs list. This is quite interesting, thanks for setting it up. All kudos go to Jeremy, I merely try to push people :-) I can see already that to be

Re: Experimental Patchwork setup

2010-06-08 Thread Jeremy Kerr
Hi Ian, I can see already that to be useful for gcc today it will need some curating. E.g., http://patchwork.ozlabs.org/patch/54974/ is both 1) committed; 2) on a branch. This one http://patchwork.ozlabs.org/patch/54958/ is committed to trunk. There are a number of ways to keep the patch