Re: Clear basic block flags before using BB_VISITED for OpenACC loops processing (was: basic_block flags, BB_VISITED)

On Mon, Oct 17, 2016 at 11:38 AM, Thomas Schwinge wrote: > Hi! > > On Fri, 14 Oct 2016 13:06:59 +0200, Richard Biener > wrote: >> On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: >> > On 10/14/16 05:28, Richard Biener

Re: Clear basic block flags before using BB_VISITED for OpenACC loops processing (was: basic_block flags, BB_VISITED)

On Mon, Oct 17, 2016 at 11:38 AM, Thomas Schwinge wrote: > Hi! > > On Fri, 14 Oct 2016 13:06:59 +0200, Richard Biener > wrote: >> On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: >> > On 10/14/16 05:28, Richard Biener

Clear basic block flags before using BB_VISITED for OpenACC loops processing (was: basic_block flags, BB_VISITED)

Hi! On Fri, 14 Oct 2016 13:06:59 +0200, Richard Biener wrote: > On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: > > On 10/14/16 05:28, Richard Biener wrote: > > > >> The BB_VISITED flag has indetermined state at the beginning of a pass. > >>

Clear basic block flags before using BB_VISITED for OpenACC loops processing (was: basic_block flags, BB_VISITED)

Hi! On Fri, 14 Oct 2016 13:06:59 +0200, Richard Biener wrote: > On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: > > On 10/14/16 05:28, Richard Biener wrote: > > > >> The BB_VISITED flag has indetermined state at the beginning of a pass. > >>

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 12:57 PM, Bernd Schmidt wrote: > On 10/14/2016 11:26 AM, Richard Biener wrote: >> >> On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt >> wrote: >>> >>> So maybe it should just call clear_bb_flags instead of doing the loop >>>

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 12:57 PM, Bernd Schmidt wrote: > On 10/14/2016 11:26 AM, Richard Biener wrote: >> >> On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt >> wrote: >>> >>> So maybe it should just call clear_bb_flags instead of doing the loop >>>

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: > On 10/14/16 05:28, Richard Biener wrote: > >> The BB_VISITED flag has indetermined state at the beginning of a pass. >> You have to ensure it is cleared yourself. > > > In that case the openacc (?) passes should be modified

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 1:00 PM, Nathan Sidwell wrote: > On 10/14/16 05:28, Richard Biener wrote: > >> The BB_VISITED flag has indetermined state at the beginning of a pass. >> You have to ensure it is cleared yourself. > > > In that case the openacc (?) passes should be modified

Re: basic_block flags, BB_VISITED

On 10/14/16 05:28, Richard Biener wrote: The BB_VISITED flag has indetermined state at the beginning of a pass. You have to ensure it is cleared yourself. In that case the openacc (?) passes should be modified to clear the flags at their start, rather than at their end. nathan

Re: basic_block flags, BB_VISITED

On 10/14/16 05:28, Richard Biener wrote: The BB_VISITED flag has indetermined state at the beginning of a pass. You have to ensure it is cleared yourself. In that case the openacc (?) passes should be modified to clear the flags at their start, rather than at their end. nathan

Re: basic_block flags, BB_VISITED

On 10/14/2016 11:26 AM, Richard Biener wrote: On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt wrote: So maybe it should just call clear_bb_flags instead of doing the loop itself? Ok if that works. That doesn't generally work, it clears too many flags (it was appearantly

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 10:01 AM, Thomas Schwinge wrote: > Hi! > > After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your > information), I've been observing all kinds of OpenACC offloading > failures. I now figured out what's going on. > > The "evrp" pass

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt wrote: > On 10/14/2016 10:01 AM, Thomas Schwinge wrote: >> >> After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your >> information), I've been observing all kinds of OpenACC offloading >> failures. I now figured

Re: basic_block flags, BB_VISITED

On Fri, Oct 14, 2016 at 11:15 AM, Bernd Schmidt wrote: > On 10/14/2016 10:01 AM, Thomas Schwinge wrote: >> >> After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your >> information), I've been observing all kinds of OpenACC offloading >> failures. I now figured

Re: basic_block flags, BB_VISITED

On 10/14/2016 10:01 AM, Thomas Schwinge wrote: After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your information), I've been observing all kinds of OpenACC offloading failures. I now figured out what's going on. The "evrp" pass uses basic_block's BB_VISITED flag. It first

Re: basic_block flags, BB_VISITED

On 10/14/2016 10:01 AM, Thomas Schwinge wrote: After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your information), I've been observing all kinds of OpenACC offloading failures. I now figured out what's going on. The "evrp" pass uses basic_block's BB_VISITED flag. It first

basic_block flags, BB_VISITED

Hi! After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your information), I've been observing all kinds of OpenACC offloading failures. I now figured out what's going on. The "evrp" pass uses basic_block's BB_VISITED flag. It first clears these all,

basic_block flags, BB_VISITED

Hi! After the "Add Early VRP" GCC trunk commit r240291 (Kugan CC for your information), I've been observing all kinds of OpenACC offloading failures. I now figured out what's going on. The "evrp" pass uses basic_block's BB_VISITED flag. It first clears these all,