Re: [gdal-dev] Hungarian Notation

2024-04-17 Thread Kurt Schwehr via gdal-dev
My personal take: I slightly Hungarian notation and it seems to me like needing that extra notation points to other coding style issues. However, I think moving away from it would be a chaotic mess for GDAL. It would be a massive change to switch it all. Consistency is critical. On Wed, Apr 17,

Re: [gdal-dev] Hungarian Notation

2024-04-17 Thread Even Rouault via gdal-dev
Hi, This is described in https://gdal.org/development/rfc/rfc8_devguide.html . I've submitted https://github.com/OSGeo/gdal/pull/9689 so it is going to be linked to https://gdal.org/development/dev_practices.html#making-changes-to-gdal I'd probably agree that at my beginnings in GDAL, I

Re: [gdal-dev] Hungarian Notation

2024-04-17 Thread Laurențiu Nicola via gdal-dev
Hi Andrew, I think GDAL uses a mix of styles, but if you dislike Hungarian notation, it's still important to distinguish between "systems" (e.g. dwBytes) and "apps" (e.g. cchWideChar) notation. The first one just repeats the variable type, which is mostly redundant, but the second actually

[gdal-dev] Hungarian Notation

2024-04-17 Thread Andrew Bell via gdal-dev
Hi, I was going to make some changes to some GDAL code and I generally want to follow along. I see that most of the code is still using Hungarian notation for identifier names. I haven't seen this anywhere else in like 20 years. Is it OK to submit code without this naming convention or do we