Re: [gdal-dev] Some Tests fail in Actions tab of my branch
Oh, you meant that!! I’m gonna delete that file as it never existed :) De: Even Rouault Enviado el: dimecres, 21 de febrer de 2024 13:53 Para: Abel Pau ; gdal-dev@lists.osgeo.org Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch Le 21/02/2024 à 13:44, Abel Pau a écrit : I think there’ll be no problem about changing to MIT the code we want to add to GDAL. I was talking about https://github.com/AbelPau/gdal/blob/master/ogr/ogrsf_frmts/miramon/COPYING I just copied it from other place like ogr\ogrsf_frmts\mem\ogrmemlayer.cpp There's no such file in the MEM driver. But perhaps you meant ogr/ogrsf_frmts/shape/COPYING . This is an old story with shapelib being *dual* licensed as LGPL or MIT at the option of the user. We should probably just opt for the MIT option for the shapelib copy in GDAL and remove the COPYING file from there. Actually just doing that per https://github.com/OSGeo/gdal/pull/9273. -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Some Tests fail in Actions tab of my branch
Le 21/02/2024 à 13:44, Abel Pau a écrit : I think there’ll be no problem about changing to MIT the code we want to add to GDAL. I was talking about https://github.com/AbelPau/gdal/blob/master/ogr/ogrsf_frmts/miramon/COPYING I just copied it from other place like ogr\ogrsf_frmts\mem\ogrmemlayer.cpp There's no such file in the MEM driver. But perhaps you meant ogr/ogrsf_frmts/shape/COPYING . This is an old story with shapelib being *dual* licensed as LGPL or MIT at the option of the user. We should probably just opt for the MIT option for the shapelib copy in GDAL and remove the COPYING file from there. Actually just doing that per https://github.com/OSGeo/gdal/pull/9273. -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Some Tests fail in Actions tab of my branch
I think there’ll be no problem about changing to MIT the code we want to add to GDAL. I just copied it from other place like ogr\ogrsf_frmts\mem\ogrmemlayer.cpp Or this is specified somewhere else I don’t know? Thanks for the branch advise. I’ll started a long time ago. I am learning by the time. Thanks :) De: Even Rouault Enviado el: dimecres, 21 de febrer de 2024 12:49 Para: Abel Pau ; gdal-dev@lists.osgeo.org Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch I've skimmed *very quickly* over the code (by the way you should create a dedicated git branch and not hack into the master branch. cf https://gdal.org/development/dev_practices.html#working-with-a-feature-branch), so in no means a code review, but I noticed there's a LGPL license file. This is going to be a blocker if you want to submit your code for upstream GDAL inclusion as we can't accept LGPL in the core library. If the code subject to LGPL is under your control, please relicense to MIT. Even Le 21/02/2024 à 12:36, Abel Pau a écrit : Ah ok!! Thanks Even. I’ll review that, then! I didn’t though in that way De: Even Rouault <mailto:even.roua...@spatialys.com> Enviado el: dimecres, 21 de febrer de 2024 12:34 Para: Abel Pau <mailto:a@creaf.uab.cat>; gdal-dev@lists.osgeo.org<mailto:gdal-dev@lists.osgeo.org> Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch Abel, Hi, lately I’ve been solving some issues in my code to finally do a pull request of the MiraMon vector driver. There some things about test in the action I don’t understand. I haven’t commit any test yet. So I assume it’s not my fault. Anyone knows why some of them are failing? You can see in the logs that it fails on autotest/ogr/ogr_basic_test.py::test_ogr_basic_10, and this test runs "test_ogrsf -all_drivers". As the name suggests, this test does some very minimal testing of all OGR drivers. I assume it must crash when running on the Miramon driver Even -- http://www.spatialys.com My software is free, but my time generally not. -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Some Tests fail in Actions tab of my branch
I've skimmed *very quickly* over the code (by the way you should create a dedicated git branch and not hack into the master branch. cf https://gdal.org/development/dev_practices.html#working-with-a-feature-branch), so in no means a code review, but I noticed there's a LGPL license file. This is going to be a blocker if you want to submit your code for upstream GDAL inclusion as we can't accept LGPL in the core library. If the code subject to LGPL is under your control, please relicense to MIT. Even Le 21/02/2024 à 12:36, Abel Pau a écrit : Ah ok!! Thanks Even. I’ll review that, then! I didn’t though in that way *De:*Even Rouault *Enviado el:* dimecres, 21 de febrer de 2024 12:34 *Para:* Abel Pau ; gdal-dev@lists.osgeo.org *Asunto:* Re: [gdal-dev] Some Tests fail in Actions tab of my branch Abel, Hi, lately I’ve been solving some issues in my code to finally do a pull request of the MiraMon vector driver. There some things about test in the action I don’t understand. I haven’t commit any test yet. So I assume it’s not my fault. Anyone knows why some of them are failing? You can see in the logs that it fails on autotest/ogr/ogr_basic_test.py::test_ogr_basic_10, and this test runs "test_ogrsf -all_drivers". As the name suggests, this test does some very minimal testing of all OGR drivers. I assume it must crash when running on the Miramon driver Even -- http://www.spatialys.com My software is free, but my time generally not. -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Some Tests fail in Actions tab of my branch
Ah ok!! Thanks Even. I’ll review that, then! I didn’t though in that way De: Even Rouault Enviado el: dimecres, 21 de febrer de 2024 12:34 Para: Abel Pau ; gdal-dev@lists.osgeo.org Asunto: Re: [gdal-dev] Some Tests fail in Actions tab of my branch Abel, Hi, lately I’ve been solving some issues in my code to finally do a pull request of the MiraMon vector driver. There some things about test in the action I don’t understand. I haven’t commit any test yet. So I assume it’s not my fault. Anyone knows why some of them are failing? You can see in the logs that it fails on autotest/ogr/ogr_basic_test.py::test_ogr_basic_10, and this test runs "test_ogrsf -all_drivers". As the name suggests, this test does some very minimal testing of all OGR drivers. I assume it must crash when running on the Miramon driver Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Some Tests fail in Actions tab of my branch
Abel, Hi, lately I’ve been solving some issues in my code to finally do a pull request of the MiraMon vector driver. There some things about test in the action I don’t understand. I haven’t commit any test yet. So I assume it’s not my fault. Anyone knows why some of them are failing? You can see in the logs that it fails on autotest/ogr/ogr_basic_test.py::test_ogr_basic_10, and this test runs "test_ogrsf -all_drivers". As the name suggests, this test does some very minimal testing of all OGR drivers. I assume it must crash when running on the Miramon driver Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
