On Thu, 12 Aug 2010 18:03:28 +0100, Nick Treleaven
wrote:
> On Thu, 12 Aug 2010 07:51:35 +0200
> Frank Lanitz wrote:
>
>> However, maybe we should revisit the function as it appears to me at
>> the moment that search_text could be replaced completely by using
>> utf8_search_text.
>
> We sometim
On Thu, 12 Aug 2010 07:51:35 +0200
Frank Lanitz wrote:
> However, maybe we should revisit the function as it appears to me at
> the moment that search_text could be replaced completely by using
> utf8_search_text.
We sometimes want search_text to be a different encoding than UTF-8 -
see the lin
Hi,
On Thu, 5 Aug 2010 22:14:15 +0200
Daniel Marjamäki wrote:
> I believe this will fix a memory leak in src/search.c. But please
> double-check!
>
> At lines 1417-1422 the search_text is allocated:
> if (enc != NULL && g_utf8_validate(utf8_search_text,
> utf8_text_len, NULL)) {
>
Daniel Marjamäki wrote:
> I believe this will fix a memory leak in src/search.c. But please
> double-check!
I've been running with this patch since the day it was posted.
Looks good to me.
Erik
--
--
Erik de Castro Lopo
http:
Hello!
I believe this will fix a memory leak in src/search.c. But please double-check!
At lines 1417-1422 the search_text is allocated:
if (enc != NULL && g_utf8_validate(utf8_search_text, utf8_text_len,
NULL))
{
search_text = g_convert(utf8_search_text, utf8_text
Hi Daniel,
On Wed, 19 May 2010 08:43:42 -0700
"Daniel Marjamaki" wrote:
> This patch adds a missing g_free.
Good catch! Committed with svn r4934.
Thanks very much,
Frank
--
http://frank.uvena.de/en/
pgpWlaO7bRoUF.pgp
Description: PGP signature
___
Hello!
This patch adds a missing g_free.
Original code:
tmp_str =
g_strdup(gtk_entry_get_text(GTK_ENTRY(cc_dlg->class_namespace_entry)));
if (! utils_str_equal(tmp_str, ""))
class_info->namespace_decl = g_strdup_printf("namespace
%s;", tmp_str);
