Re: [Geany-devel] tagmanager changes - tree refactoring

2012-06-07 Thread Colomban Wendling
Le 07/06/2012 17:59, Nick Treleaven a écrit : On 06/06/2012 15:42, Nick Treleaven wrote: OK, I tried building it and found some fixes are necessary for the Windows makefiles - I'll commit these to a branch. After those changes, it seems to build fine. Now pushed to:

Re: [Geany-devel] tagmanager changes

2012-05-09 Thread Thomas Martitz
Am 09.05.2012 07:47, schrieb Lex Trotman: Using ctags, including locals in the tags generated from Geany source, slightly more than doubled the number of tags, and for some C++ I have around nearly four times the number. But you only need the tags for the current scope and can drop them if

Re: [Geany-devel] tagmanager changes

2012-05-09 Thread Lex Trotman
On 9 May 2012 16:54, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 09.05.2012 07:47, schrieb Lex Trotman: Using ctags, including locals in the tags generated from Geany source, slightly more than doubled the number of tags, and for some C++ I have around nearly four times the

Re: [Geany-devel] tagmanager changes

2012-05-09 Thread Thomas Martitz
Am 09.05.2012 09:37, schrieb Lex Trotman: On 9 May 2012 16:54, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 09.05.2012 07:47, schrieb Lex Trotman: Using ctags, including locals in the tags generated from Geany source, slightly more than doubled the number of tags, and for

Re: [Geany-devel] tagmanager changes

2012-05-09 Thread Lex Trotman
On 9 May 2012 17:40, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 09.05.2012 09:37, schrieb Lex Trotman: On 9 May 2012 16:54, Thomas Martitz thomas.mart...@student.htw-berlin.de  wrote: Am 09.05.2012 07:47, schrieb Lex Trotman: Using ctags, including locals in the tags

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Matthew Brush
On 12-05-07 08:32 PM, Lex Trotman wrote: On 8 May 2012 13:27, Matthew Brushmbr...@codebrainz.ca wrote: On 12-05-07 05:03 PM, Lex Trotman wrote: On 8 May 2012 02:04, Nick Treleavennick.trelea...@btinternet.comwrote: On 02/05/2012 05:46, Lex Trotman wrote: 4. Ctags parsers Agree

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Colomban Wendling
Le 07/05/2012 18:04, Nick Treleaven a écrit : On 02/05/2012 05:46, Lex Trotman wrote: Hi All, To summarise since the thread has several subthreads. 1. Tagmanager Understandability a. I generated the doxygen documentation for tagmanager, it works if you set recursive, but didn't help much:

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Colomban Wendling
Le 02/05/2012 06:46, Lex Trotman a écrit : [...] 3. Background/asynchronous whatever you want to call it parsing a. @Colomban, you say that caches are created on first lookup, doesn't that throw work back into the UI thread which could have been done in the parsing thread? Well, yes, the

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Colomban Wendling
Le 08/05/2012 02:03, Lex Trotman a écrit : On 8 May 2012 02:04, Nick Treleaven nick.trelea...@btinternet.com wrote: [...] It doesn't look like tm_file_entry_ is really used. Along with your comment below and about project on the next post, sounds like tm code could be reduced

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Colomban Wendling
Le 30/04/2012 18:54, Nick Treleaven a écrit : On 29/04/2012 15:42, Colomban Wendling wrote: * it support asynchronous parsing (though not concurrent parsing); What's the difference? Also, what does it buy us? What I meant when saying it's asynchronous but not concurrent is that it supports

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Matthew Brush
On 12-05-08 05:44 AM, Colomban Wendling wrote: Le 08/05/2012 02:03, Lex Trotman a écrit : On 8 May 2012 02:04, Nick Treleavennick.trelea...@btinternet.com wrote: [...] It doesn't look like tm_file_entry_ is really used. Along with your comment below and about project on the next post,

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Colomban Wendling
Le 08/05/2012 14:12, Colomban Wendling a écrit : Le 30/04/2012 19:07, Nick Treleaven a écrit : On 29/04/2012 15:47, Colomban Wendling wrote: Le 26/04/2012 18:53, Nick Treleaven a écrit : On 26/04/2012 16:02, Nick Treleaven wrote: On 24/04/2012 22:31, Colomban Wendling wrote: * it uses the

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Lex Trotman
On 8 May 2012 22:31, Colomban Wendling lists@herbesfolles.org wrote: Le 07/05/2012 18:04, Nick Treleaven a écrit : On 02/05/2012 05:46, Lex Trotman wrote: Hi All, To summarise since the thread has several subthreads. 1. Tagmanager Understandability a. I generated the doxygen

Re: [Geany-devel] tagmanager changes

2012-05-08 Thread Lex Trotman
Hi All, I did a step back and got some numbers (what! hard evidence in the discussion? :) Using ctags, including locals in the tags generated from Geany source, slightly more than doubled the number of tags, and for some C++ I have around nearly four times the number. For Geany bsearching a

Re: [Geany-devel] tagmanager changes

2012-05-07 Thread Nick Treleaven
On 02/05/2012 05:46, Lex Trotman wrote: Hi All, To summarise since the thread has several subthreads. 1. Tagmanager Understandability a. I generated the doxygen documentation for tagmanager, it works if you set recursive, but didn't help much: - if its not OOP why does it say things like

Re: [Geany-devel] tagmanager changes

2012-05-07 Thread Nick Treleaven
On 07/05/2012 17:04, Nick Treleaven wrote: On 02/05/2012 05:46, Lex Trotman wrote: - its not clear how it all goes together, the workspace contains global tags and work_objects, or is that files and whats the workspace work objects are document tags. global tags explained in geany's manual.

Re: [Geany-devel] tagmanager changes

2012-05-07 Thread Lex Trotman
On 8 May 2012 02:04, Nick Treleaven nick.trelea...@btinternet.com wrote: On 02/05/2012 05:46, Lex Trotman wrote: Hi All, To summarise since the thread has several subthreads. 1. Tagmanager Understandability a. I generated the doxygen documentation for tagmanager, it works if you set

Re: [Geany-devel] tagmanager changes

2012-05-07 Thread Matthew Brush
On 12-05-07 05:03 PM, Lex Trotman wrote: On 8 May 2012 02:04, Nick Treleavennick.trelea...@btinternet.com wrote: On 02/05/2012 05:46, Lex Trotman wrote: 4. Ctags parsers Agree with Nick that the parsers are usable, but if we start modifying them to handle local declarations then they will

Re: [Geany-devel] tagmanager changes

2012-05-07 Thread Lex Trotman
On 8 May 2012 13:27, Matthew Brush mbr...@codebrainz.ca wrote: On 12-05-07 05:03 PM, Lex Trotman wrote: On 8 May 2012 02:04, Nick Treleavennick.trelea...@btinternet.com  wrote: On 02/05/2012 05:46, Lex Trotman wrote: 4. Ctags parsers Agree with Nick that the parsers are usable, but if we

Re: [Geany-devel] tagmanager changes

2012-05-01 Thread Lex Trotman
Hi All, To summarise since the thread has several subthreads. 1. Tagmanager Understandability a. I generated the doxygen documentation for tagmanager, it works if you set recursive, but didn't help much: - if its not OOP why does it say things like TMWorkspace is derived from TMWorkObject and

Re: [Geany-devel] tagmanager changes

2012-04-30 Thread Nick Treleaven
On 29/04/2012 14:07, Lex Trotman wrote: On 29 April 2012 22:07, Nick Treleavennick.trelea...@btinternet.com wrote: On 27/04/2012 06:30, Lex Trotman wrote: I don't see this myself, I see some complicating issues which could be resolved (and I'm willing to work on them), but generally a sound

Re: [Geany-devel] tagmanager changes

2012-04-30 Thread Nick Treleaven
On 29/04/2012 15:42, Colomban Wendling wrote: * it support asynchronous parsing (though not concurrent parsing); What's the difference? Also, what does it buy us? What I meant when saying it's asynchronous but not concurrent is that it supports launching the parsers in a separate thread, but

Re: [Geany-devel] tagmanager changes

2012-04-30 Thread Nick Treleaven
On 29/04/2012 15:47, Colomban Wendling wrote: Le 26/04/2012 18:53, Nick Treleaven a écrit : On 26/04/2012 16:02, Nick Treleaven wrote: On 24/04/2012 22:31, Colomban Wendling wrote: * it uses the same tag parsers tagmanager used, in ctagsmanager/ctags; BTW this is a good idea to clearly

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Nick Treleaven
On 27/04/2012 06:30, Lex Trotman wrote: [...] I don't understand why tagmanager has to be replaced, why not just replace the parts you want to improve? Rewriting it is likely to lead to a new set of bugs and be hard to review and merge changes from master. One of the problems with

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Matthew Brush
Hi Nick, I think maybe you just didn't realize how much everyone doesn't understand TagManager because we always bitch about it on IRC in passing. Actually, you might be the only person who *really* understands it :) I'll just rant a little bit about some problems with TM, as I see them

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Colomban Wendling
Hi, Le 26/04/2012 17:02, Nick Treleaven a écrit : On 24/04/2012 22:31, Colomban Wendling wrote: Le 17/04/2012 18:20, Nick Treleaven a écrit : Sorry for the long delays -- and also small activity -- recently. I have/had a lot of non-Geany stuff to do and stuff, the whole story, you know.

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Colomban Wendling
Le 26/04/2012 18:53, Nick Treleaven a écrit : On 26/04/2012 16:02, Nick Treleaven wrote: On 24/04/2012 22:31, Colomban Wendling wrote: * it uses the same tag parsers tagmanager used, in ctagsmanager/ctags; BTW this is a good idea to clearly separate CTags from tagmanager. If this change can

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Colomban Wendling
Le 27/04/2012 07:30, Lex Trotman a écrit : [...] - a multi-cache one that, as its name suggests, maintains multiple caches (sorted tags arrays). it uses a little more memory and is slower on insertion since it maintains several sorted lists, but a search on an already existing

Re: [Geany-devel] tagmanager changes

2012-04-29 Thread Colomban Wendling
Le 29/04/2012 14:07, Nick Treleaven a écrit : On 27/04/2012 06:30, Lex Trotman wrote: [...] I don't understand why tagmanager has to be replaced, why not just replace the parts you want to improve? Rewriting it is likely to lead to a new set of bugs and be hard to review and merge changes

Re: [Geany-devel] tagmanager changes

2012-04-26 Thread Nick Treleaven
On 24/04/2012 22:31, Colomban Wendling wrote: Le 17/04/2012 18:20, Nick Treleaven a écrit : Sorry for the long delays -- and also small activity -- recently. I have/had a lot of non-Geany stuff to do and stuff, the whole story, you know. No problem. I finally committed it and pushed it so

Re: [Geany-devel] tagmanager changes

2012-04-26 Thread Nick Treleaven
On 26/04/2012 16:02, Nick Treleaven wrote: On 24/04/2012 22:31, Colomban Wendling wrote: * it uses the same tag parsers tagmanager used, in ctagsmanager/ctags; BTW this is a good idea to clearly separate CTags from tagmanager. If this change can be applied separately, perhaps it could be

Re: [Geany-devel] tagmanager changes

2012-04-26 Thread Lex Trotman
[...] I don't understand why tagmanager has to be replaced, why not just replace the parts you want to improve? Rewriting it is likely to lead to a new set of bugs and be hard to review and merge changes from master. Hi Nick, It is good to see someone supporting tagmanager rather than it

Re: [Geany-devel] tagmanager changes

2012-04-24 Thread Colomban Wendling
Le 17/04/2012 18:20, Nick Treleaven a écrit : Hi, How's it going? Hi, Sorry for the long delays -- and also small activity -- recently. I have/had a lot of non-Geany stuff to do and stuff, the whole story, you know. Lex mentioned in this mail:

Re: [Geany-devel] tagmanager changes

2012-04-24 Thread Lex Trotman
[...] Also, later in the thread he says that performance problems with resorting global and workspace tags cannot be fixed with the design of tagmanager. I've been working yesterday on improving this significantly by merging the new tags each time instead of resorting *all* the tags. I hope