Re: [Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Lex Trotman
On 9 September 2010 12:40, Erik de Castro Lopo wrote: > Colomban Wendling wrote: > >> Since Glade 2.x doesn't really exist anymore (its out-of-date and >> couldn't even be compiled with recent GTK version [1]), I don't think it >> is reasonable to think that every possible contributor have it. >>

Re: [Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Lex Trotman
On 9 September 2010 11:15, Colomban Wendling wrote: > Hi, > > Le 09/09/2010 03:02, Erik de Castro Lopo a écrit : >> Hi all, >> >> Could someone clue me in as to how the src/interface.c file is >> generated? > AFAIK it is generated by Glade 2.x; but I'd think it's mentioned in the > HACKING file, i

Re: [Geany-devel] Vala plugins - Re: GOject Introspection for Geany

2010-09-08 Thread Colomban Wendling
Le 07/09/2010 17:34, Nick Treleaven a écrit : > On Sat, 04 Sep 2010 15:00:44 +0200 > Colomban Wendling wrote: > >> Well, beside this, I worked a while ago on a little hand-crafted Vala >> VAPI file for Geany [1], and although it's probably buggy because not >> well-tested, it worked. I've not tol

Re: [Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Frank Lanitz
On Thu, 09 Sep 2010 03:15:55 +0200 Colomban Wendling wrote: > Hi, > > Le 09/09/2010 03:02, Erik de Castro Lopo a écrit : > > Hi all, > > > > Could someone clue me in as to how the src/interface.c file is > > generated? > AFAIK it is generated by Glade 2.x; but I'd think it's mentioned in > the

Re: [Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Frank Lanitz
On Thu, 9 Sep 2010 11:02:42 +1000 Erik de Castro Lopo wrote: > Could someone clue me in as to how the src/interface.c file is > generated? Its created by galde. Please check http://geany.org/manual/hacking.html#glade for some info over here. > Since its autogenerated, wouldn't it be a good id

Re: [Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Colomban Wendling
Hi, Le 09/09/2010 03:02, Erik de Castro Lopo a écrit : > Hi all, > > Could someone clue me in as to how the src/interface.c file is > generated? AFAIK it is generated by Glade 2.x; but I'd think it's mentioned in the HACKING file, isn't it? > Since its autogenerated, wouldn't it be a good idea t

Re: [Geany-devel] [Patch] memory leak in src/build.c

2010-09-08 Thread Frank Lanitz
On Thu, 9 Sep 2010 10:59:37 +1000 Erik de Castro Lopo wrote: > Frank Lanitz wrote: > > > Thanks for the finding. I've committed to svn, but added a > > NULL-check just to be sure. > > The NULL check is un-necessary: > > > http://library.gnome.org/devel/glib/unstable/glib-Memory-Allocatio

[Geany-devel] How is src/interface.c generated?

2010-09-08 Thread Erik de Castro Lopo
Hi all, Could someone clue me in as to how the src/interface.c file is generated? Since its autogenerated, wouldn't it be a good idea to remove it from the repo? Obviously, it should be shipped in the source code tarball, but it is reasonable to expect that anyone working from SVN have whatever t

Re: [Geany-devel] [Patch] memory leak in src/build.c

2010-09-08 Thread Erik de Castro Lopo
Frank Lanitz wrote: > Thanks for the finding. I've committed to svn, but added a > NULL-check just to be sure. The NULL check is un-necessary: http://library.gnome.org/devel/glib/unstable/glib-Memory-Allocation.html#g-free Erik -- -

Re: [Geany-devel] [Patch] memory leak in src/build.c

2010-09-08 Thread Frank Lanitz
Hi, On Wed, 8 Sep 2010 21:02:34 +0200 Daniel Marjamäki wrote: > I have another fix for a memory leak. Here is the code: > > static void process_build_output_line(const gchar *str, gint color) > { > gchar *msg, *tmp; > gchar *filename; > gint line; > > msg = g_strdup(st

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-08 Thread Eugene Arshinov
Hi On Wed, 8 Sep 2010 16:14:07 +0100% Nick Treleaven wrote: > On Sun, 29 Aug 2010 21:59:32 +0400 > Eugene Arshinov wrote: > > > > > >> >> If we do want snippet keybindings perhaps it would be > > > > >> >> better to integrate with the existing keybindings rather > > > > >> >> than storing them

[Geany-devel] [Patch] memory leak in src/build.c

2010-09-08 Thread Daniel Marjamäki
Hello! I have another fix for a memory leak. Here is the code: static void process_build_output_line(const gchar *str, gint color) { gchar *msg, *tmp; gchar *filename; gint line; msg = g_strdup(str); g_strchomp(msg); if (! NZV(msg))

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 15:32:17 +0100 Nick Treleaven wrote: > Also if some lines have tab indentation and some spaces then the > comments could be inserted at the wrong position on some lines. Not > sure how big an issue this is. I've just realized, for the tabs & spaces mode this would be completel

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 17:55:36 +0300 Tambet Arak wrote: > >> I think the idea is good, but I've just tried the patch and it doesn't > >> work if there are empty lines in the middle of the selected block. Then > >> the comments are all inserted at column 0. > > Yes, this happens because the empty li

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-08 Thread Nick Treleaven
On Sun, 29 Aug 2010 21:59:32 +0400 Eugene Arshinov wrote: > > > >> >> If we do want snippet keybindings perhaps it would be better > > > >> >> to integrate with the existing keybindings rather than > > > >> >> storing them separately - then users could configure them in > > > >> >> the normal way

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Tambet Arak
Hi, >> I think the idea is good, but I've just tried the patch and it doesn't >> work if there are empty lines in the middle of the selected block. Then >> the comments are all inserted at column 0. Yes, this happens because the empty lines are not indented. In a sense, it is the correct behavior

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 15:32:17 +0100 Nick Treleaven wrote: > I think the idea is good, but I've just tried the patch and it doesn't > work if there are empty lines in the middle of the selected block. Then > the comments are all inserted at column 0. Forgot to mention: this is a common use case bec

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
Hi, On Tue, 31 Aug 2010 17:54:45 +0300 Tambet Arak wrote: > Any word on whether the patch will be rejected or accepted? It's > almost two months since the last correspondence. Sorry for the delay. I think the idea is good, but I've just tried the patch and it doesn't work if there are empty li