Re: [Geany-devel] [PATCH 05/19] Don't be annoying when not necessary

2010-09-15 Thread Jon Senior
On Thu, 16 Sep 2010 07:54:12 +1000 Erik de Castro Lopo wrote: > Another alternative would be to have a mode that is like the current > read-only mode, but is called view mode that is like a read only > mode but with automatic reload from disk. I haev a similar situation, but I prefer the explicit

Re: [Geany-devel] [PATCH 14/19] Rewrite tab switching queue

2010-09-15 Thread Lex Trotman
By the way, the last > commit in my tree performes indentation based on regex matching as I > was proposing some time ago. I haven't published it yet because there > are already quite many of my patches pending here and I want them to > be reviewed first. Anyway, if you (or anyone else) are intere

Re: [Geany-devel] editor context menu - Re: Search submenu for editor popup menu

2010-09-15 Thread Lex Trotman
Hey Nick, On 16 September 2010 00:33, Nick Treleaven wrote: > On Wed, 15 Sep 2010 11:15:23 +1000 > Lex Trotman wrote: > >> As noted in another response, IAW Gnome HIG right click popups S/B >> context related things. > > What does S/B mean? Sorry "should be" I was in a hurry so more acronyms th

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Nick Treleaven wrote: > > > Well, the responses are all positive. But I don't think that > > keybindings.c is the best place for this code. What about writing it > > as an idle callback from document_remove_page? > > Actually, doesn't even need a callback. Attached p

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Erik de Castro Lopo
Nick Treleaven wrote: > Well, the responses are all positive. But I don't think that > keybindings.c is the best place for this code. What about writing it > as an idle callback from document_remove_page? Actually, doesn't even need a callback. Attached patch moves the code I initially had in key

Re: [Geany-devel] [PATCH 05/19] Don't be annoying when not necessary

2010-09-15 Thread Erik de Castro Lopo
Colomban Wendling wrote: > This one seems to have been applied as r5190, and I have a little > complain about it, so perhaps it would need a little more thought. > > The problem is that reloading a document not only looses unsaved > changes, but also undo/redo stack. This is particularly annoying

Re: [Geany-devel] [PATCH 05/19] Don't be annoying when not necessary

2010-09-15 Thread Colomban Wendling
Hi, Le 16/08/2010 02:51, Erik de Castro Lopo a écrit : > Jiří Techet wrote: > >> >> When reloading a file with ctrl+R don't display the warning dialog >> that the unsaved changes might be lost when the file has not been >> modified. > > I've been running with this patch for about a week. Looks g

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-09-15 Thread Erik de Castro Lopo
Nick Treleaven wrote: > On Thu, 9 Sep 2010 20:12:18 +1000 > Erik de Castro Lopo wrote: > > > Attached is a version of this patch updated to apply cleanly against > > SVN HEAD. > > Thanks, applied. This is a great improvement IMO :) Awesome. Thanks. > BTW, the patch code style did not fit with

Re: [Geany-devel] Search submenu for editor popup menu

2010-09-15 Thread Jiří Techet
On Wed, Sep 15, 2010 at 03:15, Lex Trotman wrote: > On 15 September 2010 00:16, Nick Treleaven > wrote: >> Hi, >> I propose we add a new menubar Search submenu which is also shown in >> the popup editor menu. This would be similar to what we do for the Edit >> submenu items Format and Commands. >

Re: [Geany-devel] [PATCH 14/19] Rewrite tab switching queue

2010-09-15 Thread Jiří Techet
On Tue, Sep 14, 2010 at 16:41, Nick Treleaven wrote: > On Thu,  5 Aug 2010 01:59:48 +0200 > Jiří Techet wrote: > >> There was one more bug related to the tab switching. When we switch >> so many times that we return back to the original document (so we >> actually don't switch at all) then the fo

Re: [Geany-devel] po/geany.pot is a generated file

2010-09-15 Thread Jiří Techet
On Thu, Sep 9, 2010 at 10:20, Erik de Castro Lopo wrote: > Hi all, > > I would like to suggest that the file po/geany.pot be deleted from > the repo. This is a generated file (from po/Makefile.in.in): +1 This is very annoying when using git which complains about missing po/geany.pot which is not

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-09-15 Thread Nick Treleaven
On Thu, 9 Sep 2010 20:12:18 +1000 Erik de Castro Lopo wrote: > Attached is a version of this patch updated to apply cleanly against > SVN HEAD. Thanks, applied. This is a great improvement IMO :) BTW, the patch code style did not fit with Geany - I fixed it. You might want to read: http://gean

[Geany-devel] insert submenu - Re: editor context menu

2010-09-15 Thread Nick Treleaven
On Wed, 15 Sep 2010 15:33:50 +0100 Nick Treleaven wrote: > > insert > insert submenu including the insert comments > > I think at least me and Enrico use insert comments a lot, we'd like it > to be toplevel. The other insert items could maybe be in a submenu > (also insert alt whitespace). Actu

Re: [Geany-devel] [PATCH 19/19] Use per document indent sizes

2010-09-15 Thread Nick Treleaven
On Thu, 5 Aug 2010 01:59:53 +0200 Jiří Techet wrote: > The current implementation doesn't save the indent size to the project and > session file - this can be added if desired. Now added in SVN. Regards, Nick ___ Geany-devel mailing list Geany-devel@

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo wrote: > Currently, when closing the last tab, I get a geany window without > any text area. > > The attached patch fixes that, by creating a new untitled document > when the last tab is closed. I've been running with this patch > for over a

[Geany-devel] editor context menu - Re: Search submenu for editor popup menu

2010-09-15 Thread Nick Treleaven
On Wed, 15 Sep 2010 11:15:23 +1000 Lex Trotman wrote: > As noted in another response, IAW Gnome HIG right click popups S/B > context related things. What does S/B mean? > FWIW I'd: > > 1. remove undo/redo/select all as they are not context related Then are common editor popup menu commands th