Re: [Geany-devel] Wrap words Addon patch
Am 21.03.2012 00:33, schrieb Colomban Wendling: Le 20/03/2012 22:14, Frank Lanitz a écrit : On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' I guess you were answering to my Wrap Word Addon patches mail? Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Hum huh heh heuu… what? You mean I create a pull request on geany/gneay-plugins right? I don't know who's Nathan actually, but I doubt he's the new addons maintainer -- or I missed some mails hard and I misread the MAINTAINERS file. Nathan build the original patch set introducing wrap word into addons plugin. Anyway, I created a pull request on the GP repo directly, hopefully it's what you meant and everything's fine. Its fine. Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
Le 21/03/2012 08:21, Frank Lanitz a écrit : Am 21.03.2012 00:33, schrieb Colomban Wendling: Le 20/03/2012 22:14, Frank Lanitz a écrit : On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' I guess you were answering to my Wrap Word Addon patches mail? Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Hum huh heh heuu… what? You mean I create a pull request on geany/gneay-plugins right? I don't know who's Nathan actually, but I doubt he's the new addons maintainer -- or I missed some mails hard and I misread the MAINTAINERS file. Nathan build the original patch set introducing wrap word into addons plugin. If I read the mails and the blame correctly, it looks to me it was Alex Meyer :) Anyway, I created a pull request on the GP repo directly, hopefully it's what you meant and everything's fine. Its fine. Cool. Cheers, Colomban Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
Am 21.03.2012 15:14, schrieb Colomban Wendling: Le 21/03/2012 08:21, Frank Lanitz a écrit : Am 21.03.2012 00:33, schrieb Colomban Wendling: Le 20/03/2012 22:14, Frank Lanitz a écrit : On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' I guess you were answering to my Wrap Word Addon patches mail? Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Hum huh heh heuu… what? You mean I create a pull request on geany/gneay-plugins right? I don't know who's Nathan actually, but I doubt he's the new addons maintainer -- or I missed some mails hard and I misread the MAINTAINERS file. Nathan build the original patch set introducing wrap word into addons plugin. If I read the mails and the blame correctly, it looks to me it was Alex Meyer :) Oh yepp. You are right. Sorry for blaming the wrong guy. ;) Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
On Wed, 21 Mar 2012 15:31:50 +0100 Frank Lanitz fr...@frank.uvena.de wrote: Am 21.03.2012 15:14, schrieb Colomban Wendling: Le 21/03/2012 08:21, Frank Lanitz a écrit : Am 21.03.2012 00:33, schrieb Colomban Wendling: Le 20/03/2012 22:14, Frank Lanitz a écrit : On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' I guess you were answering to my Wrap Word Addon patches mail? Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Hum huh heh heuu… what? You mean I create a pull request on geany/gneay-plugins right? I don't know who's Nathan actually, but I doubt he's the new addons maintainer -- or I missed some mails hard and I misread the MAINTAINERS file. Nathan build the original patch set introducing wrap word into addons plugin. If I read the mails and the blame correctly, it looks to me it was Alex Meyer :) Oh yepp. You are right. Sorry for blaming the wrong guy. ;) And now I recognized that I messed up whole thread. OMFG -- http://frank.uvena.de/en/ pgpW8m1vGT8yB.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Cheers, Frank -- http://frank.uvena.de/en/ pgpfl84JWcwe5.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
Le 20/03/2012 22:14, Frank Lanitz a écrit : On Tue, 13 Dec 2011 17:46:47 +0800 Nathan Broadbent nathan@gmail.com wrote: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' I guess you were answering to my Wrap Word Addon patches mail? Once this is done and Nathan is happy with your code he will send the pull request to geany-plugins and most likely I will have tons of comments but finally will add it ;) Hum huh heh heuu… what? You mean I create a pull request on geany/gneay-plugins right? I don't know who's Nathan actually, but I doubt he's the new addons maintainer -- or I missed some mails hard and I misread the MAINTAINERS file. Anyway, I created a pull request on the GP repo directly, hopefully it's what you meant and everything's fine. Cheers, Colomban Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Wrap words Addon patch
Now that the geany-plugins has been converted to Git, I thought I'd post this patch that adds the feature I've been working on (wrapping text with characters) to the Addons plugin. Any chance of it being added? Hi Alex, Now that geany-plugins is on github, we can take advantage of the awesome 'Pull Request' feature. Everyone should read the introduction to pull requests if they are new to github. [1] Here's how you can send a pull request from your fork of geany-plugins: 1. Visit https://github.com/pzoxiuv/geany-plugins-1 2. Click 'Pull Request' 3. In the box on the right, you will see the heading 'Head branch · tag · commit'. There is an input field next to pzoxiuv/geany... @, where you should type your branch (addons_wraptext). 4. You can enter a title description, and double check the commits and changes. If everything looks good, click 'Send pull request' This is a lot more powerful than mailing patches back and forth. The 'patch' can be updated easily by adding new commits to your branch, and anyone can add comments to any of the changed lines. Best regards, Nathan [1]: http://help.github.com/send-pull-requests/ ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel