Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
On 25 February 2012 19:35, Frank Lanitz fr...@frank.uvena.de wrote: On Sat, 25 Feb 2012 10:43:10 +1100 Lex Trotman ele...@gmail.com wrote: On 25 February 2012 09:44, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 24.02.2012 23:34, schrieb Lex Trotman: I don't agree with this change, the types are just that, types, not keywords, they should not be highlighted as keywords. They are not always available. This change should be reverted. The list contained types before the commit and the commit just added more for completeness. I suggest using the secondary for types instead. Yes, good idea, if I understand the comment in highlightingmappings.h:206 it is meant for types. Cheers Lex PS the existing list contains the fundamental types that are always available without headers, these new ones need a header (though size_t is used so much that almost any header will do :) I did like that idea adding more often used one. But you are right cleaning up a bit and maybe resorting them would be might a ice idea. Cheers, Frank Hi Frank, I think Thomas' idea of adding those that are not fundamental types to the secondary list is the right thing, they get highlighted as types not keywords and as you say the common ones are then available. Best of both worlds :). I think all the ones that were originally in the list were fundamental in C++11, so its only the new ones IIUC. I was going to do it today but havn't had time. Cheers Lex -- http://frank.uvena.de/en/ ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
Am 25.02.2012 09:55, schrieb Lex Trotman: On 25 February 2012 19:35, Frank Lanitzfr...@frank.uvena.de wrote: On Sat, 25 Feb 2012 10:43:10 +1100 Lex Trotmanele...@gmail.com wrote: On 25 February 2012 09:44, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 24.02.2012 23:34, schrieb Lex Trotman: I don't agree with this change, the types are just that, types, not keywords, they should not be highlighted as keywords. They are not always available. This change should be reverted. The list contained types before the commit and the commit just added more for completeness. I suggest using the secondary for types instead. Yes, good idea, if I understand the comment in highlightingmappings.h:206 it is meant for types. Cheers Lex PS the existing list contains the fundamental types that are always available without headers, these new ones need a header (though size_t is used so much that almost any header will do :) I did like that idea adding more often used one. But you are right cleaning up a bit and maybe resorting them would be might a ice idea. Cheers, Frank Hi Frank, I think Thomas' idea of adding those that are not fundamental types to the secondary list is the right thing, they get highlighted as types not keywords and as you say the common ones are then available. Best of both worlds :). I think all the ones that were originally in the list were fundamental in C++11, so its only the new ones IIUC. My idea was adding *all* types to secondary. Why differentiate between fundamental/needs header and others? The important point is they are types and not keywords. Best regards. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
Lex Trotman wrote: On 26 February 2012 10:31, Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Lex Trotman wrote: I have thought about which types should be automagically present in Geany without a tags file, and I do not think the intN_t types qualify. They are not fundamental, In C99 they are. they require header cstdint to Thats C++. I'm pretty sure all the C99 intN_t types were added to the latest C++ standard as well. The changes we are talking about are to filetypes.cpp which is c++ My apologies. I came in to the middle of this thread and missed the context. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
I don't agree with this change, the types are just that, types, not keywords, they should not be highlighted as keywords. They are not always available. This change should be reverted. Cheers Lex On 25 February 2012 08:01, Frank Lanitz git-nore...@geany.org wrote: Branch: refs/heads/master Author: Frank Lanitz fr...@frank.uvena.de Committer: Frank Lanitz fr...@frank.uvena.de Date: Fri, 24 Feb 2012 21:01:08 Commit: 795ee4cf4bea525814b5793a6771d3da78f6c863 https://github.com/geany/geany/commit/795ee4cf4bea525814b5793a6771d3da78f6c863 Log Message: --- Merge pull request #28 from RetroX/patch-1 Added size_t, ptrdiff_t, intN_t to filetypes.cpp. Modified Paths: -- data/filetypes.cpp Modified: data/filetypes.cpp 2 files changed, 1 insertions(+), 1 deletions(-) === @@ -3,7 +3,7 @@ [keywords] # all items must be in one line -primary=alignas alignof and and_eq asm auto bitand bitor bool break case catch char char16_t char32_t class compl const constexpr const_cast continue decltype default delete do double dynamic_cast else enum explicit export extern false final float for friend goto if inline int long mutable namespace new noexcept not not_eq nullptr operator or or_eq override private protected public register reinterpret_cast return short signed sizeof static static_assert static_cast struct switch template this thread_local throw true try typedef typeid typename union unsigned using virtual void volatile wchar_t while xor xor_eq +primary=alignas alignof and and_eq asm auto bitand bitor bool break case catch char char16_t char32_t class compl const const_cast constexpr continue decltype default delete do double dynamic_cast else enum explicit export extern false final float for friend goto if inline int int8_t int16_t int32_t int64_t long mutable namespace new noexcept not not_eq nullptr operator or or_eq override private protected ptrdiff_t public register reinterpret_cast return short signed sizeof size_t static static_assert static_cast struct switch template this thread_local throw true try typedef typeid typename union unsigned using virtual void volatile wchar_t while xor xor_eq secondary= # these are some doxygen keywords (incomplete) docComment=attention author brief bug class code date def enum example exception file fn namespace note param remarks return see since struct throw todo tparam typedef var version warning union -- This E-Mail was brought to you by github_commit_mail.py (Source: TBD). ___ Geany-commits mailing list geany-comm...@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-commits ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
Am 24.02.2012 23:34, schrieb Lex Trotman: I don't agree with this change, the types are just that, types, not keywords, they should not be highlighted as keywords. They are not always available. This change should be reverted. The list contained types before the commit and the commit just added more for completeness. I suggest using the secondary for types instead. Best regards. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] [geany/geany] 795ee4: Merge pull request #28 from RetroX/patch-1
On 25 February 2012 09:44, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 24.02.2012 23:34, schrieb Lex Trotman: I don't agree with this change, the types are just that, types, not keywords, they should not be highlighted as keywords. They are not always available. This change should be reverted. The list contained types before the commit and the commit just added more for completeness. I suggest using the secondary for types instead. Yes, good idea, if I understand the comment in highlightingmappings.h:206 it is meant for types. Cheers Lex PS the existing list contains the fundamental types that are always available without headers, these new ones need a header (though size_t is used so much that almost any header will do :) Best regards. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
