Re: [Geany-devel] [patch] Little code/warnings cleanup (was Re: [patch] Constify some arguments and fields)

2010-04-27 Thread Nick Treleaven
On Thu, 22 Apr 2010 23:56:35 +0200 Colomban Wendling lists@herbesfolles.org wrote: * the stash_group_add_entry() and its widget_id. The thing is that when it is a string it should be constant, but when it is a widget it shouldn't be... perhaps it is fine as now. I'm not sure what to do

Re: [Geany-devel] [patch] Little code/warnings cleanup (was Re: [patch] Constify some arguments and fields)

2010-04-25 Thread Enrico Tröger
On Thu, 22 Apr 2010 23:56:35 +0200, Colomban wrote: On quite the same topic, would a patch that fixes a lot of small problems like that in Geany's core be appreciated? It isn't hard to do but I think it would clean the code a bit. Yes, but only if it's clear that const is really meant, not

Re: [Geany-devel] [patch] Little code/warnings cleanup (was Re: [patch] Constify some arguments and fields)

2010-04-25 Thread Colomban Wendling
* main.c:1212+: What's that malloc stuff for??? These functions aren't even used... http://geany.svn.sf.net/viewvc/geany?view=revrevision=1596 and see http://lists.uvena.de/pipermail/geany/2007-June/001093.html for the discussion about it. Maybe we can remove rpl_malloc() because we

Re: [Geany-devel] [patch] Little code/warnings cleanup (was Re: [patch] Constify some arguments and fields)

2010-04-25 Thread Enrico Tröger
On Sun, 25 Apr 2010 14:25:30 +0200, Colomban wrote: * main.c:1212+: What's that malloc stuff for??? These functions aren't even used... http://geany.svn.sf.net/viewvc/geany?view=revrevision=1596 and see http://lists.uvena.de/pipermail/geany/2007-June/001093.html for the discussion about

[Geany-devel] [patch] Little code/warnings cleanup (was Re: [patch] Constify some arguments and fields)

2010-04-22 Thread Colomban Wendling
On quite the same topic, would a patch that fixes a lot of small problems like that in Geany's core be appreciated? It isn't hard to do but I think it would clean the code a bit. Yes, but only if it's clear that const is really meant, not just to silence compiler warnings. Of course. Casting