Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
> > One more thing: > gms_gui.c:579: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > gms_gui.c:580: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > gms_gui.c:582: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > gms_gui.c:583: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > gms_gui.c:584: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > gms_gui.c:585: error: Possible null pointer dereference: this - > otherwise it is redundant to check if this is null at line 590 > Cppcheck doesn't like that in GMS_G_FREE macro called at line 590 there is a check for nullity. I already discovered it earlier and was going to ask you about it later. Well, I will remove the nullity check from the macro in 4-5 ours. The check is indeed redundant since g_free does nothing when a null pointer is passed. But it breaks simmetry with another macros (GMS_FREE_WIDGET and another one, I don't remember the name). If cppcheck complained about one of those macros, that wouldn't be so easy to fix because nullity check there is actually useful, not redundant... But it's besides the point. Sorry for possibly wrong formatting, I'm posting through GMail... ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 5 Feb 2012 19:37:47 +0400 Eugene Arshinov wrote: > On Sun, 05 Feb 2012 15:50:54 +0100 > Frank Lanitz wrote: > > > Am 05.02.2012 12:17, schrieb Eugene Arshinov: > > > On Sun, 05 Feb 2012 11:53:20 +0100 > > > Frank Lanitz wrote: > > > > > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: > > >> > > >>> I sent a pull request [1] which contains the plugin integrated > > >>> into geany-plugins. Review and pull, if you wish. > > >>> > > >>> I also created a repository [2] which contains geany-mini-script > > >>> plugin at the state in which it was in SVN repo. > > >> > > >> Cool. Will you take over maintainership of the code? If so, can > > >> do also an update on MAINTAINERS? > > >> > > > > > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we > > > specify plugin's web page. I'd like it to be [1], but the page > > > can't exist yet. > > > > During the process ... Can you check: > > > > [...] > > gms_gui.c: In function 'save_prefs_file': > > gms_gui.c:198:5: warning: too many arguments for format > > [-Wformat-extra-args] > > > > Uhh, sorry for a delay. I'll check it in 15 minutes. One more thing: gms_gui.c:579: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 gms_gui.c:580: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 gms_gui.c:582: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 gms_gui.c:583: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 gms_gui.c:584: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 gms_gui.c:585: error: Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 590 Cheers, Frank -- http://frank.uvena.de/en/ pgpNZ6To3l7g5.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 05 Feb 2012 11:36:22 -0800 Matthew Brush wrote: > On 02/05/2012 02:43 AM, Eugene Arshinov wrote: > > Hi Frank. > > > > I sent a pull request [1] which contains the plugin integrated into > > geany-plugins. Review and pull, if you wish. > > > > I also created a repository [2] which contains geany-mini-script > > plugin at the state in which it was in SVN repo. > > > > [1]: https://github.com/geany/geany-plugins/pull/13 > > [2]: https://github.com/earshinov/geany-mini-script > > > > Just out of curiosity, isn't Mini Script kind of redundant with > having the Edit->Format->Send Selection To feature? I guess it has a > few more options but it seems to do the same thing. True. An example of why the plugin can be useful: it allows to conveniently write temporary scripts and execute them immediately. Also, with the plugin you can open your script when you need it, and the script won't hang in the "Send selection to..." menu. By the way, it seems "Send selection to" has been available for a long time and even before than the original author wrote the Mini Script plugin (at the beginning of 2009). -- Best regards, Eugene. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On 02/05/2012 02:43 AM, Eugene Arshinov wrote: Hi Frank. I sent a pull request [1] which contains the plugin integrated into geany-plugins. Review and pull, if you wish. I also created a repository [2] which contains geany-mini-script plugin at the state in which it was in SVN repo. [1]: https://github.com/geany/geany-plugins/pull/13 [2]: https://github.com/earshinov/geany-mini-script Just out of curiosity, isn't Mini Script kind of redundant with having the Edit->Format->Send Selection To feature? I guess it has a few more options but it seems to do the same thing. Cheers, Matthew Brush ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 05 Feb 2012 15:47:41 +0100 Frank Lanitz wrote: > Am 05.02.2012 12:17, schrieb Eugene Arshinov: > > On Sun, 05 Feb 2012 11:53:20 +0100 > > Frank Lanitz wrote: > > > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: > >> > >>> I sent a pull request [1] which contains the plugin integrated > >>> into geany-plugins. Review and pull, if you wish. > >>> > >>> I also created a repository [2] which contains geany-mini-script > >>> plugin at the state in which it was in SVN repo. > >> > >> Cool. Will you take over maintainership of the code? If so, can do > >> also an update on MAINTAINERS? > >> > > > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we > > specify plugin's web page. I'd like it to be [1], but the page > > can't exist yet. > > Just leave it out. We will add it later ;) > Okay. I added another commit to the pull request. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 05 Feb 2012 15:50:54 +0100 Frank Lanitz wrote: > Am 05.02.2012 12:17, schrieb Eugene Arshinov: > > On Sun, 05 Feb 2012 11:53:20 +0100 > > Frank Lanitz wrote: > > > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: > >> > >>> I sent a pull request [1] which contains the plugin integrated > >>> into geany-plugins. Review and pull, if you wish. > >>> > >>> I also created a repository [2] which contains geany-mini-script > >>> plugin at the state in which it was in SVN repo. > >> > >> Cool. Will you take over maintainership of the code? If so, can do > >> also an update on MAINTAINERS? > >> > > > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we > > specify plugin's web page. I'd like it to be [1], but the page > > can't exist yet. > > During the process ... Can you check: > > [...] > gms_gui.c: In function 'save_prefs_file': > gms_gui.c:198:5: warning: too many arguments for format > [-Wformat-extra-args] > Fixed. That was an innocent excessive argument of g_string_sprinf, probably left out after copy & paste. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 05 Feb 2012 15:50:54 +0100 Frank Lanitz wrote: > Am 05.02.2012 12:17, schrieb Eugene Arshinov: > > On Sun, 05 Feb 2012 11:53:20 +0100 > > Frank Lanitz wrote: > > > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: > >> > >>> I sent a pull request [1] which contains the plugin integrated > >>> into geany-plugins. Review and pull, if you wish. > >>> > >>> I also created a repository [2] which contains geany-mini-script > >>> plugin at the state in which it was in SVN repo. > >> > >> Cool. Will you take over maintainership of the code? If so, can do > >> also an update on MAINTAINERS? > >> > > > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we > > specify plugin's web page. I'd like it to be [1], but the page > > can't exist yet. > > During the process ... Can you check: > > [...] > gms_gui.c: In function 'save_prefs_file': > gms_gui.c:198:5: warning: too many arguments for format > [-Wformat-extra-args] > Uhh, sorry for a delay. I'll check it in 15 minutes. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
Am 05.02.2012 12:17, schrieb Eugene Arshinov: > On Sun, 05 Feb 2012 11:53:20 +0100 > Frank Lanitz wrote: > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: >> >>> I sent a pull request [1] which contains the plugin integrated into >>> geany-plugins. Review and pull, if you wish. >>> >>> I also created a repository [2] which contains geany-mini-script >>> plugin at the state in which it was in SVN repo. >> >> Cool. Will you take over maintainership of the code? If so, can do >> also an update on MAINTAINERS? >> > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we specify > plugin's web page. I'd like it to be [1], but the page can't exist yet. During the process ... Can you check: [...] gms_gui.c: In function 'save_prefs_file': gms_gui.c:198:5: warning: too many arguments for format [-Wformat-extra-args] Cheers, Frank signature.asc Description: OpenPGP digital signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
Am 05.02.2012 12:17, schrieb Eugene Arshinov: > On Sun, 05 Feb 2012 11:53:20 +0100 > Frank Lanitz wrote: > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov: >> >>> I sent a pull request [1] which contains the plugin integrated into >>> geany-plugins. Review and pull, if you wish. >>> >>> I also created a repository [2] which contains geany-mini-script >>> plugin at the state in which it was in SVN repo. >> >> Cool. Will you take over maintainership of the code? If so, can do >> also an update on MAINTAINERS? >> > > Yes, I agree to be the maintainer. But, in MAINTAINERS file we specify > plugin's web page. I'd like it to be [1], but the page can't exist yet. Just leave it out. We will add it later ;) Cheers, Frank signature.asc Description: OpenPGP digital signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 05 Feb 2012 11:53:20 +0100 Frank Lanitz wrote: > Am 05.02.2012 11:43, schrieb Eugene Arshinov: > > > I sent a pull request [1] which contains the plugin integrated into > > geany-plugins. Review and pull, if you wish. > > > > I also created a repository [2] which contains geany-mini-script > > plugin at the state in which it was in SVN repo. > > Cool. Will you take over maintainership of the code? If so, can do > also an update on MAINTAINERS? > Yes, I agree to be the maintainer. But, in MAINTAINERS file we specify plugin's web page. I'd like it to be [1], but the page can't exist yet. [1]: http://plugins.geany.org/geanyminiscript.html ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
Am 05.02.2012 11:43, schrieb Eugene Arshinov: > I sent a pull request [1] which contains the plugin integrated into > geany-plugins. Review and pull, if you wish. > > I also created a repository [2] which contains geany-mini-script plugin > at the state in which it was in SVN repo. Cool. Will you take over maintainership of the code? If so, can do also an update on MAINTAINERS? Cheers, Frank signature.asc Description: OpenPGP digital signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
Hi Frank. I sent a pull request [1] which contains the plugin integrated into geany-plugins. Review and pull, if you wish. I also created a repository [2] which contains geany-mini-script plugin at the state in which it was in SVN repo. [1]: https://github.com/geany/geany-plugins/pull/13 [2]: https://github.com/earshinov/geany-mini-script -- Best regards, Eugene. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sat, 12 Nov 2011 00:03:30 +0400 Eugene Arshinov wrote: > On Thu, 10 Nov 2011 22:41:06 +0100 > Frank Lanitz wrote: > > > Am 08.10.2011 21:50, schrieb Eugene Arshinov: > > >> > Unfortunately I didn't heard back of developer of > > >> > geany-mini-script-plugin so today I like to ask you whether > > >> > somebody likes to take over maintenance for geany-mini-script > > >> > plugin inside geany-plugins-svn. It's untouched since maybe > > >> > 2009 and to be honest I have no idea, what's the current > > >> > status. Also I'm not 100% whether its still a useful plugin or > > >> > maybe some other plugin is taking over the task in a better > > >> > way. Personally I remember it as a possible useful plugin but > > >> > don't have the resources to look after and used it >>1 year > > >> > for the last time. If nobody is feeling responsible I suggest, > > >> > similar to previous plugins, we remove it from official > > >> > repository. > > > > > > In case someone wants to try the plugin, here is a patch to make > > > it compile. > > > > Did anyone try it? Does anyone likes to take it over and maybe > > integrate it into geany-plugins? > > > > If no one wants, I could take a minimal care of this plugin. Though, > I can't promise I'll have time for it when it's needed. I still have > SM-branch related stuff which I can't do for weeks... > Hi Frank. I wonder what's the state of the geany-mini-scripts plugin now? It seems that only SVN's /geany-plugins/geany-plugins/ part was converted to Git, and AFAIR geany-mini-script was living next to geany-plugins (at /geany-plugins/geany-mini-script/) and wasn't converted. I can use the copy from my local geany-plugins Git repository (bound to the old SVN repository) and push it somewhere on Github. Then perhaps I can integrate the plugin into geany-plugins, push the result to a fork of geany-plugins and send a pull request. Is it the way to go? -- Best regards, Eugene. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Thu, 10 Nov 2011 22:41:06 +0100 Frank Lanitz wrote: > Am 08.10.2011 21:50, schrieb Eugene Arshinov: > >> > Unfortunately I didn't heard back of developer of > >> > geany-mini-script-plugin so today I like to ask you whether > >> > somebody likes to take over maintenance for geany-mini-script > >> > plugin inside geany-plugins-svn. It's untouched since maybe 2009 > >> > and to be honest I have no idea, what's the current status. Also > >> > I'm not 100% whether its still a useful plugin or maybe some > >> > other plugin is taking over the task in a better way. Personally > >> > I remember it as a possible useful plugin but don't have the > >> > resources to look after and used it >>1 year for the last time. > >> > If nobody is feeling responsible I suggest, similar to previous > >> > plugins, we remove it from official repository. > > > > In case someone wants to try the plugin, here is a patch to make it > > compile. > > Did anyone try it? Does anyone likes to take it over and maybe > integrate it into geany-plugins? > If no one wants, I could take a minimal care of this plugin. Though, I can't promise I'll have time for it when it's needed. I still have SM-branch related stuff which I can't do for weeks... -- Best regards, Eugene. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
Am 08.10.2011 21:50, schrieb Eugene Arshinov: >> > Unfortunately I didn't heard back of developer of >> > geany-mini-script-plugin so today I like to ask you whether somebody >> > likes to take over maintenance for geany-mini-script plugin inside >> > geany-plugins-svn. It's untouched since maybe 2009 and to be honest I >> > have no idea, what's the current status. Also I'm not 100% whether its >> > still a useful plugin or maybe some other plugin is taking over the >> > task in a better way. Personally I remember it as a possible useful >> > plugin but don't have the resources to look after and used it >>1 year >> > for the last time. >> > If nobody is feeling responsible I suggest, similar to previous >> > plugins, we remove it from official repository. > > In case someone wants to try the plugin, here is a patch to make it > compile. Did anyone try it? Does anyone likes to take it over and maybe integrate it into geany-plugins? Cheers, Frank ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] Maintainerrequest: Geany-Mini-Script
On Sun, 2 Oct 2011 22:39:42 +0200
Frank Lanitz wrote:
> Hi folks,
>
> Unfortunately I didn't heard back of developer of
> geany-mini-script-plugin so today I like to ask you whether somebody
> likes to take over maintenance for geany-mini-script plugin inside
> geany-plugins-svn. It's untouched since maybe 2009 and to be honest I
> have no idea, what's the current status. Also I'm not 100% whether its
> still a useful plugin or maybe some other plugin is taking over the
> task in a better way. Personally I remember it as a possible useful
> plugin but don't have the resources to look after and used it >>1 year
> for the last time.
> If nobody is feeling responsible I suggest, similar to previous
> plugins, we remove it from official repository.
Hi Frank.
In case someone wants to try the plugin, here is a patch to make it
compile.
P.S. I remember that a couple of months ago I promised to send you an
overview of what changes are in the SM branch… I hope I will find time
for it in the near future.
--
Best regards,
Eugene
diff --git a/geany-mini-script/src/gms.c b/geany-mini-script/src/gms.c
index 90ef913..ef6b2e2 100644
--- a/geany-mini-script/src/gms.c
+++ b/geany-mini-script/src/gms.c
@@ -38,7 +38,7 @@
* - it will be loaded at next startup.
*/
-#include"geany.h"
+#include
/* headers */
#include
@@ -49,17 +49,6 @@
#include
#endif
-
-/* geany headers */
-#include"support.h"
-#include"plugindata.h"
-#include"editor.h"
-#include"document.h"
-#include"prefs.h"
-#include"utils.h"
-#include"ui_utils.h"
-#include"pluginmacros.h"
-
/* user header */
#include"gms.h"
#include"gms_gui.h"
@@ -77,7 +66,7 @@ PLUGIN_VERSION_CHECK(100)
/* All plugins must set name, description, version and author. */
PLUGIN_SET_INFO(_("geany mini-script"), _("GMS (Geany Mini-Script filter plugin)"),
-VERSION , _("Pascal BURLOT, a Geany user"))
+"0.1" , _("Pascal BURLOT, a Geany user"))
static GtkWidget *gms_item = NULL ;
static gms_handle_t gms_hnd = NULL ;
@@ -90,12 +79,12 @@ static gchar*gms_command = NULL ;
static void create_selection_2_input_file( ScintillaObject *sci )
{
gchar *contents = NULL;
-gintsize_buf = p_sci->get_selected_text_length(sci);
+gintsize_buf = sci_get_selected_text_length(sci);
contents = GMS_G_MALLOC( gchar, size_buf + 1 ) ;
GMS_PNULL(contents) ;
-p_sci->get_selected_text( sci ,contents );
+sci_get_selected_text( sci ,contents );
g_file_set_contents(gms_get_in_filename(gms_hnd), contents, -1 , NULL );
GMS_G_FREE(contents);
@@ -124,10 +113,10 @@ static gchar *read_result_file( gchar *filename )
*/
static void select_entirely_doc( ScintillaObject *sci )
{
-gintsize_buf = p_sci->get_length(sci);
+gintsize_buf = sci_get_length(sci);
-p_sci->set_selection_start( sci , 0 ) ;
-p_sci->set_selection_end( sci , size_buf ) ;
+sci_set_selection_start( sci , 0 ) ;
+sci_set_selection_end( sci , size_buf ) ;
}
/**
@@ -136,7 +125,7 @@ static void select_entirely_doc( ScintillaObject *sci )
static void update_doc( ScintillaObject *sci, gchar * contents )
{
if (contents==NULL) return ;
-p_sci->replace_sel( sci, contents );
+sci_replace_sel( sci, contents );
}
/**
* \brief the function deletes the tempory files
@@ -189,11 +178,11 @@ static gint run_filter( ScintillaObject *sci )
}
else
{
-p_document->new_file( NULL, NULL, result ) ;
+document_new_file( NULL, NULL, result ) ;
}
}
GMS_G_FREE( result ) ;
-
+
return ret ;
}
@@ -202,7 +191,7 @@ static gint run_filter( ScintillaObject *sci )
*/
static void item_activate(GtkMenuItem *menuitem, gpointer gdata)
{
-GeanyDocument *doc = p_document->get_current();
+GeanyDocument *doc = document_get_current();
ScintillaObject *sci = doc->editor->sci ;
if ( gms_hnd == NULL )
return ;
@@ -230,12 +219,12 @@ static void item_activate(GtkMenuItem *menuitem, gpointer gdata)
guint nb_doc = 0 , i=0;
/* find the opened document in the geany session */
-while ( (doc = p_document->get_from_page(nb_doc))!=NULL ) nb_doc++;
+while ( (doc = document_get_from_page(nb_doc))!=NULL ) nb_doc++;
/* For each document */
for( i=0; iget_from_page(i) ;
+doc = document_get_from_page(i) ;
sci = doc->editor->sci ;
select_entirely_doc( sci ) ;
create_selection_2_input_file(sci) ;
@@ -302,7 +291,7 @@ void plugin_init(GeanyData *data)
g_signal_connect(gms_item, "activate", G_CALLBACK(item_activate), NULL);
/* make the menu item sensitive only when documents are open */
-p_ui->add_document_sensitive(gms_item);
+ui_add_document_sensitive(
[Geany-devel] Maintainerrequest: Geany-Mini-Script
Hi folks, Unfortunately I didn't heard back of developer of geany-mini-script-plugin so today I like to ask you whether somebody likes to take over maintenance for geany-mini-script plugin inside geany-plugins-svn. It's untouched since maybe 2009 and to be honest I have no idea, what's the current status. Also I'm not 100% whether its still a useful plugin or maybe some other plugin is taking over the task in a better way. Personally I remember it as a possible useful plugin but don't have the resources to look after and used it >>1 year for the last time. If nobody is feeling responsible I suggest, similar to previous plugins, we remove it from official repository. Cheers, Frank -- http://frank.uvena.de/en/ pgpWPhQnQanfD.pgp Description: PGP signature ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
