Re: [Geany-devel] Safe file saving - permissions issue

2010-05-15 Thread Lex Trotman
On 15 May 2010 14:40, Jon Senior j...@restlesslemon.co.uk wrote: On Sat, 15 May 2010 14:10:06 +1000 Lex Trotman ele...@gmail.com wrote: Since it doesn't know the status of the directory the file was in or even the whole filesystem, and finding out could cause long delays as things time

Re: [Geany-devel] Safe file saving - permissions issue

2010-05-15 Thread Lex Trotman
On 15 May 2010 17:34, Lex Trotman ele...@gmail.com wrote: On 15 May 2010 14:40, Jon Senior j...@restlesslemon.co.uk wrote: On Sat, 15 May 2010 14:10:06 +1000 Lex Trotman ele...@gmail.com wrote: Since it doesn't know the status of the directory the file was in or even the whole

Re: [Geany-devel] Safe file saving - permissions issue

2010-05-14 Thread Enrico Tröger
On Sat, 03 Apr 2010 04:20:14 +0200, Colomban wrote: Hi all, sorry for the long delay, I couldn't make myself into this topic again. I think the best way is to use GIO when possible, since it is meant for that; and it is unrealistic to handle each and every limitation of I'm unsure what we

Re: [Geany-devel] Safe file saving - permissions issue

2010-05-14 Thread Jon Senior
On Fri, 14 May 2010 18:42:26 +0200 Enrico Tröger enrico.troe...@uvena.de wrote: Sigh. So much work just to save files :(. I don't know if it makes any difference, but I regularly use geany over an sshfs connection with few or no problems. The issues that I have found (and I don't know if the

Re: [Geany-devel] Safe file saving - permissions issue

2010-05-14 Thread Lex Trotman
Hi Jon, Some general comments first. Note I didn't have anything to do with the current design so this is a post facto analysis with no axe to grind. Files can go missing in any filesystem but clearly it happens more in networked ones. When that happens an application can't make any

Re: [Geany-devel] Safe file saving - permissions issue

2010-05-14 Thread Jon Senior
On Sat, 15 May 2010 14:10:06 +1000 Lex Trotman ele...@gmail.com wrote: Since it doesn't know the status of the directory the file was in or even the whole filesystem, and finding out could cause long delays as things time out, it is reasonable to ask the user where it is safe to save the file.

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-06 Thread Nick Treleaven
On Sat, 03 Apr 2010 03:51:18 +0400 Алексей Антипов 1a_anti...@mail.ru wrote: Please find the patch in attachment. When building with GIO, it would use g_file_replace_contents I think this is a good idea (but haven't tested it as I don't have GIO). However, I don't think we should change the

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Алексей Антипов
Sure, it does not alter permissions. I suppose that with make_backup=TRUE it would first (attempt to) copy previous file to a backup file, and only then write a new one. The annoying thing is that it would not delete a backup file, and the only way to get its name is to guess (usually for

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Lex Trotman
On 2 April 2010 03:07, Nick Treleaven nick.trelea...@btinternet.com wrote: On Thu, 1 Apr 2010 12:41:13 +0100 Nick Treleaven nick.trelea...@btinternet.com wrote: Btw, the bugs with GVFS didn't appear with GNOME 2.26 (and probably before), so I think we can safely use fopen() and

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Алексей Антипов
As goes from GLib sources, the final replace strategy is backend-dependent. For local files: (from GLib sources, gio/glocalfileoutputstream.c, handle_overwrite_open): /* We use two backup strategies. * The first one (which is faster) consist in saving to a * tmp file then rename the

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Алексей Антипов
Please find the patch in attachment. When building with GIO, it would use g_file_replace_contents Also, for those who are interested, I have found the reason for strange behaviour with gvfs-smb. The proposed patch is here: https://bugzilla.gnome.org/show_bug.cgi?id=614696 Fri, 02 Apr 2010

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Colomban Wendling
Hi, Lex Trotman a écrit : 2010/4/2 Алексей Антипов 1a_anti...@mail.ru mailto:1a_anti...@mail.ru As goes from GLib sources, the final replace strategy is backend-dependent. For local files: (from GLib sources, gio/glocalfileoutputstream.c, handle_overwrite_open):

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-02 Thread Lex Trotman
On 3 April 2010 13:20, Colomban Wendling lists@herbesfolles.org wrote: Hi, Lex Trotman a écrit : 2010/4/2 Алексей Антипов 1a_anti...@mail.ru mailto:1a_anti...@mail.ru As goes from GLib sources, the final replace strategy is backend-dependent. For local files:

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-01 Thread Nick Treleaven
On Wed, 31 Mar 2010 14:41:20 +0400 Алексей Антипов 1a_anti...@mail.ru wrote: Btw, the bugs with GVFS didn't appear with GNOME 2.26 (and probably before), so I think we can safely use fopen() and fprintf()/fwrite() there. Then, your proposal about version separation (use GIO with GLib=2.16

Re: [Geany-devel] Safe file saving - permissions issue

2010-04-01 Thread Nick Treleaven
On Thu, 1 Apr 2010 12:41:13 +0100 Nick Treleaven nick.trelea...@btinternet.com wrote: Btw, the bugs with GVFS didn't appear with GNOME 2.26 (and probably before), so I think we can safely use fopen() and fprintf()/fwrite() there. Then, your proposal about version separation (use GIO with

Re: [Geany-devel] Safe file saving - permissions issue

2010-03-31 Thread Алексей Антипов
Hi, I've considered that bug on sourceforge. According to it,other editors (e.g. gvim) also have problems saving to a dav:// URL, but they do not blank the file. gedit works just fine here.. GEdit seems to work via GIO, so the only more or less reliable solution is to use GIO where possible.

[Geany-devel] Safe file saving - permissions issue

2010-03-30 Thread Алексей Антипов
I've found one more issue with Geany's Safe file saving option. When using g_file_set_contents(), file ownership and permissions are replaced with those for a new file. That fully conforms to GLib documentation

Re: [Geany-devel] Safe file saving - permissions issue

2010-03-30 Thread Enrico Tröger
On Tue, 30 Mar 2010 16:28:25 +0400, Алексей wrote: Hi, I've found one more issue with Geany's Safe file saving option. When using g_file_set_contents(), file ownership and permissions are replaced with those for a new file. That fully conforms to GLib documentation

Re: [Geany-devel] Safe file saving

2010-02-06 Thread Enrico Tröger
On Fri, 05 Feb 2010 18:40:38 +0100, Dominic wrote: Am Freitag, den 05.02.2010, 12:14 +0300 schrieb Алексей Антипов: 2. (Possibly, but not necessarily) make this option (use_save_file_saving) accessible through the GUI Really? I think this would cause mainly just confusion. It just

Re: [Geany-devel] Safe file saving

2010-02-05 Thread Алексей Антипов
should be documented somewhere (I've found this one only while looking through the code), but it's not a question of that issue. -Original Message- From: Enrico Tr?ger enrico.troe...@uvena.de To: geany-devel@uvena.de Date: Thu, 4 Feb 2010 22:06:08 +0100 Subject: Re: [Geany-devel] Safe file

Re: [Geany-devel] Safe file saving

2010-02-05 Thread Dominic Hopf
Am Freitag, den 05.02.2010, 12:14 +0300 schrieb Алексей Антипов: 2. (Possibly, but not necessarily) make this option (use_save_file_saving) accessible through the GUI Really? I think this would cause mainly just confusion. It just isn't that easy to explain what's the story behind

Re: [Geany-devel] Safe file saving

2010-02-04 Thread Enrico Tröger
On Wed, 03 Feb 2010 21:03:12 +0300, Алексей wrote: Hello, I have recently faced a problem when Geany seemed to corrupt my files over GVFS. The issues were as follows: 1. Saving a modified text file (removing 1 line) over Samba (gvfsd-smb): - geany: makes a mess at the end of file -

[Geany-devel] Safe file saving

2010-02-03 Thread Алексей Антипов
Hello, I have recently faced a problem when Geany seemed to corrupt my files over GVFS. The issues were as follows: 1. Saving a modified text file (removing 1 line) over Samba (gvfsd-smb): - geany: makes a mess at the end of file - gedit: all OK 2. Saving a modified text file over SFTP