Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-21 Thread Nick Treleaven
On 21/09/2011 16:31, Nick Treleaven wrote: On 16/09/2011 18:11, Dimitar Zhekov wrote: Attached is the stash_tree_display(). I thought that a row changed signal will be needed, but it works without it. The renreders always reget their data when the tree is shown. No string changes. _append_pref(

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-21 Thread Nick Treleaven
On 16/09/2011 18:11, Dimitar Zhekov wrote: Attached is the stash_tree_display(). I thought that a row changed signal will be needed, but it works without it. The renreders always reget their data when the tree is shown. No string changes. _append_pref() ignores the new action argument. Thanks,

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-16 Thread Dimitar Zhekov
Hi, Attached is the stash_tree_display(). I thought that a row changed signal will be needed, but it works without it. The renreders always reget their data when the tree is shown. No string changes. _append_pref() ignores the new action argument. -- E-gards: Jimmy --- ./src/prefs.c.orig 2011-0

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-16 Thread Nick Treleaven
--- On Fri, 16/9/11, Dimitar Zhekov wrote: > > > What about traversing the model on reshow to > reset it to > > > the default values? > > > > Yes, that would be best. > > Of course, PREF_CANCEL was stupid. Actually, it should > create the > StartTreeValue entries on _setup, set them on PREF_DIS

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-16 Thread Dimitar Zhekov
On Fri, 16 Sep 2011 11:33:31 +0100 (BST) Nick Treleaven wrote: > > How about adding a PREF_CANCEL action to prefs.c only > > that will call a > > stash_group_cancel() to reset the values? > > I don't think that's a good design, the stash group settings should > not actually be changed until ok/a

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-16 Thread Nick Treleaven
--- On Thu, 15/9/11, Colomban Wendling wrote: > > How about adding a PREF_CANCEL action to prefs.c only > that will call a > > stash_group_cancel() to reset the values? The other I don't think that's a good design, the stash group settings should not actually be changed until ok/apply. Perhaps

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-15 Thread Colomban Wendling
Le 15/09/2011 19:59, Dimitar Zhekov a écrit : > On Thu, 15 Sep 2011 17:45:25 +0100 (BST) > Nick Treleaven wrote: > >> I've found a bug when changing a various pref setting in the prefs >> dialog, then cancelling the dialog without applying the changes. >> Next time the dialog is shown the edited

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-15 Thread Dimitar Zhekov
On Thu, 15 Sep 2011 17:45:25 +0100 (BST) Nick Treleaven wrote: > I've found a bug when changing a various pref setting in the prefs > dialog, then cancelling the dialog without applying the changes. > Next time the dialog is shown the edited values are still present. You are right, the problem i

Re: [Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-15 Thread Dimitar Zhekov
On Thu, 15 Sep 2011 17:45:25 +0100 (BST) Nick Treleaven wrote: > I've found a bug when changing a various pref setting in the prefs > dialog, then cancelling the dialog without applying the changes. > Next time the dialog is shown the edited values are still present. Yes, for the integer values.

[Geany-devel] Various pref changes not ignored on dialog cancel

2011-09-15 Thread Nick Treleaven
Hi, I've found a bug when changing a various pref setting in the prefs dialog, then cancelling the dialog without applying the changes. Next time the dialog is shown the edited values are still present. Could cause the user to then apply the unwanted changes without realizing, so it's quite a n