Re: [Geany-devel] Wrap words Addon patch

2012-03-21 Thread Frank Lanitz
Am 21.03.2012 00:33, schrieb Colomban Wendling:
 Le 20/03/2012 22:14, Frank Lanitz a écrit :
 On Tue, 13 Dec 2011 17:46:47 +0800
 Nathan Broadbent nathan@gmail.com wrote:

 1. Visit https://github.com/pzoxiuv/geany-plugins-1
 2. Click 'Pull Request'
 3. In the box on the right, you will see the heading 'Head branch ·
 tag · commit'. There is an input field next to pzoxiuv/geany... @,
 where you should type your branch (addons_wraptext).
 4. You can enter a title  description, and double check the commits
 and changes. If everything looks good, click 'Send pull request'

 
 I guess you were answering to my Wrap Word Addon patches mail?
 
 Once this is done and Nathan is happy with your code he will send the
 pull request to geany-plugins and most likely I will have tons of
 comments but finally will add it ;) 
 
 Hum huh heh heuu… what?  You mean I create a pull request on
 geany/gneay-plugins right?  I don't know who's Nathan actually, but I
 doubt he's the new addons maintainer -- or I missed some mails hard and
 I misread the MAINTAINERS file.

Nathan build the original patch set introducing wrap word into addons
plugin.

 Anyway, I created a pull request on the GP repo directly, hopefully it's
 what you meant and everything's fine.

Its fine.

Cheers,
Frank
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2012-03-21 Thread Colomban Wendling
Le 21/03/2012 08:21, Frank Lanitz a écrit :
 Am 21.03.2012 00:33, schrieb Colomban Wendling:
 Le 20/03/2012 22:14, Frank Lanitz a écrit :
 On Tue, 13 Dec 2011 17:46:47 +0800
 Nathan Broadbent nathan@gmail.com wrote:

 1. Visit https://github.com/pzoxiuv/geany-plugins-1
 2. Click 'Pull Request'
 3. In the box on the right, you will see the heading 'Head branch ·
 tag · commit'. There is an input field next to pzoxiuv/geany... @,
 where you should type your branch (addons_wraptext).
 4. You can enter a title  description, and double check the commits
 and changes. If everything looks good, click 'Send pull request'


 I guess you were answering to my Wrap Word Addon patches mail?

 Once this is done and Nathan is happy with your code he will send the
 pull request to geany-plugins and most likely I will have tons of
 comments but finally will add it ;) 

 Hum huh heh heuu… what?  You mean I create a pull request on
 geany/gneay-plugins right?  I don't know who's Nathan actually, but I
 doubt he's the new addons maintainer -- or I missed some mails hard and
 I misread the MAINTAINERS file.
 
 Nathan build the original patch set introducing wrap word into addons
 plugin.

If I read the mails and the blame correctly, it looks to me it was Alex
Meyer :)

 Anyway, I created a pull request on the GP repo directly, hopefully it's
 what you meant and everything's fine.
 
 Its fine.

Cool.


Cheers,
Colomban

 
 Cheers,
 Frank
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2012-03-21 Thread Frank Lanitz
Am 21.03.2012 15:14, schrieb Colomban Wendling:
 Le 21/03/2012 08:21, Frank Lanitz a écrit :
 Am 21.03.2012 00:33, schrieb Colomban Wendling:
 Le 20/03/2012 22:14, Frank Lanitz a écrit :
 On Tue, 13 Dec 2011 17:46:47 +0800
 Nathan Broadbent nathan@gmail.com wrote:

 1. Visit https://github.com/pzoxiuv/geany-plugins-1
 2. Click 'Pull Request'
 3. In the box on the right, you will see the heading 'Head branch ·
 tag · commit'. There is an input field next to pzoxiuv/geany... @,
 where you should type your branch (addons_wraptext).
 4. You can enter a title  description, and double check the commits
 and changes. If everything looks good, click 'Send pull request'


 I guess you were answering to my Wrap Word Addon patches mail?

 Once this is done and Nathan is happy with your code he will send the
 pull request to geany-plugins and most likely I will have tons of
 comments but finally will add it ;) 

 Hum huh heh heuu… what?  You mean I create a pull request on
 geany/gneay-plugins right?  I don't know who's Nathan actually, but I
 doubt he's the new addons maintainer -- or I missed some mails hard and
 I misread the MAINTAINERS file.

 Nathan build the original patch set introducing wrap word into addons
 plugin.
 
 If I read the mails and the blame correctly, it looks to me it was Alex
 Meyer :)

Oh yepp. You are right. Sorry for blaming the wrong guy. ;)

Cheers,
Frank

___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2012-03-21 Thread Frank Lanitz
On Wed, 21 Mar 2012 15:31:50 +0100
Frank Lanitz fr...@frank.uvena.de wrote:

 Am 21.03.2012 15:14, schrieb Colomban Wendling:
  Le 21/03/2012 08:21, Frank Lanitz a écrit :
  Am 21.03.2012 00:33, schrieb Colomban Wendling:
  Le 20/03/2012 22:14, Frank Lanitz a écrit :
  On Tue, 13 Dec 2011 17:46:47 +0800
  Nathan Broadbent nathan@gmail.com wrote:
 
  1. Visit https://github.com/pzoxiuv/geany-plugins-1
  2. Click 'Pull Request'
  3. In the box on the right, you will see the heading 'Head
  branch · tag · commit'. There is an input field next to
  pzoxiuv/geany... @, where you should type your branch
  (addons_wraptext).
  4. You can enter a title  description, and double check the
  commits and changes. If everything looks good, click 'Send pull
  request'
 
 
  I guess you were answering to my Wrap Word Addon patches mail?
 
  Once this is done and Nathan is happy with your code he will
  send the pull request to geany-plugins and most likely I will
  have tons of comments but finally will add it ;) 
 
  Hum huh heh heuu… what?  You mean I create a pull request on
  geany/gneay-plugins right?  I don't know who's Nathan actually,
  but I doubt he's the new addons maintainer -- or I missed some
  mails hard and I misread the MAINTAINERS file.
 
  Nathan build the original patch set introducing wrap word into
  addons plugin.
  
  If I read the mails and the blame correctly, it looks to me it was
  Alex Meyer :)
 
 Oh yepp. You are right. Sorry for blaming the wrong guy. ;)

And now I recognized that I messed up whole thread. OMFG 
-- 
http://frank.uvena.de/en/


pgpW8m1vGT8yB.pgp
Description: PGP signature
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2012-03-20 Thread Frank Lanitz
On Tue, 13 Dec 2011 17:46:47 +0800
Nathan Broadbent nathan@gmail.com wrote:

 1. Visit https://github.com/pzoxiuv/geany-plugins-1
 2. Click 'Pull Request'
 3. In the box on the right, you will see the heading 'Head branch ·
 tag · commit'. There is an input field next to pzoxiuv/geany... @,
 where you should type your branch (addons_wraptext).
 4. You can enter a title  description, and double check the commits
 and changes. If everything looks good, click 'Send pull request'

Once this is done and Nathan is happy with your code he will send the
pull request to geany-plugins and most likely I will have tons of
comments but finally will add it ;) 

Cheers, 
Frank 
-- 
http://frank.uvena.de/en/


pgpfl84JWcwe5.pgp
Description: PGP signature
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2012-03-20 Thread Colomban Wendling
Le 20/03/2012 22:14, Frank Lanitz a écrit :
 On Tue, 13 Dec 2011 17:46:47 +0800
 Nathan Broadbent nathan@gmail.com wrote:
 
 1. Visit https://github.com/pzoxiuv/geany-plugins-1
 2. Click 'Pull Request'
 3. In the box on the right, you will see the heading 'Head branch ·
 tag · commit'. There is an input field next to pzoxiuv/geany... @,
 where you should type your branch (addons_wraptext).
 4. You can enter a title  description, and double check the commits
 and changes. If everything looks good, click 'Send pull request'
 

I guess you were answering to my Wrap Word Addon patches mail?

 Once this is done and Nathan is happy with your code he will send the
 pull request to geany-plugins and most likely I will have tons of
 comments but finally will add it ;) 

Hum huh heh heuu… what?  You mean I create a pull request on
geany/gneay-plugins right?  I don't know who's Nathan actually, but I
doubt he's the new addons maintainer -- or I missed some mails hard and
I misread the MAINTAINERS file.

Anyway, I created a pull request on the GP repo directly, hopefully it's
what you meant and everything's fine.

Cheers,
Colomban

 
 Cheers, 
 Frank 
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


Re: [Geany-devel] Wrap words Addon patch

2011-12-13 Thread Nathan Broadbent
 Now that the geany-plugins has been converted to Git, I thought I'd post
 this patch that adds the feature I've been working on (wrapping text with
 characters) to the Addons plugin.  Any chance of it being added?

Hi Alex,

Now that geany-plugins is on github, we can take advantage of the
awesome 'Pull Request' feature.
Everyone should read the introduction to pull requests if they are new
to github. [1]

Here's how you can send a pull request from your fork of geany-plugins:

1. Visit https://github.com/pzoxiuv/geany-plugins-1
2. Click 'Pull Request'
3. In the box on the right, you will see the heading 'Head branch ·
tag · commit'. There is an input field next to pzoxiuv/geany... @,
where you should type your branch (addons_wraptext).
4. You can enter a title  description, and double check the commits
and changes. If everything looks good, click 'Send pull request'


This is a lot more powerful than mailing patches back and forth. The
'patch' can be updated easily by adding new commits to your branch,
and anyone can add comments to any of the changed lines.


Best regards,
Nathan


[1]: http://help.github.com/send-pull-requests/
___
Geany-devel mailing list
Geany-devel@uvena.de
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel


[Geany-devel] Wrap words Addon patch

2011-12-11 Thread Meyer
Now that the geany-plugins has been converted to Git, I thought I'd post
this patch that adds the feature I've been working on (wrapping text with
characters) to the Addons plugin.  Any chance of it being added?

And I've never really used Git before too, so please let me know if the
patch is incorrectly made or something.

Cheers
Alex
From e0027703185c7952d9d5e8d4f9477c542c73f6a6 Mon Sep 17 00:00:00 2001
From: Alex M 3m.me...@gmail.com
Date: Sat, 10 Dec 2011 17:40:16 -0500
Subject: [PATCH] Adds wrap words feature to Addons plugin.

---
 addons/src/Makefile.am|4 +-
 addons/src/addons.c   |   48 +++-
 addons/src/ao_wrapwords.c |  300 +
 addons/src/ao_wrapwords.h |   28 
 4 files changed, 376 insertions(+), 4 deletions(-)
 create mode 100644 addons/src/ao_wrapwords.c
 create mode 100644 addons/src/ao_wrapwords.h

diff --git a/addons/src/Makefile.am b/addons/src/Makefile.am
index 2a386d5..eabb6e8 100644
--- a/addons/src/Makefile.am
+++ b/addons/src/Makefile.am
@@ -16,6 +16,7 @@ addons_la_SOURCES = \
 	ao_markword.h \
 	ao_tasks.h \
 	ao_xmltagging.h \
+	ao_wrapwords.h \
 	addons.c \
 	ao_blanklines.c \
 	ao_doclist.c \
@@ -24,7 +25,8 @@ addons_la_SOURCES = \
 	ao_bookmarklist.c \
 	ao_markword.c \
 	ao_tasks.c \
-	ao_xmltagging.c
+	ao_xmltagging.c \
+	ao_wrapwords.c
 
 addons_la_LIBADD = $(COMMONLIBS)
 
diff --git a/addons/src/addons.c b/addons/src/addons.c
index 73a5840..93c81d0 100644
--- a/addons/src/addons.c
+++ b/addons/src/addons.c
@@ -37,7 +37,7 @@
 #include ao_markword.h
 #include ao_tasks.h
 #include ao_xmltagging.h
-
+#include ao_wrapwords.h
 
 
 GeanyPlugin		*geany_plugin;
@@ -77,6 +77,8 @@ typedef struct
 	gboolean enable_bookmarklist;
 	gboolean enable_markword;
 	gboolean enable_xmltagging;
+	gboolean enable_wrapwords;
+	gboolean enable_wrapwords_auto;
 	gboolean strip_trailing_blank_lines;
 
 	gchar *tasks_token_list;
@@ -271,6 +273,10 @@ void plugin_init(GeanyData *data)
 		addons, strip_trailing_blank_lines, FALSE);
 	ao_info-enable_xmltagging = utils_get_setting_boolean(config, addons,
 		enable_xmltagging, FALSE);
+	ao_info-enable_wrapwords = utils_get_setting_boolean(config, addons,
+		enable_wrapwords, FALSE);
+	ao_info-enable_wrapwords_auto = utils_get_setting_boolean(config, addons,
+		enable_wrapwords_auto, FALSE);
 
 	plugin_module_make_resident(geany_plugin);
 
@@ -283,9 +289,9 @@ void plugin_init(GeanyData *data)
 		ao_info-tasks_token_list, ao_info-tasks_scan_all_documents);
 
 	ao_blanklines_set_enable(ao_info-strip_trailing_blank_lines);
-
+	
 	/* setup keybindings */
-	key_group = plugin_set_key_group(geany_plugin, addons, KB_COUNT, NULL);
+	key_group = plugin_set_key_group(geany_plugin, addons, KB_COUNT+8, NULL);
 	keybindings_set_item(key_group, KB_FOCUS_BOOKMARK_LIST, kb_bmlist_activate,
 		0, 0, focus_bookmark_list, _(Focus Bookmark List), NULL);
 	keybindings_set_item(key_group, KB_FOCUS_TASKS, kb_tasks_activate,
@@ -295,6 +301,9 @@ void plugin_init(GeanyData *data)
 	keybindings_set_item(key_group, KB_XMLTAGGING, kb_ao_xmltagging,
 		0, 0, xml_tagging, _(Run XML tagging), NULL);
 
+	ao_wrapwords_init(ao_info-config_file, key_group);
+	ao_wrapwords_set_enabled (ao_info-enable_wrapwords, ao_info-enable_wrapwords_auto);
+
 	g_key_file_free(config);
 }
 
@@ -359,6 +368,12 @@ static void ao_configure_response_cb(GtkDialog *dialog, gint response, gpointer
 			g_object_get_data(G_OBJECT(dialog), check_blanklines;
 		ao_info-enable_xmltagging = (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(
 			g_object_get_data(G_OBJECT(dialog), check_xmltagging;
+		ao_info-enable_wrapwords = (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(
+			g_object_get_data(G_OBJECT(dialog), check_wrapwords;
+		ao_info-enable_wrapwords_auto = (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(
+			g_object_get_data(G_OBJECT(dialog), check_wrapwords_auto;
+			
+		ao_wrapwords_set_enabled (ao_info-enable_wrapwords, ao_info-enable_wrapwords_auto);
 
 		g_key_file_load_from_file(config, ao_info-config_file, G_KEY_FILE_NONE, NULL);
 		g_key_file_set_boolean(config, addons,
@@ -377,6 +392,10 @@ static void ao_configure_response_cb(GtkDialog *dialog, gint response, gpointer
 		  ao_info-strip_trailing_blank_lines);
 		g_key_file_set_boolean(config, addons, enable_xmltagging,
 			ao_info-enable_xmltagging);
+		g_key_file_set_boolean(config, addons, enable_wrapwords,
+			ao_info-enable_wrapwords);
+		g_key_file_set_boolean(config, addons, enable_wrapwords_auto,
+			ao_info-enable_wrapwords_auto);
 
 		g_object_set(ao_info-doclist, enable-doclist, ao_info-enable_doclist, NULL);
 		g_object_set(ao_info-doclist, sort-mode, ao_info-doclist_sort_mode, NULL);
@@ -418,6 +437,7 @@ GtkWidget *plugin_configure(GtkDialog *dialog)
 	GtkWidget *check_bookmarklist, *check_markword, *frame_tasks, *vbox_tasks;
 	GtkWidget *check_tasks_scan_mode, *entry_tasks_tokens, *label_tasks_tokens, *tokens_hbox;
 	GtkWidget *check_blanklines, *check_xmltagging;