Re: [Geany-devel] regular|symlink file tests

2010-07-05 Thread Nick Treleaven
On Sun, 4 Jul 2010 15:26:09 +0300 Dimitar Zhekov wrote: > On Sun, 4 Jul 2010 11:09:28 +0200 > Frank Lanitz wrote: > > > > I think G_FILE_TEST_IS_REGULAR | G_FILE_TEST_IS_SYMLINK should be > > > replaced with G_FILE_TEST_IS_REGULAR. > > > > Yes indeed. The or doesn't seem to make big sense here

Re: [Geany-devel] regular|symlink file tests

2010-07-04 Thread Dimitar Zhekov
On Sun, 4 Jul 2010 11:09:28 +0200 Frank Lanitz wrote: > > I think G_FILE_TEST_IS_REGULAR | G_FILE_TEST_IS_SYMLINK should be > > replaced with G_FILE_TEST_IS_REGULAR. > > Yes indeed. The or doesn't seem to make big sense here. Here is a patch then. -- E-gards: Jimmy --- ./src/editor.c.orig 201

Re: [Geany-devel] regular|symlink file tests

2010-07-04 Thread Frank Lanitz
On Sat, 26 Jun 2010 16:03:44 +0300 Dimitar Zhekov wrote: > Hi, > > In geany, there are a few checks of the type: > > g_file_test(, G_FILE_TEST_IS_REGULAR | > G_FILE_TEST_IS_SYMLINK) > > which presumably check if is a regular file, or a symlink to > one. However, G_FILE_TEST_IS_REGULAR follows

[Geany-devel] regular|symlink file tests

2010-06-26 Thread Dimitar Zhekov
Hi, In geany, there are a few checks of the type: g_file_test(, G_FILE_TEST_IS_REGULAR | G_FILE_TEST_IS_SYMLINK) which presumably check if is a regular file, or a symlink to one. However, G_FILE_TEST_IS_REGULAR follows symlinks and is enough for the test, while G_FILE_TEST_IS_SYMLINK (and conse